From 5de194ffbed13a828d70c3c73234e9825a97843f Mon Sep 17 00:00:00 2001 From: Anonymous Date: Mon, 8 Apr 2019 11:58:40 -0700 Subject: Import of Volley from GitHub to AOSP. - dbfc43945655acaf7cc18e4a30ceb26a46c05f58 Adding setDefaultImageDrawable and setErrorImageDrawable ... by Yuhan Zhao - 83ea07d3e3ea251221da834c43705897dec6d34e Pin to a specific errorprone version. (#266) by Jeff Davidson GitOrigin-RevId: dbfc43945655acaf7cc18e4a30ceb26a46c05f58 Change-Id: If34fda708841eb5bf3788865b66e23f342523537 --- build.gradle | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) (limited to 'build.gradle') diff --git a/build.gradle b/build.gradle index 1765a3a..828a192 100644 --- a/build.gradle +++ b/build.gradle @@ -14,6 +14,8 @@ // include(":volley") // project(':volley').buildFileName = 'rules.gradle' +import net.ltgt.gradle.errorprone.CheckSeverity + buildscript { repositories { jcenter() @@ -26,7 +28,9 @@ buildscript { plugins { id "com.github.sherter.google-java-format" version "0.6" - id "net.ltgt.errorprone" version "0.0.13" + // NOTE: 0.7 or newer will require upgrading to a newer Android gradle plugin: + // https://github.com/tbroyer/gradle-errorprone-plugin/commit/65b1026ebeae1b7ed8c28578c7f6eea512c16bea + id "net.ltgt.errorprone" version "0.6.1" } googleJavaFormat { @@ -41,6 +45,15 @@ repositories { google() } +dependencies { + // NOTE: Updating ErrorProne introduces new checks that may cause the build to fail. Pin to a + // specific version to control these updates. + errorprone("com.google.errorprone:error_prone_core:2.3.2") + // ErrorProne requires a JDK 9 compiler, so pull one in as a dependency since we use Java 8: + // https://github.com/tbroyer/gradle-errorprone-plugin#jdk-8-support + errorproneJavac("com.google.errorprone:javac:9+181-r4173-1") +} + group = 'com.android.volley' version = '1.2.0-SNAPSHOT' @@ -55,7 +68,9 @@ android { } tasks.withType(JavaCompile) { - options.compilerArgs << "-Xep:ParameterComment:ERROR" + options.errorprone { + check("ParameterComment", CheckSeverity.ERROR) + } } apply from: 'rules.gradle' -- cgit v1.2.3