diff options
| author | Petr Kraus <petr_kraus@email.cz> | 2019-08-21 00:31:47 +0200 |
|---|---|---|
| committer | Mark Lobodzinski <mark@lunarg.com> | 2019-08-22 15:54:10 -0600 |
| commit | 87304ec428ead84b876599cb3e44005b61fff527 (patch) | |
| tree | 651aad32eb4b194423e1824d5e681ba6c50b5088 | |
| parent | 5c3672d27eb062a666955562ea5317a630689b4e (diff) | |
| download | vulkan-validation-layers-87304ec428ead84b876599cb3e44005b61fff527.tar.gz | |
layers: Re-ban ray tracing stages in render pass
per resolution in https://github.com/KhronosGroup/Vulkan-Docs/issues/1021
| -rw-r--r-- | layers/stateless_validation.h | 19 |
1 files changed, 0 insertions, 19 deletions
diff --git a/layers/stateless_validation.h b/layers/stateless_validation.h index a7a19d616..199536ccc 100644 --- a/layers/stateless_validation.h +++ b/layers/stateless_validation.h @@ -860,13 +860,6 @@ class StatelessValidation : public ValidationObject { kMeshShadingPipelineStages | kFragmentDensityStages | kConditionalRenderingStages | kCommandProcessingPipelineStages; - const VkPipelineStageFlags kRayTracingPipelineStages = kCommonStages | VK_PIPELINE_STAGE_RAY_TRACING_SHADER_BIT_NV; - const VkPipelineStageFlags kRayTracingAccellerationStructOpsStages = - kCommonStages | VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_NV; - const VkPipelineStageFlags kRayTracingStages = kCommonStages | kRayTracingPipelineStages | - kRayTracingAccellerationStructOpsStages | kFragmentDensityStages | - kConditionalRenderingStages | kCommandProcessingPipelineStages; - bool skip = false; const auto IsPipeline = [pCreateInfo](uint32_t subpass, const VkPipelineBindPoint stage) { @@ -886,18 +879,6 @@ class StatelessValidation : public ValidationObject { dependency_index, target, string_VkPipelineStageFlags(stages & ~kGraphicsStages).c_str(), target, subpass); } - // TODO: Raytracing also allowed here? See https://github.com/KhronosGroup/Vulkan-Docs/issues/1021 - // There's no harm in validating it even if not sure, I think... - const bool is_all_raytracing_stages = (stages & ~kRayTracingStages) == 0; - if (IsPipeline(subpass, VK_PIPELINE_BIND_POINT_RAY_TRACING_NV) && !is_all_raytracing_stages) { - skip |= - log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 0, vuid, - "Dependency pDependencies[%" PRIu32 - "] specifies a %sStageMask that contains stages (%s) that are not part " - "of the Ray Tracing pipeline, as specified by the %sSubpass (= %" PRIu32 ") in pipelineBindPoint.", - dependency_index, target, string_VkPipelineStageFlags(stages & ~kGraphicsStages).c_str(), target, subpass); - } - return skip; }; |