diff options
| author | Chad Versace <chad.versace@linux.intel.com> | 2014-04-20 10:26:06 -0700 |
|---|---|---|
| committer | Chad Versace <chad.versace@linux.intel.com> | 2014-04-20 10:31:13 -0700 |
| commit | fe0a944a381dcfe791cb514152197b1abb8b83e0 (patch) | |
| tree | 5e1fec2ac51f2cb367babe98e2da2596d1a0e3c8 | |
| parent | 622d39b031de5346c6938617fee16b2ca600353d (diff) | |
| download | waffle-fe0a944a381dcfe791cb514152197b1abb8b83e0.tar.gz | |
linux_dl: Update stale comments before Mesa shipped ES3
Before Mesa shipped ES3, Waffle speculated that the library name would
remain libGLESv2.so. Speculation became reality. Update some comments
to replace that speculation with a statement of fact.
Reported-by: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
| -rw-r--r-- | src/waffle/linux/linux_dl.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/waffle/linux/linux_dl.c b/src/waffle/linux/linux_dl.c index 8a154f1..7fd000b 100644 --- a/src/waffle/linux/linux_dl.c +++ b/src/waffle/linux/linux_dl.c @@ -58,13 +58,13 @@ linux_dl_get_name(int32_t waffle_dl) return "libGLESv1_CM.so"; case WAFFLE_DL_OPENGL_ES2: case WAFFLE_DL_OPENGL_ES3: - // TODO(chadv): Update the libGLESv2 soversion number to match - // shipping OpenGL ES 3.0 libraries. - // - // Currently (2012-11-11), no vendor ships OpenGL ES 3.0. I - // expect that vendors will increment the minor soversion of - // libGLESv2 if it supports OpenGL ES 3.0, which would aid - // Waffle in detecting the platform's OpenGL ES 3.0 support. + // As of 2014-04-20, Mesa statically provides the ES2 and ES3 + // symbols symbols in libGLESv2.so and provides no ES3-only library + // + // Even though Waffle does not use the library's soname, note that + // Mesa did not change the library's soname when it added the ES3 + // symbols. The soname was and is libGLESv2.so.2 before and after + // ES3. return "libGLESv2.so"; default: wcore_error_internal("waffle_dl has bad value %#x", waffle_dl); |