diff options
| author | Henrik Kjellander <kjellander@webrtc.org> | 2015-05-25 12:55:39 +0200 |
|---|---|---|
| committer | Henrik Kjellander <kjellander@webrtc.org> | 2015-05-25 10:55:50 +0000 |
| commit | 57e5fd2e604ff7e60425c3f7654b40da03fc763c (patch) | |
| tree | c2955f0767b14356b6dea5af58f2d187716f1114 /.gn | |
| parent | 00aac5aacfa1778cafa1a67036743df990e21153 (diff) | |
| download | webrtc-57e5fd2e604ff7e60425c3f7654b40da03fc763c.tar.gz | |
PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).
Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.
Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py
TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.
R=henrika@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50069004
Cr-Commit-Position: refs/heads/master@{#9274}
Diffstat (limited to '.gn')
| -rw-r--r-- | .gn | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -18,9 +18,7 @@ secondary_source = "//build/secondary/" # matching these patterns (see "gn help label_pattern" for format) will have # their includes checked for proper dependencies when you run either # "gn check" or "gn gen --check". -check_targets = [ - "//webrtc/*", -] +check_targets = [ "//webrtc/*" ] # These are the list of GN files that run exec_script. This whitelist exists # to force additional review for new uses of exec_script, which is strongly |