diff options
author | kjellander@webrtc.org <kjellander@google.com> | 2015-11-18 23:04:10 +0100 |
---|---|---|
committer | kjellander@webrtc.org <kjellander@google.com> | 2015-11-18 22:04:20 +0000 |
commit | b7ce96470b99510937e489bcb4dc3165a9ab1b28 (patch) | |
tree | a990f41700c4aa75ab61767d896599fdfe0241d7 | |
parent | 1b20d81d350678d4b3ee218bed124831e7e79666 (diff) | |
download | webrtc-b7ce96470b99510937e489bcb4dc3165a9ab1b28.tar.gz |
modules/video_coding/utility: Remove include
This makes it clearer this code not meant to be used as an API.
I could not find any use of this in downstream code.
BUG=webrtc:5095
TESTED=git cl try -c --bot=android_compile_rel --bot=linux_compile_rel --bot=win_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc
R=stefan@webrtc.org
TBR=magjed@webrtc.org
Review URL: https://codereview.webrtc.org/1440873005 .
Cr-Commit-Position: refs/heads/master@{#10699}
20 files changed, 42 insertions, 44 deletions
diff --git a/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc b/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc index 59747a159f..29bdbffca0 100644 --- a/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc +++ b/talk/app/webrtc/java/jni/androidmediaencoder_jni.cc @@ -36,8 +36,8 @@ #include "webrtc/base/thread_checker.h" #include "webrtc/modules/rtp_rtcp/source/h264_bitstream_parser.h" #include "webrtc/modules/video_coding/codecs/interface/video_codec_interface.h" -#include "webrtc/modules/video_coding/utility/include/quality_scaler.h" -#include "webrtc/modules/video_coding/utility/include/vp8_header_parser.h" +#include "webrtc/modules/video_coding/utility/quality_scaler.h" +#include "webrtc/modules/video_coding/utility/vp8_header_parser.h" #include "webrtc/system_wrappers/include/field_trial.h" #include "webrtc/system_wrappers/include/logcat_trace_context.h" #include "third_party/libyuv/include/libyuv/convert.h" diff --git a/webrtc/modules/video_coding/BUILD.gn b/webrtc/modules/video_coding/BUILD.gn index 609675f4e0..cbfe8c091e 100644 --- a/webrtc/modules/video_coding/BUILD.gn +++ b/webrtc/modules/video_coding/BUILD.gn @@ -94,14 +94,14 @@ source_set("video_coding") { source_set("video_coding_utility") { sources = [ "utility/frame_dropper.cc", - "utility/include/frame_dropper.h", - "utility/include/moving_average.h", - "utility/include/qp_parser.h", - "utility/include/quality_scaler.h", - "utility/include/vp8_header_parser.h", + "utility/frame_dropper.h", + "utility/moving_average.h", "utility/qp_parser.cc", + "utility/qp_parser.h", "utility/quality_scaler.cc", + "utility/quality_scaler.h", "utility/vp8_header_parser.cc", + "utility/vp8_header_parser.h", ] configs += [ "../..:common_config" ] diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h index 90a8b1b883..7628758209 100644 --- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h +++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h @@ -15,7 +15,7 @@ #include "webrtc/base/timeutils.h" #include "webrtc/modules/video_coding/codecs/vp8/temporal_layers.h" -#include "webrtc/modules/video_coding/utility/include/frame_dropper.h" +#include "webrtc/modules/video_coding/utility/frame_dropper.h" #include "webrtc/typedefs.h" namespace webrtc { diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc index 74e725a55c..f31ed5e4d8 100644 --- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc +++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc @@ -14,7 +14,7 @@ #include "webrtc/base/scoped_ptr.h" #include "webrtc/modules/video_coding/include/video_codec_interface.h" #include "webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h" -#include "webrtc/modules/video_coding/utility/include/mock/mock_frame_dropper.h" +#include "webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h" using ::testing::_; using ::testing::NiceMock; diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h index 78dfdb5047..597fb77970 100644 --- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h +++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h @@ -26,8 +26,8 @@ #include "webrtc/modules/video_coding/include/video_codec_interface.h" #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h" #include "webrtc/modules/video_coding/codecs/vp8/reference_picture_selection.h" -#include "webrtc/modules/video_coding/utility/include/frame_dropper.h" -#include "webrtc/modules/video_coding/utility/include/quality_scaler.h" +#include "webrtc/modules/video_coding/utility/frame_dropper.h" +#include "webrtc/modules/video_coding/utility/quality_scaler.h" #include "webrtc/video_frame.h" namespace webrtc { diff --git a/webrtc/modules/video_coding/media_optimization.cc b/webrtc/modules/video_coding/media_optimization.cc index bc01b54843..3ebebef247 100644 --- a/webrtc/modules/video_coding/media_optimization.cc +++ b/webrtc/modules/video_coding/media_optimization.cc @@ -13,7 +13,7 @@ #include "webrtc/base/logging.h" #include "webrtc/modules/video_coding/content_metrics_processing.h" #include "webrtc/modules/video_coding/qm_select.h" -#include "webrtc/modules/video_coding/utility/include/frame_dropper.h" +#include "webrtc/modules/video_coding/utility/frame_dropper.h" #include "webrtc/system_wrappers/include/clock.h" namespace webrtc { diff --git a/webrtc/modules/video_coding/utility/frame_dropper.cc b/webrtc/modules/video_coding/utility/frame_dropper.cc index 5262c5b88a..dfa7df841f 100644 --- a/webrtc/modules/video_coding/utility/frame_dropper.cc +++ b/webrtc/modules/video_coding/utility/frame_dropper.cc @@ -8,7 +8,7 @@ * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/video_coding/utility/include/frame_dropper.h" +#include "webrtc/modules/video_coding/utility/frame_dropper.h" #include "webrtc/system_wrappers/include/trace.h" diff --git a/webrtc/modules/video_coding/utility/include/frame_dropper.h b/webrtc/modules/video_coding/utility/frame_dropper.h index 2b78a7264f..2293cefed2 100644 --- a/webrtc/modules/video_coding/utility/include/frame_dropper.h +++ b/webrtc/modules/video_coding/utility/frame_dropper.h @@ -8,23 +8,21 @@ * be found in the AUTHORS file in the root of the source tree. */ -#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_FRAME_DROPPER_H_ -#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_FRAME_DROPPER_H_ +#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_FRAME_DROPPER_H_ +#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_FRAME_DROPPER_H_ #include <cstddef> #include "webrtc/base/exp_filter.h" #include "webrtc/typedefs.h" -namespace webrtc -{ +namespace webrtc { // The Frame Dropper implements a variant of the leaky bucket algorithm // for keeping track of when to drop frames to avoid bit rate // over use when the encoder can't keep its bit rate. -class FrameDropper -{ -public: +class FrameDropper { + public: FrameDropper(); explicit FrameDropper(float max_time_drops); virtual ~FrameDropper() {} @@ -69,7 +67,7 @@ public: // instruction of when to drop frames. virtual float ActualFrameRate(uint32_t inputFrameRate) const; -private: + private: void FillBucket(float inKbits, float outKbits); void UpdateRatio(); void CapAccumulator(); @@ -91,8 +89,8 @@ private: bool _fastMode; float _cap_buffer_size; float _max_time_drops; -}; // end of VCMFrameDropper class +}; // end of VCMFrameDropper class } // namespace webrtc -#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_FRAME_DROPPER_H_ +#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_FRAME_DROPPER_H_ diff --git a/webrtc/modules/video_coding/utility/include/mock/mock_frame_dropper.h b/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h index 1e31e5442a..dee00ba0b5 100644 --- a/webrtc/modules/video_coding/utility/include/mock/mock_frame_dropper.h +++ b/webrtc/modules/video_coding/utility/mock/mock_frame_dropper.h @@ -7,13 +7,13 @@ * in the file PATENTS. All contributing project authors may * be found in the AUTHORS file in the root of the source tree. */ -#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_MOCK_MOCK_FRAME_DROPPER_H_ -#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_MOCK_MOCK_FRAME_DROPPER_H_ +#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_MOCK_MOCK_FRAME_DROPPER_H_ +#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_MOCK_MOCK_FRAME_DROPPER_H_ #include <string> #include "testing/gmock/include/gmock/gmock.h" -#include "webrtc/modules/video_coding/utility/include/frame_dropper.h" +#include "webrtc/modules/video_coding/utility/frame_dropper.h" #include "webrtc/typedefs.h" namespace webrtc { @@ -38,4 +38,4 @@ class MockFrameDropper : public FrameDropper { } // namespace webrtc -#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_INCLUDE_MOCK_MOCK_FRAME_DROPPER_H_ +#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_MOCK_MOCK_FRAME_DROPPER_H_ diff --git a/webrtc/modules/video_coding/utility/include/moving_average.h b/webrtc/modules/video_coding/utility/moving_average.h index 49c42c4ed4..8de1dd2a43 100644 --- a/webrtc/modules/video_coding/utility/include/moving_average.h +++ b/webrtc/modules/video_coding/utility/moving_average.h @@ -68,4 +68,4 @@ int MovingAverage<T>::size() { } // namespace webrtc -#endif // WEBRTC_MODULES_VIDEO_CODING_MOVING_AVERAGE_SCALER_H_ +#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_MOVING_AVERAGE_H_ diff --git a/webrtc/modules/video_coding/utility/qp_parser.cc b/webrtc/modules/video_coding/utility/qp_parser.cc index 62ce31351e..0916cb0094 100644 --- a/webrtc/modules/video_coding/utility/qp_parser.cc +++ b/webrtc/modules/video_coding/utility/qp_parser.cc @@ -8,10 +8,10 @@ * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/video_coding/utility/include/qp_parser.h" +#include "webrtc/modules/video_coding/utility/qp_parser.h" #include "webrtc/common_types.h" -#include "webrtc/modules/video_coding/utility/include/vp8_header_parser.h" +#include "webrtc/modules/video_coding/utility/vp8_header_parser.h" namespace webrtc { diff --git a/webrtc/modules/video_coding/utility/include/qp_parser.h b/webrtc/modules/video_coding/utility/qp_parser.h index 0b644ef61c..0b644ef61c 100644 --- a/webrtc/modules/video_coding/utility/include/qp_parser.h +++ b/webrtc/modules/video_coding/utility/qp_parser.h diff --git a/webrtc/modules/video_coding/utility/quality_scaler.cc b/webrtc/modules/video_coding/utility/quality_scaler.cc index ec7715230e..9aae17c6b6 100644 --- a/webrtc/modules/video_coding/utility/quality_scaler.cc +++ b/webrtc/modules/video_coding/utility/quality_scaler.cc @@ -7,7 +7,7 @@ * in the file PATENTS. All contributing project authors may * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/video_coding/utility/include/quality_scaler.h" +#include "webrtc/modules/video_coding/utility/quality_scaler.h" namespace webrtc { diff --git a/webrtc/modules/video_coding/utility/include/quality_scaler.h b/webrtc/modules/video_coding/utility/quality_scaler.h index 29a1496c05..a1233cca51 100644 --- a/webrtc/modules/video_coding/utility/include/quality_scaler.h +++ b/webrtc/modules/video_coding/utility/quality_scaler.h @@ -12,7 +12,7 @@ #define WEBRTC_MODULES_VIDEO_CODING_UTILITY_QUALITY_SCALER_H_ #include "webrtc/common_video/libyuv/include/scaler.h" -#include "webrtc/modules/video_coding/utility/include/moving_average.h" +#include "webrtc/modules/video_coding/utility/moving_average.h" namespace webrtc { class QualityScaler { diff --git a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc index 2ce1107472..58f7bee484 100644 --- a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc +++ b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc @@ -8,7 +8,7 @@ * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/video_coding/utility/include/quality_scaler.h" +#include "webrtc/modules/video_coding/utility/quality_scaler.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/webrtc/modules/video_coding/utility/video_coding_utility.gyp b/webrtc/modules/video_coding/utility/video_coding_utility.gyp index f0764bb7bf..42cbb3d4e0 100644 --- a/webrtc/modules/video_coding/utility/video_coding_utility.gyp +++ b/webrtc/modules/video_coding/utility/video_coding_utility.gyp @@ -19,14 +19,14 @@ ], 'sources': [ 'frame_dropper.cc', - 'include/frame_dropper.h', - 'include/moving_average.h', - 'include/qp_parser.h', - 'include/quality_scaler.h', - 'include/vp8_header_parser.h', + 'frame_dropper.h', + 'moving_average.h', 'qp_parser.cc', + 'qp_parser.h', 'quality_scaler.cc', + 'quality_scaler.h', 'vp8_header_parser.cc', + 'vp8_header_parser.h', ], }, ], # targets diff --git a/webrtc/modules/video_coding/utility/vp8_header_parser.cc b/webrtc/modules/video_coding/utility/vp8_header_parser.cc index 6786f9dea8..13d1616210 100644 --- a/webrtc/modules/video_coding/utility/vp8_header_parser.cc +++ b/webrtc/modules/video_coding/utility/vp8_header_parser.cc @@ -7,7 +7,7 @@ * in the file PATENTS. All contributing project authors may * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/video_coding/utility/include/vp8_header_parser.h" +#include "webrtc/modules/video_coding/utility/vp8_header_parser.h" #include "webrtc/base/logging.h" diff --git a/webrtc/modules/video_coding/utility/include/vp8_header_parser.h b/webrtc/modules/video_coding/utility/vp8_header_parser.h index 711ca8f599..b4b1d3356f 100644 --- a/webrtc/modules/video_coding/utility/include/vp8_header_parser.h +++ b/webrtc/modules/video_coding/utility/vp8_header_parser.h @@ -8,8 +8,8 @@ * be found in the AUTHORS file in the root of the source tree. */ -#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_PARSE_HEADER_H_ -#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_PARSE_HEADER_H_ +#ifndef WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_HEADER_PARSER_H_ +#define WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_HEADER_PARSER_H_ #include <stdint.h> #include <stdio.h> @@ -77,4 +77,4 @@ bool GetQp(const uint8_t* buf, size_t length, int* qp); } // namespace webrtc -#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_PARSE_HEADER_H_ +#endif // WEBRTC_MODULES_VIDEO_CODING_UTILITY_VP8_HEADER_PARSER_H_ diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h index cbe7ac6066..38fe9ed710 100644 --- a/webrtc/modules/video_coding/video_coding_impl.h +++ b/webrtc/modules/video_coding/video_coding_impl.h @@ -25,7 +25,7 @@ #include "webrtc/modules/video_coding/media_optimization.h" #include "webrtc/modules/video_coding/receiver.h" #include "webrtc/modules/video_coding/timing.h" -#include "webrtc/modules/video_coding/utility/include/qp_parser.h" +#include "webrtc/modules/video_coding/utility/qp_parser.h" #include "webrtc/system_wrappers/include/clock.h" #include "webrtc/system_wrappers/include/critical_section_wrapper.h" diff --git a/webrtc/modules/video_coding/video_sender.cc b/webrtc/modules/video_coding/video_sender.cc index 6aedf4e1d2..331a7ed38e 100644 --- a/webrtc/modules/video_coding/video_sender.cc +++ b/webrtc/modules/video_coding/video_sender.cc @@ -17,8 +17,8 @@ #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h" #include "webrtc/modules/video_coding/include/video_codec_interface.h" #include "webrtc/modules/video_coding/encoded_frame.h" +#include "webrtc/modules/video_coding/utility/quality_scaler.h" #include "webrtc/modules/video_coding/video_coding_impl.h" -#include "webrtc/modules/video_coding/utility/include/quality_scaler.h" #include "webrtc/system_wrappers/include/clock.h" namespace webrtc { |