diff options
author | android-build-team Robot <android-build-team-robot@google.com> | 2017-08-10 08:10:04 +0000 |
---|---|---|
committer | android-build-team Robot <android-build-team-robot@google.com> | 2017-08-10 08:10:04 +0000 |
commit | 7ae782ba204882ef65781f3b407b66293479e655 (patch) | |
tree | f04336a75902fbe1f77d811576553bb3c0a187e4 | |
parent | f3767f20835ab833e1443131073eeb2dd3d4fbe0 (diff) | |
parent | 27e27fd000a27903abd66d9e366d72b3e27dc4b3 (diff) | |
download | webrtc-7ae782ba204882ef65781f3b407b66293479e655.tar.gz |
release-request-0b474cbb-ff20-424d-a570-a0a7b83a7705-for-git_pi-release-4262110 snap-temp-L42700000091449286
Change-Id: I8b558dc7cd35c109138a6ed2ad0d6d9d5cabe928
20 files changed, 71 insertions, 21 deletions
diff --git a/android-webrtc.mk b/android-webrtc.mk index f64a92dd67..a0dfd65fc0 100644 --- a/android-webrtc.mk +++ b/android-webrtc.mk @@ -44,3 +44,32 @@ MY_WEBRTC_COMMON_DEFS_arm := \ #MY_WEBRTC_COMMON_DEFS_arm += \ # '-DWEBRTC_ARCH_ARM_V7A' #endif + +# The following warnings are disabled in most webrtc modules, +# until we upgrade to newer cleaner upstream webrtc. +MY_WEBRTC_COMMON_CFLAGS_WARNINGS := \ + -Wno-missing-field-initializers \ + -Wno-unused-parameter \ + +# The following clang-tidy checks are disabled in most webrtc modules, +# until we upgrade to newer cleaner upstream webrtc. +MY_WEBRTC_COMMON_TIDY_CHECKS := \ + -cert-*, \ + -clang-analyzer-*, \ + -hicpp-*, \ + -llvm-*, \ + -google-build-namespaces, \ + -google-default-arguments, \ + -google-explicit-constructor, \ + -google-runtime-int, \ + -google-runtime-operator, \ + -misc-incorrect-roundings, \ + -misc-macro-parentheses, \ + -misc-misplaced-widening-cast, \ + -misc-noexcept-move-constructor, \ + -misc-suspicious-string-compare, \ + -misc-unused-parameters, \ + -misc-unused-using-decls, \ + -performance-type-promotion-in-math-fn, \ + -performance-unnecessary-copy-initialization, \ + -performance-unnecessary-value-param, \ diff --git a/webrtc/base/Android.mk b/webrtc/base/Android.mk index 33ce5b61f0..069e22ba81 100644 --- a/webrtc/base/Android.mk +++ b/webrtc/base/Android.mk @@ -41,7 +41,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/common_audio/Android.mk b/webrtc/common_audio/Android.mk index 7e68367ff1..31f4b3068c 100644 --- a/webrtc/common_audio/Android.mk +++ b/webrtc/common_audio/Android.mk @@ -47,7 +47,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/common_audio/resampler/Android.mk b/webrtc/common_audio/resampler/Android.mk index 1aa4dd2ae4..5ddef2d2a5 100644 --- a/webrtc/common_audio/resampler/Android.mk +++ b/webrtc/common_audio/resampler/Android.mk @@ -37,7 +37,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/common_audio/signal_processing/Android.mk b/webrtc/common_audio/signal_processing/Android.mk index 5b2a41afd2..97319c6672 100644 --- a/webrtc/common_audio/signal_processing/Android.mk +++ b/webrtc/common_audio/signal_processing/Android.mk @@ -58,7 +58,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/common_audio/vad/Android.mk b/webrtc/common_audio/vad/Android.mk index f310cd4a7f..2b328deeb7 100644 --- a/webrtc/common_audio/vad/Android.mk +++ b/webrtc/common_audio/vad/Android.mk @@ -35,7 +35,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/Android.mk b/webrtc/modules/audio_coding/codecs/isac/fix/source/Android.mk index c409af2fff..7fdc534334 100644 --- a/webrtc/modules/audio_coding/codecs/isac/fix/source/Android.mk +++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/Android.mk @@ -75,7 +75,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/../interface \ diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/test/Android.mk b/webrtc/modules/audio_coding/codecs/isac/fix/test/Android.mk index 835c318149..d6a03a02ff 100644 --- a/webrtc/modules/audio_coding/codecs/isac/fix/test/Android.mk +++ b/webrtc/modules/audio_coding/codecs/isac/fix/test/Android.mk @@ -27,7 +27,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/../include \ diff --git a/webrtc/modules/audio_coding/codecs/isac/main/source/Android.mk b/webrtc/modules/audio_coding/codecs/isac/main/source/Android.mk index e9bfbbbb41..f1d30742e2 100644 --- a/webrtc/modules/audio_coding/codecs/isac/main/source/Android.mk +++ b/webrtc/modules/audio_coding/codecs/isac/main/source/Android.mk @@ -58,7 +58,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/../include \ diff --git a/webrtc/modules/audio_processing/Android.mk b/webrtc/modules/audio_processing/Android.mk index e768471105..4ed43eb0dc 100644 --- a/webrtc/modules/audio_processing/Android.mk +++ b/webrtc/modules/audio_processing/Android.mk @@ -49,7 +49,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ @@ -102,7 +103,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ @@ -165,7 +167,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_processing/aec/Android.mk b/webrtc/modules/audio_processing/aec/Android.mk index dbc5ed16c8..39b2df47f1 100644 --- a/webrtc/modules/audio_processing/aec/Android.mk +++ b/webrtc/modules/audio_processing/aec/Android.mk @@ -39,7 +39,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_processing/aecm/Android.mk b/webrtc/modules/audio_processing/aecm/Android.mk index 6f4ac2e793..b327bb33d2 100644 --- a/webrtc/modules/audio_processing/aecm/Android.mk +++ b/webrtc/modules/audio_processing/aecm/Android.mk @@ -37,7 +37,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_processing/agc/Android.mk b/webrtc/modules/audio_processing/agc/Android.mk index ef75e868b5..a9f745619e 100644 --- a/webrtc/modules/audio_processing/agc/Android.mk +++ b/webrtc/modules/audio_processing/agc/Android.mk @@ -39,7 +39,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_processing/beamformer/Android.mk b/webrtc/modules/audio_processing/beamformer/Android.mk index 4edce26992..e900a54e9d 100644 --- a/webrtc/modules/audio_processing/beamformer/Android.mk +++ b/webrtc/modules/audio_processing/beamformer/Android.mk @@ -34,7 +34,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/modules/audio_processing/intelligibility/Android.mk b/webrtc/modules/audio_processing/intelligibility/Android.mk index 5328c898fe..265e580aeb 100644 --- a/webrtc/modules/audio_processing/intelligibility/Android.mk +++ b/webrtc/modules/audio_processing/intelligibility/Android.mk @@ -33,7 +33,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/modules/audio_processing/ns/Android.mk b/webrtc/modules/audio_processing/ns/Android.mk index 6370f4b648..773a7cf214 100644 --- a/webrtc/modules/audio_processing/ns/Android.mk +++ b/webrtc/modules/audio_processing/ns/Android.mk @@ -39,7 +39,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/include \ diff --git a/webrtc/modules/audio_processing/transient/Android.mk b/webrtc/modules/audio_processing/transient/Android.mk index d35fb2ac16..c027009e0c 100644 --- a/webrtc/modules/audio_processing/transient/Android.mk +++ b/webrtc/modules/audio_processing/transient/Android.mk @@ -36,7 +36,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/modules/audio_processing/utility/Android.mk b/webrtc/modules/audio_processing/utility/Android.mk index ac76b9510e..9d9974db80 100644 --- a/webrtc/modules/audio_processing/utility/Android.mk +++ b/webrtc/modules/audio_processing/utility/Android.mk @@ -32,7 +32,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/modules/audio_processing/vad/Android.mk b/webrtc/modules/audio_processing/vad/Android.mk index d3e13288f6..6ac938ad1b 100644 --- a/webrtc/modules/audio_processing/vad/Android.mk +++ b/webrtc/modules/audio_processing/vad/Android.mk @@ -39,7 +39,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) # Include paths placed before CFLAGS/CPPFLAGS LOCAL_C_INCLUDES := \ diff --git a/webrtc/system_wrappers/source/Android.mk b/webrtc/system_wrappers/source/Android.mk index c80861124f..93ee0a6b49 100644 --- a/webrtc/system_wrappers/source/Android.mk +++ b/webrtc/system_wrappers/source/Android.mk @@ -48,7 +48,8 @@ LOCAL_CFLAGS_arm64 := $(MY_WEBRTC_COMMON_DEFS_arm64) LOCAL_CFLAGS_x86_64 := $(MY_WEBRTC_COMMON_DEFS_x86_64) LOCAL_CFLAGS_mips64 := $(MY_WEBRTC_COMMON_DEFS_mips64) -LOCAL_CFLAGS += -Wno-unused-parameter +LOCAL_CFLAGS += $(MY_WEBRTC_COMMON_CFLAGS_WARNINGS) +LOCAL_TIDY_CHECKS := $(MY_WEBRTC_COMMON_TIDY_CHECKS) LOCAL_C_INCLUDES := \ $(LOCAL_PATH)/android \ |