aboutsummaryrefslogtreecommitdiff
path: root/BUILD.gn
diff options
context:
space:
mode:
authorMirko Bonadei <mbonadei@webrtc.org>2019-10-25 17:54:17 +0000
committerCommit Bot <commit-bot@chromium.org>2019-10-25 17:54:32 +0000
commit91e3ebe46843a507461cdf457d284a02118eeb4e (patch)
tree765acc84e91094114d121c3492a8f75e62363d9b /BUILD.gn
parent29db239fed94bbe40dfddefa9f02409b951efc18 (diff)
downloadwebrtc-91e3ebe46843a507461cdf457d284a02118eeb4e.tar.gz
Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit 29db239fed94bbe40dfddefa9f02409b951efc18. Reason for revert: The test is on its way on https://chromium-review.googlesource.com/c/chromium/src/+/1874722. Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I6a184290f3f1a60c1ed6cbc86aafe3e7df248ce1 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158327 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29618} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ie3bac3393d6ce0f147f3d79d08d20cc9798b464a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/158328 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29619}
Diffstat (limited to 'BUILD.gn')
-rw-r--r--BUILD.gn2
1 files changed, 1 insertions, 1 deletions
diff --git a/BUILD.gn b/BUILD.gn
index 7f0635e737..5cef1303b2 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -111,7 +111,7 @@ config("common_inherited_config") {
cflags = []
ldflags = []
- if (rtc_enable_symbol_export || is_component_build) {
+ if (rtc_enable_symbol_export) {
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
}