diff options
author | Mirko Bonadei <mbonadei@webrtc.org> | 2019-11-07 12:54:55 +0000 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-11-07 12:55:10 +0000 |
commit | 1cd6fbc2a43e9986c2be2e3d93d63c98ef9193db (patch) | |
tree | 222fc069c7482f884f61959d75df06780a11963e /BUILD.gn | |
parent | 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1 (diff) | |
download | webrtc-1cd6fbc2a43e9986c2be2e3d93d63c98ef9193db.tar.gz |
Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
This reverts commit 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1.
Reason for revert: This CL was just needed in order to
have a WebRTC commit to pin in Chromium to test the
component build (this CL enables symbol exports).
Original change's description:
> Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
>
> This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed
>
> I will revert this reland as soon as it lands because I just need
> to have a WebRTC commit to pin in Chromium in order to test the
> component build (this CL enables symbol exports).
>
> Original change's description:
> > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.
> >
> > In order to land the component build support in Chromium, it is
> > easier to turn on symbols export every time that is_component_build=true
> > instead of setting rtc_enable_symbol_export=is_component_build in
> > Chromium (since is_component_build is not available in .gn).
> >
> > rtc_enable_symbol_export is still kept in the mix in order to turn
> > on symbol exports in any case a shared library will be added to the
> > WebRTC build.
> >
> > Bug: webrtc:9419
> > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#29540}
>
> TBR: kwiberg@webrtc.org
> No-Try: True
> Bug: webrtc:9419
> Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29723}
TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
Change-Id: I2922161bd97ef209d8cd7ce219eac0080fd69aa8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9419
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159027
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29724}
Diffstat (limited to 'BUILD.gn')
-rw-r--r-- | BUILD.gn | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -111,7 +111,7 @@ config("common_inherited_config") { cflags = [] ldflags = [] - if (rtc_enable_symbol_export || is_component_build) { + if (rtc_enable_symbol_export) { defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] } |