aboutsummaryrefslogtreecommitdiff
path: root/BUILD.gn
diff options
context:
space:
mode:
authorMirko Bonadei <mbonadei@webrtc.org>2019-10-15 21:25:07 +0200
committerCommit Bot <commit-bot@chromium.org>2019-11-12 08:15:39 +0000
commitd1f40f39dc2167c7b9873be35e699c3954197060 (patch)
treeee5ab2201add88e40c4fa34479b4f0636705901c /BUILD.gn
parent8cbb33c0d04b19f3fb02bf5b6281080f698d9ad1 (diff)
downloadwebrtc-d1f40f39dc2167c7b9873be35e699c3954197060.tar.gz
Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: Ie3ab8e46c2621dd72dd1dd4ca3d861f5e8411984 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159681 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29763}
Diffstat (limited to 'BUILD.gn')
-rw-r--r--BUILD.gn2
1 files changed, 1 insertions, 1 deletions
diff --git a/BUILD.gn b/BUILD.gn
index 73569c5a09..98ff6a039d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -111,7 +111,7 @@ config("common_inherited_config") {
cflags = []
ldflags = []
- if (rtc_enable_symbol_export) {
+ if (rtc_enable_symbol_export || is_component_build) {
defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ]
}