diff options
| author | Mirko Bonadei <mbonadei@webrtc.org> | 2019-03-01 10:32:56 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-03-01 10:18:17 +0000 |
| commit | fc52b912a3324c4ff228aa5c3cd969458714de3a (patch) | |
| tree | 72413f2861d04206c459fd1005bde7478b8501dd /BUILD.gn | |
| parent | 3830d9b1433d86003045b884203ab0cf8692b492 (diff) | |
| download | webrtc-fc52b912a3324c4ff228aa5c3cd969458714de3a.tar.gz | |
Implicitly suppress //build/config/clang:find_bad_constructs.
Since there is no way to enable/disable these diagnostics at runtime,
this CL moves the suppression into the rtc_* templates in order to
remove the need to explicitly add the snippet of code needed to
suppress it (currently copy/pasted in 144 locations).
The diagnostic that causes the most problems is the one about "complex
class/struct explicit ctor/dtor" [1] because WebRTC doesn't find
it useful enough.
Other diagnostics are good (for example the one that warns about
using "virtual" instead of "override", but that will be covered by
this clang-tidy check [2]) while others are Chromium related so
they have never triggered.
[1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a
[2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html
Bug: webrtc:163
Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34
Reviewed-on: https://webrtc-review.googlesource.com/c/125088
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26918}
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 9 |
1 files changed, 0 insertions, 9 deletions
@@ -454,11 +454,6 @@ rtc_source_set("webrtc_common") { "rtc_base:checks", "//third_party/abseil-cpp/absl/strings", ] - - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } } if (use_libfuzzer || use_drfuzz || use_afl) { @@ -564,10 +559,6 @@ if (rtc_include_tests) { "video:video_tests", ] data = video_engine_tests_resources - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } if (is_android) { deps += [ "//testing/android/native_test:native_test_native_code" ] shard_timeout = 900 |