diff options
| author | henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2014-02-19 23:18:19 +0000 |
|---|---|---|
| committer | henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2014-02-19 23:18:19 +0000 |
| commit | 056176b96248fa926e0e1d1249c4f31a3246a1b1 (patch) | |
| tree | 59905c956112c51179e2a24fb5bf63287ecbd4ff /PRESUBMIT.py | |
| parent | 78f0db4710c7cf00830646c75d8782ab426d514c (diff) | |
| download | webrtc-056176b96248fa926e0e1d1249c4f31a3246a1b1.tar.gz | |
Presubmit script that prohibits cls to both trunk/webrtc and trunk/talk.
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7999006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5582 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index b029780507..fb70d92047 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -93,6 +93,23 @@ def _CheckApprovedFilesLintClean(input_api, output_api, return result +def _CheckTalkOrWebrtcOnly(input_api, output_api): + base_folders = set(["webrtc", "talk"]) + base_folders_in_cl = set() + + for f in input_api.AffectedFiles(): + full_path = f.LocalPath() + base_folders_in_cl.add(full_path[:full_path.find('/')]) + + results = [] + if base_folders.issubset(base_folders_in_cl): + error_type = output_api.PresubmitError + results.append(error_type( + 'It is not allowed to check in files to ' + ', '.join(base_folders) + + ' in the same cl', + [])) + return results + def _CommonChecks(input_api, output_api): """Checks common to both upload and commit.""" # TODO(kjellander): Use presubmit_canned_checks.PanProjectChecks too. @@ -133,6 +150,7 @@ def _CommonChecks(input_api, output_api): results.extend(_CheckApprovedFilesLintClean(input_api, output_api)) results.extend(_CheckNoIOStreamInHeaders(input_api, output_api)) results.extend(_CheckNoFRIEND_TEST(input_api, output_api)) + results.extend(_CheckTalkOrWebrtcOnly(input_api, output_api)) return results def CheckChangeOnUpload(input_api, output_api): |