diff options
author | Mirko Bonadei <mbonadei@webrtc.org> | 2019-10-17 21:32:04 +0200 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-10-17 21:17:18 +0000 |
commit | 86d053c2db6ed25e4854c307d563999298dda2e5 (patch) | |
tree | 170909a876f1443e0cec6defac0ac5ea5f4cbc56 /api/audio_codecs/g711 | |
parent | e8b962bd3c9775b2859f908004263dbc8840629a (diff) | |
download | webrtc-86d053c2db6ed25e4854c307d563999298dda2e5.tar.gz |
Use source_sets in component builds and static_library in release builds.
Static libraries don't guarantee that an exported symbol gets linked
into a shared library (and in order to support Chromium's component
build mode, WebRTC needs to be linked as a shared library).
Source sets always pass all the object files to the linker.
On the flip side, source_sets link more object files in release builds
and to avoid this, this CL introduces a the GN template "rtc_library" that
expands to static_library during release builds and to source_set during
component builds.
See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set
Bug: webrtc:9419
Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29525}
Diffstat (limited to 'api/audio_codecs/g711')
-rw-r--r-- | api/audio_codecs/g711/BUILD.gn | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/api/audio_codecs/g711/BUILD.gn b/api/audio_codecs/g711/BUILD.gn index ebcc249591..ba0586b901 100644 --- a/api/audio_codecs/g711/BUILD.gn +++ b/api/audio_codecs/g711/BUILD.gn @@ -12,7 +12,7 @@ if (is_android) { import("//build/config/android/rules.gni") } -rtc_static_library("audio_encoder_g711") { +rtc_library("audio_encoder_g711") { visibility = [ "*" ] poisonous = [ "audio_codecs" ] sources = [ @@ -30,7 +30,7 @@ rtc_static_library("audio_encoder_g711") { ] } -rtc_static_library("audio_decoder_g711") { +rtc_library("audio_decoder_g711") { visibility = [ "*" ] poisonous = [ "audio_codecs" ] sources = [ |