diff options
author | Danil Chapovalov <danilchap@webrtc.org> | 2018-06-21 13:32:56 +0200 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2018-06-21 12:50:03 +0000 |
commit | 0bc58cf8769643d7ad6f24d106754336c7d29385 (patch) | |
tree | c735ccc1082636510b643f38cad5bc1ab4d838b2 /api/audio_codecs | |
parent | 1ff41eb784ffe919982124fae0c3f294467aafc8 (diff) | |
download | webrtc-0bc58cf8769643d7ad6f24d106754336c7d29385.tar.gz |
Replace rtc::Optional with absl::optional in api
This is a no-op change because rtc::Optional is an alias to absl::optional
This CL generated by running script with parameter 'api'
Then undo changes to optional target itself and optional_unittests
find $@ -type f \( -name \*.h -o -name \*.cc \) \
-exec sed -i 's|rtc::Optional|absl::optional|g' {} \+ \
-exec sed -i 's|rtc::nullopt|absl::nullopt|g' {} \+ \
-exec sed -i 's|#include "api/optional.h"|#include "absl/types/optional.h"|' {} \+
find $@ -type f -name BUILD.gn \
-exec sed -r -i 's|"[\./api]*:optional"|"//third_party/abseil-cpp/absl/types:optional"|' {} \+;
git cl format
Bug: webrtc:9078
Change-Id: I44093da213369d6a502e33792c694f620f53b779
Reviewed-on: https://webrtc-review.googlesource.com/84621
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23707}
Diffstat (limited to 'api/audio_codecs')
49 files changed, 234 insertions, 228 deletions
diff --git a/api/audio_codecs/BUILD.gn b/api/audio_codecs/BUILD.gn index 3206a74caa..7895a937cd 100644 --- a/api/audio_codecs/BUILD.gn +++ b/api/audio_codecs/BUILD.gn @@ -30,13 +30,13 @@ rtc_source_set("audio_codecs_api") { ] deps = [ "..:array_view", - "..:optional", "../..:webrtc_common", "../../:typedefs", "../../rtc_base:checks", "../../rtc_base:deprecation", "../../rtc_base:rtc_base_approved", "../../rtc_base:sanitizer", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/L16/BUILD.gn b/api/audio_codecs/L16/BUILD.gn index 01554aa512..043d659bd5 100644 --- a/api/audio_codecs/L16/BUILD.gn +++ b/api/audio_codecs/L16/BUILD.gn @@ -21,10 +21,10 @@ rtc_static_library("audio_encoder_L16") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:pcm16b", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -37,9 +37,9 @@ rtc_static_library("audio_decoder_L16") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:pcm16b", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/L16/audio_decoder_L16.cc b/api/audio_codecs/L16/audio_decoder_L16.cc index 7c6a9ee87b..a17dc583cb 100644 --- a/api/audio_codecs/L16/audio_decoder_L16.cc +++ b/api/audio_codecs/L16/audio_decoder_L16.cc @@ -18,14 +18,14 @@ namespace webrtc { -rtc::Optional<AudioDecoderL16::Config> AudioDecoderL16::SdpToConfig( +absl::optional<AudioDecoderL16::Config> AudioDecoderL16::SdpToConfig( const SdpAudioFormat& format) { Config config; config.sample_rate_hz = format.clockrate_hz; config.num_channels = rtc::checked_cast<int>(format.num_channels); return STR_CASE_CMP(format.name.c_str(), "L16") == 0 && config.IsOk() - ? rtc::Optional<Config>(config) - : rtc::nullopt; + ? absl::optional<Config>(config) + : absl::nullopt; } void AudioDecoderL16::AppendSupportedDecoders( @@ -35,7 +35,7 @@ void AudioDecoderL16::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderL16::MakeAudioDecoder( const Config& config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { return config.IsOk() ? rtc::MakeUnique<AudioDecoderPcm16B>( config.sample_rate_hz, config.num_channels) : nullptr; diff --git a/api/audio_codecs/L16/audio_decoder_L16.h b/api/audio_codecs/L16/audio_decoder_L16.h index deef909201..184ec24ed9 100644 --- a/api/audio_codecs/L16/audio_decoder_L16.h +++ b/api/audio_codecs/L16/audio_decoder_L16.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -35,11 +35,11 @@ struct AudioDecoderL16 { int sample_rate_hz = 8000; int num_channels = 1; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const Config& config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/L16/audio_encoder_L16.cc b/api/audio_codecs/L16/audio_encoder_L16.cc index 5022993745..d80e6bf928 100644 --- a/api/audio_codecs/L16/audio_encoder_L16.cc +++ b/api/audio_codecs/L16/audio_encoder_L16.cc @@ -18,17 +18,17 @@ namespace webrtc { -rtc::Optional<AudioEncoderL16::Config> AudioEncoderL16::SdpToConfig( +absl::optional<AudioEncoderL16::Config> AudioEncoderL16::SdpToConfig( const SdpAudioFormat& format) { if (!rtc::IsValueInRangeForNumericType<int>(format.num_channels)) { - return rtc::nullopt; + return absl::nullopt; } Config config; config.sample_rate_hz = format.clockrate_hz; config.num_channels = rtc::dchecked_cast<int>(format.num_channels); return STR_CASE_CMP(format.name.c_str(), "L16") == 0 && config.IsOk() - ? rtc::Optional<Config>(config) - : rtc::nullopt; + ? absl::optional<Config>(config) + : absl::nullopt; } void AudioEncoderL16::AppendSupportedEncoders( @@ -47,7 +47,7 @@ AudioCodecInfo AudioEncoderL16::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderL16::MakeAudioEncoder( const AudioEncoderL16::Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); AudioEncoderPcm16B::Config c; c.sample_rate_hz = config.sample_rate_hz; diff --git a/api/audio_codecs/L16/audio_encoder_L16.h b/api/audio_codecs/L16/audio_encoder_L16.h index 08d7ef1eb8..340e3af47f 100644 --- a/api/audio_codecs/L16/audio_encoder_L16.h +++ b/api/audio_codecs/L16/audio_encoder_L16.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -37,13 +37,13 @@ struct AudioEncoderL16 { int num_channels = 1; int frame_size_ms = 10; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const Config& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/audio_decoder.cc b/api/audio_codecs/audio_decoder.cc index 4903fb63bf..00e45d960a 100644 --- a/api/audio_codecs/audio_decoder.cc +++ b/api/audio_codecs/audio_decoder.cc @@ -33,14 +33,14 @@ class OldStyleEncodedFrame final : public AudioDecoder::EncodedAudioFrame { return ret < 0 ? 0 : static_cast<size_t>(ret); } - rtc::Optional<DecodeResult> Decode( + absl::optional<DecodeResult> Decode( rtc::ArrayView<int16_t> decoded) const override { auto speech_type = AudioDecoder::kSpeech; const int ret = decoder_->Decode( payload_.data(), payload_.size(), decoder_->SampleRateHz(), decoded.size() * sizeof(int16_t), decoded.data(), &speech_type); - return ret < 0 ? rtc::nullopt - : rtc::Optional<DecodeResult>( + return ret < 0 ? absl::nullopt + : absl::optional<DecodeResult>( {static_cast<size_t>(ret), speech_type}); } diff --git a/api/audio_codecs/audio_decoder.h b/api/audio_codecs/audio_decoder.h index 021288fc2b..4852ad71e6 100644 --- a/api/audio_codecs/audio_decoder.h +++ b/api/audio_codecs/audio_decoder.h @@ -14,8 +14,8 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/array_view.h" -#include "api/optional.h" #include "rtc_base/buffer.h" #include "rtc_base/constructormagic.h" #include "typedefs.h" // NOLINT(build/include) @@ -53,11 +53,11 @@ class AudioDecoder { // Decodes this frame of audio and writes the result in |decoded|. // |decoded| must be large enough to store as many samples as indicated by a - // call to Duration() . On success, returns an rtc::Optional containing the + // call to Duration() . On success, returns an absl::optional containing the // total number of samples across all channels, as well as whether the // decoder produced comfort noise or speech. On failure, returns an empty - // rtc::Optional. Decode may be called at most once per frame object. - virtual rtc::Optional<DecodeResult> Decode( + // absl::optional. Decode may be called at most once per frame object. + virtual absl::optional<DecodeResult> Decode( rtc::ArrayView<int16_t> decoded) const = 0; }; diff --git a/api/audio_codecs/audio_decoder_factory.h b/api/audio_codecs/audio_decoder_factory.h index fb1c965767..90f93f0cd5 100644 --- a/api/audio_codecs/audio_decoder_factory.h +++ b/api/audio_codecs/audio_decoder_factory.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" #include "rtc_base/refcount.h" namespace webrtc { @@ -41,7 +41,7 @@ class AudioDecoderFactory : public rtc::RefCountInterface { // work. virtual std::unique_ptr<AudioDecoder> MakeAudioDecoder( const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) = 0; + absl::optional<AudioCodecPairId> codec_pair_id) = 0; }; } // namespace webrtc diff --git a/api/audio_codecs/audio_decoder_factory_template.h b/api/audio_codecs/audio_decoder_factory_template.h index 4adac213d3..cdbe8bde7a 100644 --- a/api/audio_codecs/audio_decoder_factory_template.h +++ b/api/audio_codecs/audio_decoder_factory_template.h @@ -32,7 +32,7 @@ struct Helper<> { static bool IsSupportedDecoder(const SdpAudioFormat& format) { return false; } static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) { + absl::optional<AudioCodecPairId> codec_pair_id) { return nullptr; } }; @@ -48,14 +48,14 @@ struct Helper<T, Ts...> { static bool IsSupportedDecoder(const SdpAudioFormat& format) { auto opt_config = T::SdpToConfig(format); static_assert(std::is_same<decltype(opt_config), - rtc::Optional<typename T::Config>>::value, + absl::optional<typename T::Config>>::value, "T::SdpToConfig() must return a value of type " - "rtc::Optional<T::Config>"); + "absl::optional<T::Config>"); return opt_config ? true : Helper<Ts...>::IsSupportedDecoder(format); } static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) { + absl::optional<AudioCodecPairId> codec_pair_id) { auto opt_config = T::SdpToConfig(format); return opt_config ? T::MakeAudioDecoder(*opt_config, codec_pair_id) : Helper<Ts...>::MakeAudioDecoder(format, codec_pair_id); @@ -77,7 +77,7 @@ class AudioDecoderFactoryT : public AudioDecoderFactory { std::unique_ptr<AudioDecoder> MakeAudioDecoder( const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) override { + absl::optional<AudioCodecPairId> codec_pair_id) override { return Helper<Ts...>::MakeAudioDecoder(format, codec_pair_id); } }; @@ -92,7 +92,7 @@ class AudioDecoderFactoryT : public AudioDecoderFactory { // // Converts |audio_format| to a ConfigType instance. Returns an empty // // optional if |audio_format| doesn't correctly specify an decoder of our // // type. -// rtc::Optional<ConfigType> SdpToConfig(const SdpAudioFormat& audio_format); +// absl::optional<ConfigType> SdpToConfig(const SdpAudioFormat& audio_format); // // // Appends zero or more AudioCodecSpecs to the list that will be returned // // by AudioDecoderFactory::GetSupportedDecoders(). @@ -102,7 +102,7 @@ class AudioDecoderFactoryT : public AudioDecoderFactory { // // AudioDecoderFactory::MakeAudioDecoder(). // std::unique_ptr<AudioDecoder> MakeAudioDecoder( // const ConfigType& config, -// rtc::Optional<AudioCodecPairId> codec_pair_id); +// absl::optional<AudioCodecPairId> codec_pair_id); // // ConfigType should be a type that encapsulates all the settings needed to // create an AudioDecoder. T::Config (where T is the decoder struct) should diff --git a/api/audio_codecs/audio_encoder.cc b/api/audio_codecs/audio_encoder.cc index 4f9b9f0bb2..595c11131e 100644 --- a/api/audio_codecs/audio_encoder.cc +++ b/api/audio_codecs/audio_encoder.cc @@ -85,12 +85,12 @@ void AudioEncoder::OnReceivedUplinkRecoverablePacketLossFraction( float uplink_recoverable_packet_loss_fraction) {} void AudioEncoder::OnReceivedTargetAudioBitrate(int target_audio_bitrate_bps) { - OnReceivedUplinkBandwidth(target_audio_bitrate_bps, rtc::nullopt); + OnReceivedUplinkBandwidth(target_audio_bitrate_bps, absl::nullopt); } void AudioEncoder::OnReceivedUplinkBandwidth( int target_audio_bitrate_bps, - rtc::Optional<int64_t> bwe_period_ms) {} + absl::optional<int64_t> bwe_period_ms) {} void AudioEncoder::OnReceivedRtt(int rtt_ms) {} diff --git a/api/audio_codecs/audio_encoder.h b/api/audio_codecs/audio_encoder.h index d277a194b5..25094013c3 100644 --- a/api/audio_codecs/audio_encoder.h +++ b/api/audio_codecs/audio_encoder.h @@ -16,8 +16,8 @@ #include <string> #include <vector> +#include "absl/types/optional.h" #include "api/array_view.h" -#include "api/optional.h" #include "rtc_base/buffer.h" #include "rtc_base/deprecation.h" #include "typedefs.h" // NOLINT(build/include) @@ -34,30 +34,30 @@ struct ANAStats { // Number of actions taken by the ANA bitrate controller since the start of // the call. If this value is not set, it indicates that the bitrate // controller is disabled. - rtc::Optional<uint32_t> bitrate_action_counter; + absl::optional<uint32_t> bitrate_action_counter; // Number of actions taken by the ANA channel controller since the start of // the call. If this value is not set, it indicates that the channel // controller is disabled. - rtc::Optional<uint32_t> channel_action_counter; + absl::optional<uint32_t> channel_action_counter; // Number of actions taken by the ANA DTX controller since the start of the // call. If this value is not set, it indicates that the DTX controller is // disabled. - rtc::Optional<uint32_t> dtx_action_counter; + absl::optional<uint32_t> dtx_action_counter; // Number of actions taken by the ANA FEC controller since the start of the // call. If this value is not set, it indicates that the FEC controller is // disabled. - rtc::Optional<uint32_t> fec_action_counter; + absl::optional<uint32_t> fec_action_counter; // Number of times the ANA frame length controller decided to increase the // frame length since the start of the call. If this value is not set, it // indicates that the frame length controller is disabled. - rtc::Optional<uint32_t> frame_length_increase_counter; + absl::optional<uint32_t> frame_length_increase_counter; // Number of times the ANA frame length controller decided to decrease the // frame length since the start of the call. If this value is not set, it // indicates that the frame length controller is disabled. - rtc::Optional<uint32_t> frame_length_decrease_counter; + absl::optional<uint32_t> frame_length_decrease_counter; // The uplink packet loss fractions as set by the ANA FEC controller. If this // value is not set, it indicates that the ANA FEC controller is not active. - rtc::Optional<float> uplink_packet_loss_fraction; + absl::optional<float> uplink_packet_loss_fraction; }; // This is the interface class for encoders in AudioCoding module. Each codec @@ -221,7 +221,7 @@ class AudioEncoder { // Provides target audio bitrate and corresponding probing interval of // the bandwidth estimator to this encoder to allow it to adapt. virtual void OnReceivedUplinkBandwidth(int target_audio_bitrate_bps, - rtc::Optional<int64_t> bwe_period_ms); + absl::optional<int64_t> bwe_period_ms); // Provides RTT to this encoder to allow it to adapt. virtual void OnReceivedRtt(int rtt_ms); diff --git a/api/audio_codecs/audio_encoder_factory.h b/api/audio_codecs/audio_encoder_factory.h index 782595307d..fb4e23ffe7 100644 --- a/api/audio_codecs/audio_encoder_factory.h +++ b/api/audio_codecs/audio_encoder_factory.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" #include "rtc_base/refcount.h" namespace webrtc { @@ -32,7 +32,7 @@ class AudioEncoderFactory : public rtc::RefCountInterface { // Returns information about how this format would be encoded, provided it's // supported. More format and format variations may be supported than those // returned by GetSupportedEncoders(). - virtual rtc::Optional<AudioCodecInfo> QueryAudioEncoder( + virtual absl::optional<AudioCodecInfo> QueryAudioEncoder( const SdpAudioFormat& format) = 0; // Creates an AudioEncoder for the specified format. The encoder will tags @@ -50,7 +50,7 @@ class AudioEncoderFactory : public rtc::RefCountInterface { virtual std::unique_ptr<AudioEncoder> MakeAudioEncoder( int payload_type, const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) = 0; + absl::optional<AudioCodecPairId> codec_pair_id) = 0; }; } // namespace webrtc diff --git a/api/audio_codecs/audio_encoder_factory_template.h b/api/audio_codecs/audio_encoder_factory_template.h index f76677da71..376b39e4c6 100644 --- a/api/audio_codecs/audio_encoder_factory_template.h +++ b/api/audio_codecs/audio_encoder_factory_template.h @@ -29,14 +29,14 @@ struct Helper; template <> struct Helper<> { static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs) {} - static rtc::Optional<AudioCodecInfo> QueryAudioEncoder( + static absl::optional<AudioCodecInfo> QueryAudioEncoder( const SdpAudioFormat& format) { - return rtc::nullopt; + return absl::nullopt; } static std::unique_ptr<AudioEncoder> MakeAudioEncoder( int payload_type, const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) { + absl::optional<AudioCodecPairId> codec_pair_id) { return nullptr; } }; @@ -49,21 +49,21 @@ struct Helper<T, Ts...> { T::AppendSupportedEncoders(specs); Helper<Ts...>::AppendSupportedEncoders(specs); } - static rtc::Optional<AudioCodecInfo> QueryAudioEncoder( + static absl::optional<AudioCodecInfo> QueryAudioEncoder( const SdpAudioFormat& format) { auto opt_config = T::SdpToConfig(format); static_assert(std::is_same<decltype(opt_config), - rtc::Optional<typename T::Config>>::value, + absl::optional<typename T::Config>>::value, "T::SdpToConfig() must return a value of type " - "rtc::Optional<T::Config>"); - return opt_config ? rtc::Optional<AudioCodecInfo>( + "absl::optional<T::Config>"); + return opt_config ? absl::optional<AudioCodecInfo>( T::QueryAudioEncoder(*opt_config)) : Helper<Ts...>::QueryAudioEncoder(format); } static std::unique_ptr<AudioEncoder> MakeAudioEncoder( int payload_type, const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) { + absl::optional<AudioCodecPairId> codec_pair_id) { auto opt_config = T::SdpToConfig(format); if (opt_config) { return T::MakeAudioEncoder(*opt_config, payload_type, codec_pair_id); @@ -83,7 +83,7 @@ class AudioEncoderFactoryT : public AudioEncoderFactory { return specs; } - rtc::Optional<AudioCodecInfo> QueryAudioEncoder( + absl::optional<AudioCodecInfo> QueryAudioEncoder( const SdpAudioFormat& format) override { return Helper<Ts...>::QueryAudioEncoder(format); } @@ -91,7 +91,7 @@ class AudioEncoderFactoryT : public AudioEncoderFactory { std::unique_ptr<AudioEncoder> MakeAudioEncoder( int payload_type, const SdpAudioFormat& format, - rtc::Optional<AudioCodecPairId> codec_pair_id) override { + absl::optional<AudioCodecPairId> codec_pair_id) override { return Helper<Ts...>::MakeAudioEncoder(payload_type, format, codec_pair_id); } }; @@ -106,7 +106,7 @@ class AudioEncoderFactoryT : public AudioEncoderFactory { // // Converts |audio_format| to a ConfigType instance. Returns an empty // // optional if |audio_format| doesn't correctly specify an encoder of our // // type. -// rtc::Optional<ConfigType> SdpToConfig(const SdpAudioFormat& audio_format); +// absl::optional<ConfigType> SdpToConfig(const SdpAudioFormat& audio_format); // // // Appends zero or more AudioCodecSpecs to the list that will be returned // // by AudioEncoderFactory::GetSupportedEncoders(). @@ -121,7 +121,7 @@ class AudioEncoderFactoryT : public AudioEncoderFactory { // std::unique_ptr<AudioDecoder> MakeAudioEncoder( // const ConfigType& config, // int payload_type, -// rtc::Optional<AudioCodecPairId> codec_pair_id); +// absl::optional<AudioCodecPairId> codec_pair_id); // // ConfigType should be a type that encapsulates all the settings needed to // create an AudioEncoder. T::Config (where T is the encoder struct) should diff --git a/api/audio_codecs/audio_format.h b/api/audio_codecs/audio_format.h index 553ab8fb25..d132067d09 100644 --- a/api/audio_codecs/audio_format.h +++ b/api/audio_codecs/audio_format.h @@ -15,7 +15,7 @@ #include <string> #include <utility> -#include "api/optional.h" +#include "absl/types/optional.h" #include "rtc_base/checks.h" namespace webrtc { diff --git a/api/audio_codecs/builtin_audio_decoder_factory.cc b/api/audio_codecs/builtin_audio_decoder_factory.cc index c3e5d50b97..e3ca1b0e06 100644 --- a/api/audio_codecs/builtin_audio_decoder_factory.cc +++ b/api/audio_codecs/builtin_audio_decoder_factory.cc @@ -33,7 +33,8 @@ namespace { template <typename T> struct NotAdvertised { using Config = typename T::Config; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format) { + static absl::optional<Config> SdpToConfig( + const SdpAudioFormat& audio_format) { return T::SdpToConfig(audio_format); } static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs) { @@ -41,7 +42,7 @@ struct NotAdvertised { } static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const Config& config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt) { + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt) { return T::MakeAudioDecoder(config, codec_pair_id); } }; diff --git a/api/audio_codecs/builtin_audio_encoder_factory.cc b/api/audio_codecs/builtin_audio_encoder_factory.cc index 5395404361..c0caff42e2 100644 --- a/api/audio_codecs/builtin_audio_encoder_factory.cc +++ b/api/audio_codecs/builtin_audio_encoder_factory.cc @@ -33,7 +33,8 @@ namespace { template <typename T> struct NotAdvertised { using Config = typename T::Config; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format) { + static absl::optional<Config> SdpToConfig( + const SdpAudioFormat& audio_format) { return T::SdpToConfig(audio_format); } static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs) { @@ -45,7 +46,7 @@ struct NotAdvertised { static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt) { + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt) { return T::MakeAudioEncoder(config, payload_type, codec_pair_id); } }; diff --git a/api/audio_codecs/g711/BUILD.gn b/api/audio_codecs/g711/BUILD.gn index 7026abb761..52e1ee9cf3 100644 --- a/api/audio_codecs/g711/BUILD.gn +++ b/api/audio_codecs/g711/BUILD.gn @@ -21,11 +21,11 @@ rtc_static_library("audio_encoder_g711") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:g711", "../../../rtc_base:rtc_base_approved", "../../../rtc_base:safe_minmax", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -38,9 +38,9 @@ rtc_static_library("audio_decoder_g711") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:g711", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/g711/audio_decoder_g711.cc b/api/audio_codecs/g711/audio_decoder_g711.cc index c715e805e5..e8afa60ae5 100644 --- a/api/audio_codecs/g711/audio_decoder_g711.cc +++ b/api/audio_codecs/g711/audio_decoder_g711.cc @@ -20,7 +20,7 @@ namespace webrtc { -rtc::Optional<AudioDecoderG711::Config> AudioDecoderG711::SdpToConfig( +absl::optional<AudioDecoderG711::Config> AudioDecoderG711::SdpToConfig( const SdpAudioFormat& format) { const bool is_pcmu = STR_CASE_CMP(format.name.c_str(), "PCMU") == 0; const bool is_pcma = STR_CASE_CMP(format.name.c_str(), "PCMA") == 0; @@ -32,7 +32,7 @@ rtc::Optional<AudioDecoderG711::Config> AudioDecoderG711::SdpToConfig( RTC_DCHECK(config.IsOk()); return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -45,7 +45,7 @@ void AudioDecoderG711::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderG711::MakeAudioDecoder( const Config& config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); switch (config.type) { case Config::Type::kPcmU: diff --git a/api/audio_codecs/g711/audio_decoder_g711.h b/api/audio_codecs/g711/audio_decoder_g711.h index 5085283f0e..8275a8c7a1 100644 --- a/api/audio_codecs/g711/audio_decoder_g711.h +++ b/api/audio_codecs/g711/audio_decoder_g711.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -34,11 +34,11 @@ struct AudioDecoderG711 { Type type; int num_channels; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const Config& config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/g711/audio_encoder_g711.cc b/api/audio_codecs/g711/audio_encoder_g711.cc index e5abc3395b..95595fa529 100644 --- a/api/audio_codecs/g711/audio_encoder_g711.cc +++ b/api/audio_codecs/g711/audio_encoder_g711.cc @@ -22,7 +22,7 @@ namespace webrtc { -rtc::Optional<AudioEncoderG711::Config> AudioEncoderG711::SdpToConfig( +absl::optional<AudioEncoderG711::Config> AudioEncoderG711::SdpToConfig( const SdpAudioFormat& format) { const bool is_pcmu = STR_CASE_CMP(format.name.c_str(), "PCMU") == 0; const bool is_pcma = STR_CASE_CMP(format.name.c_str(), "PCMA") == 0; @@ -42,7 +42,7 @@ rtc::Optional<AudioEncoderG711::Config> AudioEncoderG711::SdpToConfig( RTC_DCHECK(config.IsOk()); return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -62,7 +62,7 @@ AudioCodecInfo AudioEncoderG711::QueryAudioEncoder(const Config& config) { std::unique_ptr<AudioEncoder> AudioEncoderG711::MakeAudioEncoder( const Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); switch (config.type) { case Config::Type::kPcmU: { diff --git a/api/audio_codecs/g711/audio_encoder_g711.h b/api/audio_codecs/g711/audio_encoder_g711.h index 22a74b4727..6b6eb5fce0 100644 --- a/api/audio_codecs/g711/audio_encoder_g711.h +++ b/api/audio_codecs/g711/audio_encoder_g711.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -36,14 +36,14 @@ struct AudioEncoderG711 { int num_channels = 1; int frame_size_ms = 20; }; - static rtc::Optional<AudioEncoderG711::Config> SdpToConfig( + static absl::optional<AudioEncoderG711::Config> SdpToConfig( const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const Config& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/g722/BUILD.gn b/api/audio_codecs/g722/BUILD.gn index 7078aa403d..85a82744a0 100644 --- a/api/audio_codecs/g722/BUILD.gn +++ b/api/audio_codecs/g722/BUILD.gn @@ -29,11 +29,11 @@ rtc_static_library("audio_encoder_g722") { deps = [ ":audio_encoder_g722_config", "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:g722", "../../../rtc_base:rtc_base_approved", "../../../rtc_base:safe_minmax", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -46,9 +46,9 @@ rtc_static_library("audio_decoder_g722") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:g722", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/g722/audio_decoder_g722.cc b/api/audio_codecs/g722/audio_decoder_g722.cc index 6f72037b41..04a0a4cf9e 100644 --- a/api/audio_codecs/g722/audio_decoder_g722.cc +++ b/api/audio_codecs/g722/audio_decoder_g722.cc @@ -20,14 +20,14 @@ namespace webrtc { -rtc::Optional<AudioDecoderG722::Config> AudioDecoderG722::SdpToConfig( +absl::optional<AudioDecoderG722::Config> AudioDecoderG722::SdpToConfig( const SdpAudioFormat& format) { return STR_CASE_CMP(format.name.c_str(), "G722") == 0 && format.clockrate_hz == 8000 && (format.num_channels == 1 || format.num_channels == 2) - ? rtc::Optional<Config>( + ? absl::optional<Config>( Config{rtc::dchecked_cast<int>(format.num_channels)}) - : rtc::nullopt; + : absl::nullopt; } void AudioDecoderG722::AppendSupportedDecoders( @@ -37,7 +37,7 @@ void AudioDecoderG722::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderG722::MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { switch (config.num_channels) { case 1: return rtc::MakeUnique<AudioDecoderG722Impl>(); diff --git a/api/audio_codecs/g722/audio_decoder_g722.h b/api/audio_codecs/g722/audio_decoder_g722.h index 34235dcad9..b7bb0893f3 100644 --- a/api/audio_codecs/g722/audio_decoder_g722.h +++ b/api/audio_codecs/g722/audio_decoder_g722.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -30,11 +30,11 @@ struct AudioDecoderG722 { bool IsOk() const { return num_channels == 1 || num_channels == 2; } int num_channels; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/g722/audio_encoder_g722.cc b/api/audio_codecs/g722/audio_encoder_g722.cc index 04074b104c..d1f5258a96 100644 --- a/api/audio_codecs/g722/audio_encoder_g722.cc +++ b/api/audio_codecs/g722/audio_encoder_g722.cc @@ -22,11 +22,11 @@ namespace webrtc { -rtc::Optional<AudioEncoderG722Config> AudioEncoderG722::SdpToConfig( +absl::optional<AudioEncoderG722Config> AudioEncoderG722::SdpToConfig( const SdpAudioFormat& format) { if (STR_CASE_CMP(format.name.c_str(), "g722") != 0 || format.clockrate_hz != 8000) { - return rtc::nullopt; + return absl::nullopt; } AudioEncoderG722Config config; @@ -39,8 +39,8 @@ rtc::Optional<AudioEncoderG722Config> AudioEncoderG722::SdpToConfig( config.frame_size_ms = rtc::SafeClamp<int>(whole_packets * 10, 10, 60); } } - return config.IsOk() ? rtc::Optional<AudioEncoderG722Config>(config) - : rtc::nullopt; + return config.IsOk() ? absl::optional<AudioEncoderG722Config>(config) + : absl::nullopt; } void AudioEncoderG722::AppendSupportedEncoders( @@ -60,7 +60,7 @@ AudioCodecInfo AudioEncoderG722::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderG722::MakeAudioEncoder( const AudioEncoderG722Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); return rtc::MakeUnique<AudioEncoderG722Impl>(config, payload_type); } diff --git a/api/audio_codecs/g722/audio_encoder_g722.h b/api/audio_codecs/g722/audio_encoder_g722.h index 08cd304c8a..b97fe1b147 100644 --- a/api/audio_codecs/g722/audio_encoder_g722.h +++ b/api/audio_codecs/g722/audio_encoder_g722.h @@ -14,11 +14,11 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" #include "api/audio_codecs/g722/audio_encoder_g722_config.h" -#include "api/optional.h" namespace webrtc { @@ -28,14 +28,14 @@ namespace webrtc { // NOTE: This struct is still under development and may change without notice. struct AudioEncoderG722 { using Config = AudioEncoderG722Config; - static rtc::Optional<AudioEncoderG722Config> SdpToConfig( + static absl::optional<AudioEncoderG722Config> SdpToConfig( const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const AudioEncoderG722Config& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const AudioEncoderG722Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/ilbc/BUILD.gn b/api/audio_codecs/ilbc/BUILD.gn index 52dac5f591..e1b2731e49 100644 --- a/api/audio_codecs/ilbc/BUILD.gn +++ b/api/audio_codecs/ilbc/BUILD.gn @@ -29,11 +29,11 @@ rtc_static_library("audio_encoder_ilbc") { deps = [ ":audio_encoder_ilbc_config", "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:ilbc", "../../../rtc_base:rtc_base_approved", "../../../rtc_base:safe_minmax", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -46,9 +46,9 @@ rtc_static_library("audio_decoder_ilbc") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:ilbc", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/ilbc/audio_decoder_ilbc.cc b/api/audio_codecs/ilbc/audio_decoder_ilbc.cc index 88a247103b..f1ecbdc990 100644 --- a/api/audio_codecs/ilbc/audio_decoder_ilbc.cc +++ b/api/audio_codecs/ilbc/audio_decoder_ilbc.cc @@ -19,12 +19,12 @@ namespace webrtc { -rtc::Optional<AudioDecoderIlbc::Config> AudioDecoderIlbc::SdpToConfig( +absl::optional<AudioDecoderIlbc::Config> AudioDecoderIlbc::SdpToConfig( const SdpAudioFormat& format) { return STR_CASE_CMP(format.name.c_str(), "ILBC") == 0 && format.clockrate_hz == 8000 && format.num_channels == 1 - ? rtc::Optional<Config>(Config()) - : rtc::nullopt; + ? absl::optional<Config>(Config()) + : absl::nullopt; } void AudioDecoderIlbc::AppendSupportedDecoders( @@ -34,7 +34,7 @@ void AudioDecoderIlbc::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderIlbc::MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { return rtc::MakeUnique<AudioDecoderIlbcImpl>(); } diff --git a/api/audio_codecs/ilbc/audio_decoder_ilbc.h b/api/audio_codecs/ilbc/audio_decoder_ilbc.h index c233c4b79a..20f6ffd287 100644 --- a/api/audio_codecs/ilbc/audio_decoder_ilbc.h +++ b/api/audio_codecs/ilbc/audio_decoder_ilbc.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -27,11 +27,11 @@ namespace webrtc { // NOTE: This struct is still under development and may change without notice. struct AudioDecoderIlbc { struct Config {}; // Empty---no config values needed! - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/ilbc/audio_encoder_ilbc.cc b/api/audio_codecs/ilbc/audio_encoder_ilbc.cc index 53dfdd31ea..59a16b53dc 100644 --- a/api/audio_codecs/ilbc/audio_encoder_ilbc.cc +++ b/api/audio_codecs/ilbc/audio_encoder_ilbc.cc @@ -38,11 +38,11 @@ int GetIlbcBitrate(int ptime) { } } // namespace -rtc::Optional<AudioEncoderIlbcConfig> AudioEncoderIlbc::SdpToConfig( +absl::optional<AudioEncoderIlbcConfig> AudioEncoderIlbc::SdpToConfig( const SdpAudioFormat& format) { if (STR_CASE_CMP(format.name.c_str(), "ILBC") != 0 || format.clockrate_hz != 8000 || format.num_channels != 1) { - return rtc::nullopt; + return absl::nullopt; } AudioEncoderIlbcConfig config; @@ -54,8 +54,8 @@ rtc::Optional<AudioEncoderIlbcConfig> AudioEncoderIlbc::SdpToConfig( config.frame_size_ms = rtc::SafeClamp<int>(whole_packets * 10, 20, 60); } } - return config.IsOk() ? rtc::Optional<AudioEncoderIlbcConfig>(config) - : rtc::nullopt; + return config.IsOk() ? absl::optional<AudioEncoderIlbcConfig>(config) + : absl::nullopt; } void AudioEncoderIlbc::AppendSupportedEncoders( @@ -74,7 +74,7 @@ AudioCodecInfo AudioEncoderIlbc::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderIlbc::MakeAudioEncoder( const AudioEncoderIlbcConfig& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); return rtc::MakeUnique<AudioEncoderIlbcImpl>(config, payload_type); } diff --git a/api/audio_codecs/ilbc/audio_encoder_ilbc.h b/api/audio_codecs/ilbc/audio_encoder_ilbc.h index 85cdab0ee4..0a86b162e8 100644 --- a/api/audio_codecs/ilbc/audio_encoder_ilbc.h +++ b/api/audio_codecs/ilbc/audio_encoder_ilbc.h @@ -14,11 +14,11 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" #include "api/audio_codecs/ilbc/audio_encoder_ilbc_config.h" -#include "api/optional.h" namespace webrtc { @@ -28,14 +28,14 @@ namespace webrtc { // NOTE: This struct is still under development and may change without notice. struct AudioEncoderIlbc { using Config = AudioEncoderIlbcConfig; - static rtc::Optional<AudioEncoderIlbcConfig> SdpToConfig( + static absl::optional<AudioEncoderIlbcConfig> SdpToConfig( const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const AudioEncoderIlbcConfig& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const AudioEncoderIlbcConfig& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/isac/BUILD.gn b/api/audio_codecs/isac/BUILD.gn index 08cabc5b02..e8e6d232d7 100644 --- a/api/audio_codecs/isac/BUILD.gn +++ b/api/audio_codecs/isac/BUILD.gn @@ -77,10 +77,10 @@ rtc_static_library("audio_encoder_isac_fix") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:isac_fix", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -93,10 +93,10 @@ rtc_static_library("audio_decoder_isac_fix") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:isac_fix", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -109,10 +109,10 @@ rtc_static_library("audio_encoder_isac_float") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:isac", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -125,9 +125,9 @@ rtc_static_library("audio_decoder_isac_float") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:isac", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/isac/audio_decoder_isac_fix.cc b/api/audio_codecs/isac/audio_decoder_isac_fix.cc index ab220f05fe..8435d05384 100644 --- a/api/audio_codecs/isac/audio_decoder_isac_fix.cc +++ b/api/audio_codecs/isac/audio_decoder_isac_fix.cc @@ -16,12 +16,12 @@ namespace webrtc { -rtc::Optional<AudioDecoderIsacFix::Config> AudioDecoderIsacFix::SdpToConfig( +absl::optional<AudioDecoderIsacFix::Config> AudioDecoderIsacFix::SdpToConfig( const SdpAudioFormat& format) { return STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && format.clockrate_hz == 16000 && format.num_channels == 1 - ? rtc::Optional<Config>(Config()) - : rtc::nullopt; + ? absl::optional<Config>(Config()) + : absl::nullopt; } void AudioDecoderIsacFix::AppendSupportedDecoders( @@ -31,7 +31,7 @@ void AudioDecoderIsacFix::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderIsacFix::MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { return rtc::MakeUnique<AudioDecoderIsacFixImpl>(16000); } diff --git a/api/audio_codecs/isac/audio_decoder_isac_fix.h b/api/audio_codecs/isac/audio_decoder_isac_fix.h index 115486c6bf..a4ce685838 100644 --- a/api/audio_codecs/isac/audio_decoder_isac_fix.h +++ b/api/audio_codecs/isac/audio_decoder_isac_fix.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -27,11 +27,11 @@ namespace webrtc { // NOTE: This struct is still under development and may change without notice. struct AudioDecoderIsacFix { struct Config {}; // Empty---no config values needed! - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/isac/audio_decoder_isac_float.cc b/api/audio_codecs/isac/audio_decoder_isac_float.cc index e568f07610..2e08e55960 100644 --- a/api/audio_codecs/isac/audio_decoder_isac_float.cc +++ b/api/audio_codecs/isac/audio_decoder_isac_float.cc @@ -16,8 +16,8 @@ namespace webrtc { -rtc::Optional<AudioDecoderIsacFloat::Config> AudioDecoderIsacFloat::SdpToConfig( - const SdpAudioFormat& format) { +absl::optional<AudioDecoderIsacFloat::Config> +AudioDecoderIsacFloat::SdpToConfig(const SdpAudioFormat& format) { if (STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && (format.clockrate_hz == 16000 || format.clockrate_hz == 32000) && format.num_channels == 1) { @@ -25,7 +25,7 @@ rtc::Optional<AudioDecoderIsacFloat::Config> AudioDecoderIsacFloat::SdpToConfig( config.sample_rate_hz = format.clockrate_hz; return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -37,7 +37,7 @@ void AudioDecoderIsacFloat::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderIsacFloat::MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); return rtc::MakeUnique<AudioDecoderIsacFloatImpl>(config.sample_rate_hz); } diff --git a/api/audio_codecs/isac/audio_decoder_isac_float.h b/api/audio_codecs/isac/audio_decoder_isac_float.h index 47c2c6037f..cc13963419 100644 --- a/api/audio_codecs/isac/audio_decoder_isac_float.h +++ b/api/audio_codecs/isac/audio_decoder_isac_float.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -32,11 +32,11 @@ struct AudioDecoderIsacFloat { } int sample_rate_hz = 16000; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/isac/audio_encoder_isac_fix.cc b/api/audio_codecs/isac/audio_encoder_isac_fix.cc index e2c7958e6e..cb412149a9 100644 --- a/api/audio_codecs/isac/audio_encoder_isac_fix.cc +++ b/api/audio_codecs/isac/audio_encoder_isac_fix.cc @@ -17,7 +17,7 @@ namespace webrtc { -rtc::Optional<AudioEncoderIsacFix::Config> AudioEncoderIsacFix::SdpToConfig( +absl::optional<AudioEncoderIsacFix::Config> AudioEncoderIsacFix::SdpToConfig( const SdpAudioFormat& format) { if (STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && format.clockrate_hz == 16000 && format.num_channels == 1) { @@ -31,7 +31,7 @@ rtc::Optional<AudioEncoderIsacFix::Config> AudioEncoderIsacFix::SdpToConfig( } return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -51,7 +51,7 @@ AudioCodecInfo AudioEncoderIsacFix::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderIsacFix::MakeAudioEncoder( AudioEncoderIsacFix::Config config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); AudioEncoderIsacFixImpl::Config c; c.frame_size_ms = config.frame_size_ms; diff --git a/api/audio_codecs/isac/audio_encoder_isac_fix.h b/api/audio_codecs/isac/audio_encoder_isac_fix.h index 7f2743cf17..731e48d0c2 100644 --- a/api/audio_codecs/isac/audio_encoder_isac_fix.h +++ b/api/audio_codecs/isac/audio_encoder_isac_fix.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -30,13 +30,13 @@ struct AudioEncoderIsacFix { bool IsOk() const { return frame_size_ms == 30 || frame_size_ms == 60; } int frame_size_ms = 30; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(Config config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( Config config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/isac/audio_encoder_isac_float.cc b/api/audio_codecs/isac/audio_encoder_isac_float.cc index 5fbbe2bb0a..510244c41e 100644 --- a/api/audio_codecs/isac/audio_encoder_isac_float.cc +++ b/api/audio_codecs/isac/audio_encoder_isac_float.cc @@ -17,8 +17,8 @@ namespace webrtc { -rtc::Optional<AudioEncoderIsacFloat::Config> AudioEncoderIsacFloat::SdpToConfig( - const SdpAudioFormat& format) { +absl::optional<AudioEncoderIsacFloat::Config> +AudioEncoderIsacFloat::SdpToConfig(const SdpAudioFormat& format) { if (STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && (format.clockrate_hz == 16000 || format.clockrate_hz == 32000) && format.num_channels == 1) { @@ -37,7 +37,7 @@ rtc::Optional<AudioEncoderIsacFloat::Config> AudioEncoderIsacFloat::SdpToConfig( } return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -62,7 +62,7 @@ AudioCodecInfo AudioEncoderIsacFloat::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderIsacFloat::MakeAudioEncoder( const AudioEncoderIsacFloat::Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { RTC_DCHECK(config.IsOk()); AudioEncoderIsacFloatImpl::Config c; c.sample_rate_hz = config.sample_rate_hz; diff --git a/api/audio_codecs/isac/audio_encoder_isac_float.h b/api/audio_codecs/isac/audio_encoder_isac_float.h index b6043f2aba..6d98bf9968 100644 --- a/api/audio_codecs/isac/audio_encoder_isac_float.h +++ b/api/audio_codecs/isac/audio_encoder_isac_float.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -35,13 +35,13 @@ struct AudioEncoderIsacFloat { int sample_rate_hz = 16000; int frame_size_ms = 30; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const Config& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const Config& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/opus/BUILD.gn b/api/audio_codecs/opus/BUILD.gn index d235d1a248..953482e44a 100644 --- a/api/audio_codecs/opus/BUILD.gn +++ b/api/audio_codecs/opus/BUILD.gn @@ -19,8 +19,8 @@ rtc_static_library("audio_encoder_opus_config") { "audio_encoder_opus_config.h", ] deps = [ - "../..:optional", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] defines = [] if (rtc_opus_variable_complexity) { @@ -42,9 +42,9 @@ rtc_source_set("audio_encoder_opus") { deps = [ ":audio_encoder_opus_config", "..:audio_codecs_api", - "../..:optional", "../../../modules/audio_coding:webrtc_opus", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } @@ -57,9 +57,9 @@ rtc_static_library("audio_decoder_opus") { ] deps = [ "..:audio_codecs_api", - "../..:optional", "../../..:webrtc_common", "../../../modules/audio_coding:webrtc_opus", "../../../rtc_base:rtc_base_approved", + "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/api/audio_codecs/opus/audio_decoder_opus.cc b/api/audio_codecs/opus/audio_decoder_opus.cc index 73a0a3fc5d..81bee77ad2 100644 --- a/api/audio_codecs/opus/audio_decoder_opus.cc +++ b/api/audio_codecs/opus/audio_decoder_opus.cc @@ -20,9 +20,9 @@ namespace webrtc { -rtc::Optional<AudioDecoderOpus::Config> AudioDecoderOpus::SdpToConfig( +absl::optional<AudioDecoderOpus::Config> AudioDecoderOpus::SdpToConfig( const SdpAudioFormat& format) { - const auto num_channels = [&]() -> rtc::Optional<int> { + const auto num_channels = [&]() -> absl::optional<int> { auto stereo = format.parameters.find("stereo"); if (stereo != format.parameters.end()) { if (stereo->second == "0") { @@ -30,7 +30,7 @@ rtc::Optional<AudioDecoderOpus::Config> AudioDecoderOpus::SdpToConfig( } else if (stereo->second == "1") { return 2; } else { - return rtc::nullopt; // Bad stereo parameter. + return absl::nullopt; // Bad stereo parameter. } } return 1; // Default to mono. @@ -40,7 +40,7 @@ rtc::Optional<AudioDecoderOpus::Config> AudioDecoderOpus::SdpToConfig( num_channels) { return Config{*num_channels}; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -56,7 +56,7 @@ void AudioDecoderOpus::AppendSupportedDecoders( std::unique_ptr<AudioDecoder> AudioDecoderOpus::MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { return rtc::MakeUnique<AudioDecoderOpusImpl>(config.num_channels); } diff --git a/api/audio_codecs/opus/audio_decoder_opus.h b/api/audio_codecs/opus/audio_decoder_opus.h index f76d244c67..de26026b78 100644 --- a/api/audio_codecs/opus/audio_decoder_opus.h +++ b/api/audio_codecs/opus/audio_decoder_opus.h @@ -14,10 +14,10 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_decoder.h" #include "api/audio_codecs/audio_format.h" -#include "api/optional.h" namespace webrtc { @@ -29,11 +29,11 @@ struct AudioDecoderOpus { struct Config { int num_channels; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); + static absl::optional<Config> SdpToConfig(const SdpAudioFormat& audio_format); static void AppendSupportedDecoders(std::vector<AudioCodecSpec>* specs); static std::unique_ptr<AudioDecoder> MakeAudioDecoder( Config config, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/opus/audio_encoder_opus.cc b/api/audio_codecs/opus/audio_encoder_opus.cc index 8ba66fbdb9..36d82b3eff 100644 --- a/api/audio_codecs/opus/audio_encoder_opus.cc +++ b/api/audio_codecs/opus/audio_encoder_opus.cc @@ -14,7 +14,7 @@ namespace webrtc { -rtc::Optional<AudioEncoderOpusConfig> AudioEncoderOpus::SdpToConfig( +absl::optional<AudioEncoderOpusConfig> AudioEncoderOpus::SdpToConfig( const SdpAudioFormat& format) { return AudioEncoderOpusImpl::SdpToConfig(format); } @@ -32,7 +32,7 @@ AudioCodecInfo AudioEncoderOpus::QueryAudioEncoder( std::unique_ptr<AudioEncoder> AudioEncoderOpus::MakeAudioEncoder( const AudioEncoderOpusConfig& config, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/) { return AudioEncoderOpusImpl::MakeAudioEncoder(config, payload_type); } diff --git a/api/audio_codecs/opus/audio_encoder_opus.h b/api/audio_codecs/opus/audio_encoder_opus.h index 632526966d..20aaaf726f 100644 --- a/api/audio_codecs/opus/audio_encoder_opus.h +++ b/api/audio_codecs/opus/audio_encoder_opus.h @@ -14,11 +14,11 @@ #include <memory> #include <vector> +#include "absl/types/optional.h" #include "api/audio_codecs/audio_codec_pair_id.h" #include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_format.h" #include "api/audio_codecs/opus/audio_encoder_opus_config.h" -#include "api/optional.h" namespace webrtc { @@ -28,14 +28,14 @@ namespace webrtc { // NOTE: This struct is still under development and may change without notice. struct AudioEncoderOpus { using Config = AudioEncoderOpusConfig; - static rtc::Optional<AudioEncoderOpusConfig> SdpToConfig( + static absl::optional<AudioEncoderOpusConfig> SdpToConfig( const SdpAudioFormat& audio_format); static void AppendSupportedEncoders(std::vector<AudioCodecSpec>* specs); static AudioCodecInfo QueryAudioEncoder(const AudioEncoderOpusConfig& config); static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const AudioEncoderOpusConfig& config, int payload_type, - rtc::Optional<AudioCodecPairId> codec_pair_id = rtc::nullopt); + absl::optional<AudioCodecPairId> codec_pair_id = absl::nullopt); }; } // namespace webrtc diff --git a/api/audio_codecs/opus/audio_encoder_opus_config.h b/api/audio_codecs/opus/audio_encoder_opus_config.h index d586592ab0..c7067bb1c3 100644 --- a/api/audio_codecs/opus/audio_encoder_opus_config.h +++ b/api/audio_codecs/opus/audio_encoder_opus_config.h @@ -15,7 +15,7 @@ #include <vector> -#include "api/optional.h" +#include "absl/types/optional.h" namespace webrtc { @@ -42,7 +42,7 @@ struct AudioEncoderOpusConfig { // NOTE: This member must always be set. // TODO(kwiberg): Turn it into just an int. - rtc::Optional<int> bitrate_bps; + absl::optional<int> bitrate_bps; bool fec_enabled; bool cbr_enabled; diff --git a/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc b/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc index 5fa4344105..e4f09d4746 100644 --- a/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc +++ b/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc @@ -43,12 +43,13 @@ struct AudioDecoderFakeApi { SdpAudioFormat audio_format; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format) { + static absl::optional<Config> SdpToConfig( + const SdpAudioFormat& audio_format) { if (Params::AudioFormat() == audio_format) { Config config = {audio_format}; return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -62,7 +63,7 @@ struct AudioDecoderFakeApi { static std::unique_ptr<AudioDecoder> MakeAudioDecoder( const Config&, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/ = rtc::nullopt) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/ = absl::nullopt) { auto dec = rtc::MakeUnique<testing::StrictMock<MockAudioDecoder>>(); EXPECT_CALL(*dec, SampleRateHz()) .WillOnce(testing::Return(Params::CodecInfo().sample_rate_hz)); @@ -80,7 +81,7 @@ TEST(AudioDecoderFactoryTemplateTest, NoDecoderTypes) { EXPECT_THAT(factory->GetSupportedDecoders(), testing::IsEmpty()); EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"bar", 16000, 1}, rtc::nullopt)); + factory->MakeAudioDecoder({"bar", 16000, 1}, absl::nullopt)); } TEST(AudioDecoderFactoryTemplateTest, OneDecoderType) { @@ -91,8 +92,8 @@ TEST(AudioDecoderFactoryTemplateTest, OneDecoderType) { EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"bogus", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"bar", 16000, 1}, rtc::nullopt)); - auto dec = factory->MakeAudioDecoder({"bogus", 8000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"bar", 16000, 1}, absl::nullopt)); + auto dec = factory->MakeAudioDecoder({"bogus", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec); EXPECT_EQ(8000, dec->SampleRateHz()); } @@ -110,14 +111,14 @@ TEST(AudioDecoderFactoryTemplateTest, TwoDecoderTypes) { EXPECT_TRUE( factory->IsSupportedDecoder({"sham", 16000, 2, {{"param", "value"}}})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"bar", 16000, 1}, rtc::nullopt)); - auto dec1 = factory->MakeAudioDecoder({"bogus", 8000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"bar", 16000, 1}, absl::nullopt)); + auto dec1 = factory->MakeAudioDecoder({"bogus", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec1); EXPECT_EQ(8000, dec1->SampleRateHz()); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"sham", 16000, 2}, rtc::nullopt)); + factory->MakeAudioDecoder({"sham", 16000, 2}, absl::nullopt)); auto dec2 = factory->MakeAudioDecoder( - {"sham", 16000, 2, {{"param", "value"}}}, rtc::nullopt); + {"sham", 16000, 2, {{"param", "value"}}}, absl::nullopt); ASSERT_NE(nullptr, dec2); EXPECT_EQ(16000, dec2->SampleRateHz()); } @@ -132,11 +133,11 @@ TEST(AudioDecoderFactoryTemplateTest, G711) { EXPECT_TRUE(factory->IsSupportedDecoder({"PCMU", 8000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"pcma", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"pcmu", 16000, 1}, rtc::nullopt)); - auto dec1 = factory->MakeAudioDecoder({"pcmu", 8000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"pcmu", 16000, 1}, absl::nullopt)); + auto dec1 = factory->MakeAudioDecoder({"pcmu", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec1); EXPECT_EQ(8000, dec1->SampleRateHz()); - auto dec2 = factory->MakeAudioDecoder({"PCMA", 8000, 1}, rtc::nullopt); + auto dec2 = factory->MakeAudioDecoder({"PCMA", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec2); EXPECT_EQ(8000, dec2->SampleRateHz()); } @@ -149,16 +150,16 @@ TEST(AudioDecoderFactoryTemplateTest, G722) { EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"G722", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"bar", 16000, 1}, rtc::nullopt)); - auto dec1 = factory->MakeAudioDecoder({"G722", 8000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"bar", 16000, 1}, absl::nullopt)); + auto dec1 = factory->MakeAudioDecoder({"G722", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec1); EXPECT_EQ(16000, dec1->SampleRateHz()); EXPECT_EQ(1u, dec1->Channels()); - auto dec2 = factory->MakeAudioDecoder({"G722", 8000, 2}, rtc::nullopt); + auto dec2 = factory->MakeAudioDecoder({"G722", 8000, 2}, absl::nullopt); ASSERT_NE(nullptr, dec2); EXPECT_EQ(16000, dec2->SampleRateHz()); EXPECT_EQ(2u, dec2->Channels()); - auto dec3 = factory->MakeAudioDecoder({"G722", 8000, 3}, rtc::nullopt); + auto dec3 = factory->MakeAudioDecoder({"G722", 8000, 3}, absl::nullopt); ASSERT_EQ(nullptr, dec3); } @@ -169,8 +170,9 @@ TEST(AudioDecoderFactoryTemplateTest, Ilbc) { AudioCodecSpec{{"ILBC", 8000, 1}, {8000, 1, 13300}})); EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"ilbc", 8000, 1})); - EXPECT_EQ(nullptr, factory->MakeAudioDecoder({"bar", 8000, 1}, rtc::nullopt)); - auto dec = factory->MakeAudioDecoder({"ilbc", 8000, 1}, rtc::nullopt); + EXPECT_EQ(nullptr, + factory->MakeAudioDecoder({"bar", 8000, 1}, absl::nullopt)); + auto dec = factory->MakeAudioDecoder({"ilbc", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec); EXPECT_EQ(8000, dec->SampleRateHz()); } @@ -184,8 +186,8 @@ TEST(AudioDecoderFactoryTemplateTest, IsacFix) { EXPECT_TRUE(factory->IsSupportedDecoder({"isac", 16000, 1})); EXPECT_FALSE(factory->IsSupportedDecoder({"isac", 32000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"isac", 8000, 1}, rtc::nullopt)); - auto dec = factory->MakeAudioDecoder({"isac", 16000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"isac", 8000, 1}, absl::nullopt)); + auto dec = factory->MakeAudioDecoder({"isac", 16000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec); EXPECT_EQ(16000, dec->SampleRateHz()); } @@ -201,11 +203,11 @@ TEST(AudioDecoderFactoryTemplateTest, IsacFloat) { EXPECT_TRUE(factory->IsSupportedDecoder({"isac", 16000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"isac", 32000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"isac", 8000, 1}, rtc::nullopt)); - auto dec1 = factory->MakeAudioDecoder({"isac", 16000, 1}, rtc::nullopt); + factory->MakeAudioDecoder({"isac", 8000, 1}, absl::nullopt)); + auto dec1 = factory->MakeAudioDecoder({"isac", 16000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec1); EXPECT_EQ(16000, dec1->SampleRateHz()); - auto dec2 = factory->MakeAudioDecoder({"isac", 32000, 1}, rtc::nullopt); + auto dec2 = factory->MakeAudioDecoder({"isac", 32000, 1}, absl::nullopt); ASSERT_NE(nullptr, dec2); EXPECT_EQ(32000, dec2->SampleRateHz()); } @@ -224,8 +226,9 @@ TEST(AudioDecoderFactoryTemplateTest, L16) { EXPECT_FALSE(factory->IsSupportedDecoder({"foo", 8000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"L16", 48000, 1})); EXPECT_FALSE(factory->IsSupportedDecoder({"L16", 96000, 1})); - EXPECT_EQ(nullptr, factory->MakeAudioDecoder({"L16", 8000, 0}, rtc::nullopt)); - auto dec = factory->MakeAudioDecoder({"L16", 48000, 2}, rtc::nullopt); + EXPECT_EQ(nullptr, + factory->MakeAudioDecoder({"L16", 8000, 0}, absl::nullopt)); + auto dec = factory->MakeAudioDecoder({"L16", 48000, 2}, absl::nullopt); ASSERT_NE(nullptr, dec); EXPECT_EQ(48000, dec->SampleRateHz()); } @@ -242,8 +245,8 @@ TEST(AudioDecoderFactoryTemplateTest, Opus) { EXPECT_FALSE(factory->IsSupportedDecoder({"opus", 48000, 1})); EXPECT_TRUE(factory->IsSupportedDecoder({"opus", 48000, 2})); EXPECT_EQ(nullptr, - factory->MakeAudioDecoder({"bar", 16000, 1}, rtc::nullopt)); - auto dec = factory->MakeAudioDecoder({"opus", 48000, 2}, rtc::nullopt); + factory->MakeAudioDecoder({"bar", 16000, 1}, absl::nullopt)); + auto dec = factory->MakeAudioDecoder({"opus", 48000, 2}, absl::nullopt); ASSERT_NE(nullptr, dec); EXPECT_EQ(48000, dec->SampleRateHz()); } diff --git a/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc b/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc index 3da588d590..46781ce476 100644 --- a/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc +++ b/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc @@ -43,12 +43,13 @@ struct AudioEncoderFakeApi { SdpAudioFormat audio_format; }; - static rtc::Optional<Config> SdpToConfig(const SdpAudioFormat& audio_format) { + static absl::optional<Config> SdpToConfig( + const SdpAudioFormat& audio_format) { if (Params::AudioFormat() == audio_format) { Config config = {audio_format}; return config; } else { - return rtc::nullopt; + return absl::nullopt; } } @@ -63,7 +64,7 @@ struct AudioEncoderFakeApi { static std::unique_ptr<AudioEncoder> MakeAudioEncoder( const Config&, int payload_type, - rtc::Optional<AudioCodecPairId> /*codec_pair_id*/ = rtc::nullopt) { + absl::optional<AudioCodecPairId> /*codec_pair_id*/ = absl::nullopt) { auto enc = rtc::MakeUnique<testing::StrictMock<MockAudioEncoder>>(); EXPECT_CALL(*enc, SampleRateHz()) .WillOnce(testing::Return(Params::CodecInfo().sample_rate_hz)); @@ -78,9 +79,9 @@ TEST(AudioEncoderFactoryTemplateTest, NoEncoderTypes) { new rtc::RefCountedObject< audio_encoder_factory_template_impl::AudioEncoderFactoryT<>>()); EXPECT_THAT(factory->GetSupportedEncoders(), testing::IsEmpty()); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 16000, 1}, rtc::nullopt)); + factory->MakeAudioEncoder(17, {"bar", 16000, 1}, absl::nullopt)); } TEST(AudioEncoderFactoryTemplateTest, OneEncoderType) { @@ -88,12 +89,12 @@ TEST(AudioEncoderFactoryTemplateTest, OneEncoderType) { EXPECT_THAT(factory->GetSupportedEncoders(), testing::ElementsAre( AudioCodecSpec{{"bogus", 8000, 1}, {8000, 1, 12345}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ(AudioCodecInfo(8000, 1, 12345), factory->QueryAudioEncoder({"bogus", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 16000, 1}, rtc::nullopt)); - auto enc = factory->MakeAudioEncoder(17, {"bogus", 8000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"bar", 16000, 1}, absl::nullopt)); + auto enc = factory->MakeAudioEncoder(17, {"bogus", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc); EXPECT_EQ(8000, enc->SampleRateHz()); } @@ -106,21 +107,21 @@ TEST(AudioEncoderFactoryTemplateTest, TwoEncoderTypes) { AudioCodecSpec{{"bogus", 8000, 1}, {8000, 1, 12345}}, AudioCodecSpec{{"sham", 16000, 2, {{"param", "value"}}}, {16000, 2, 23456}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ(AudioCodecInfo(8000, 1, 12345), factory->QueryAudioEncoder({"bogus", 8000, 1})); EXPECT_EQ( AudioCodecInfo(16000, 2, 23456), factory->QueryAudioEncoder({"sham", 16000, 2, {{"param", "value"}}})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 16000, 1}, rtc::nullopt)); - auto enc1 = factory->MakeAudioEncoder(17, {"bogus", 8000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"bar", 16000, 1}, absl::nullopt)); + auto enc1 = factory->MakeAudioEncoder(17, {"bogus", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc1); EXPECT_EQ(8000, enc1->SampleRateHz()); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"sham", 16000, 2}, rtc::nullopt)); + factory->MakeAudioEncoder(17, {"sham", 16000, 2}, absl::nullopt)); auto enc2 = factory->MakeAudioEncoder( - 17, {"sham", 16000, 2, {{"param", "value"}}}, rtc::nullopt); + 17, {"sham", 16000, 2, {{"param", "value"}}}, absl::nullopt); ASSERT_NE(nullptr, enc2); EXPECT_EQ(16000, enc2->SampleRateHz()); } @@ -131,15 +132,15 @@ TEST(AudioEncoderFactoryTemplateTest, G711) { testing::ElementsAre( AudioCodecSpec{{"PCMU", 8000, 1}, {8000, 1, 64000}}, AudioCodecSpec{{"PCMA", 8000, 1}, {8000, 1, 64000}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"PCMA", 16000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"PCMA", 16000, 1})); EXPECT_EQ(AudioCodecInfo(8000, 1, 64000), factory->QueryAudioEncoder({"PCMA", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"PCMU", 16000, 1}, rtc::nullopt)); - auto enc1 = factory->MakeAudioEncoder(17, {"PCMU", 8000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"PCMU", 16000, 1}, absl::nullopt)); + auto enc1 = factory->MakeAudioEncoder(17, {"PCMU", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc1); EXPECT_EQ(8000, enc1->SampleRateHz()); - auto enc2 = factory->MakeAudioEncoder(17, {"PCMA", 8000, 1}, rtc::nullopt); + auto enc2 = factory->MakeAudioEncoder(17, {"PCMA", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc2); EXPECT_EQ(8000, enc2->SampleRateHz()); } @@ -149,12 +150,12 @@ TEST(AudioEncoderFactoryTemplateTest, G722) { EXPECT_THAT(factory->GetSupportedEncoders(), testing::ElementsAre( AudioCodecSpec{{"G722", 8000, 1}, {16000, 1, 64000}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ(AudioCodecInfo(16000, 1, 64000), factory->QueryAudioEncoder({"G722", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 16000, 1}, rtc::nullopt)); - auto enc = factory->MakeAudioEncoder(17, {"G722", 8000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"bar", 16000, 1}, absl::nullopt)); + auto enc = factory->MakeAudioEncoder(17, {"G722", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc); EXPECT_EQ(16000, enc->SampleRateHz()); } @@ -164,12 +165,12 @@ TEST(AudioEncoderFactoryTemplateTest, Ilbc) { EXPECT_THAT(factory->GetSupportedEncoders(), testing::ElementsAre( AudioCodecSpec{{"ILBC", 8000, 1}, {8000, 1, 13333}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ(AudioCodecInfo(8000, 1, 13333), factory->QueryAudioEncoder({"ilbc", 8000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 8000, 1}, rtc::nullopt)); - auto enc = factory->MakeAudioEncoder(17, {"ilbc", 8000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"bar", 8000, 1}, absl::nullopt)); + auto enc = factory->MakeAudioEncoder(17, {"ilbc", 8000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc); EXPECT_EQ(8000, enc->SampleRateHz()); } @@ -179,18 +180,18 @@ TEST(AudioEncoderFactoryTemplateTest, IsacFix) { EXPECT_THAT(factory->GetSupportedEncoders(), testing::ElementsAre(AudioCodecSpec{ {"ISAC", 16000, 1}, {16000, 1, 32000, 10000, 32000}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"isac", 16000, 2})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"isac", 16000, 2})); EXPECT_EQ(AudioCodecInfo(16000, 1, 32000, 10000, 32000), factory->QueryAudioEncoder({"isac", 16000, 1})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"isac", 32000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"isac", 32000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"isac", 8000, 1}, rtc::nullopt)); - auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"isac", 8000, 1}, absl::nullopt)); + auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc1); EXPECT_EQ(16000, enc1->SampleRateHz()); EXPECT_EQ(3u, enc1->Num10MsFramesInNextPacket()); auto enc2 = factory->MakeAudioEncoder( - 17, {"isac", 16000, 1, {{"ptime", "60"}}}, rtc::nullopt); + 17, {"isac", 16000, 1, {{"ptime", "60"}}}, absl::nullopt); ASSERT_NE(nullptr, enc2); EXPECT_EQ(6u, enc2->Num10MsFramesInNextPacket()); } @@ -202,17 +203,17 @@ TEST(AudioEncoderFactoryTemplateTest, IsacFloat) { testing::ElementsAre( AudioCodecSpec{{"ISAC", 16000, 1}, {16000, 1, 32000, 10000, 32000}}, AudioCodecSpec{{"ISAC", 32000, 1}, {32000, 1, 56000, 10000, 56000}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"isac", 16000, 2})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"isac", 16000, 2})); EXPECT_EQ(AudioCodecInfo(16000, 1, 32000, 10000, 32000), factory->QueryAudioEncoder({"isac", 16000, 1})); EXPECT_EQ(AudioCodecInfo(32000, 1, 56000, 10000, 56000), factory->QueryAudioEncoder({"isac", 32000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"isac", 8000, 1}, rtc::nullopt)); - auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"isac", 8000, 1}, absl::nullopt)); + auto enc1 = factory->MakeAudioEncoder(17, {"isac", 16000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc1); EXPECT_EQ(16000, enc1->SampleRateHz()); - auto enc2 = factory->MakeAudioEncoder(17, {"isac", 32000, 1}, rtc::nullopt); + auto enc2 = factory->MakeAudioEncoder(17, {"isac", 32000, 1}, absl::nullopt); ASSERT_NE(nullptr, enc2); EXPECT_EQ(32000, enc2->SampleRateHz()); } @@ -228,12 +229,12 @@ TEST(AudioEncoderFactoryTemplateTest, L16) { AudioCodecSpec{{"L16", 8000, 2}, {8000, 2, 8000 * 16 * 2}}, AudioCodecSpec{{"L16", 16000, 2}, {16000, 2, 16000 * 16 * 2}}, AudioCodecSpec{{"L16", 32000, 2}, {32000, 2, 32000 * 16 * 2}})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"L16", 8000, 0})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"L16", 8000, 0})); EXPECT_EQ(AudioCodecInfo(48000, 1, 48000 * 16), factory->QueryAudioEncoder({"L16", 48000, 1})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"L16", 8000, 0}, rtc::nullopt)); - auto enc = factory->MakeAudioEncoder(17, {"L16", 48000, 2}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"L16", 8000, 0}, absl::nullopt)); + auto enc = factory->MakeAudioEncoder(17, {"L16", 48000, 2}, absl::nullopt); ASSERT_NE(nullptr, enc); EXPECT_EQ(48000, enc->SampleRateHz()); } @@ -248,14 +249,14 @@ TEST(AudioEncoderFactoryTemplateTest, Opus) { testing::ElementsAre(AudioCodecSpec{ {"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}}, info})); - EXPECT_EQ(rtc::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); + EXPECT_EQ(absl::nullopt, factory->QueryAudioEncoder({"foo", 8000, 1})); EXPECT_EQ( info, factory->QueryAudioEncoder( {"opus", 48000, 2, {{"minptime", "10"}, {"useinbandfec", "1"}}})); EXPECT_EQ(nullptr, - factory->MakeAudioEncoder(17, {"bar", 16000, 1}, rtc::nullopt)); - auto enc = factory->MakeAudioEncoder(17, {"opus", 48000, 2}, rtc::nullopt); + factory->MakeAudioEncoder(17, {"bar", 16000, 1}, absl::nullopt)); + auto enc = factory->MakeAudioEncoder(17, {"opus", 48000, 2}, absl::nullopt); ASSERT_NE(nullptr, enc); EXPECT_EQ(48000, enc->SampleRateHz()); } |