aboutsummaryrefslogtreecommitdiff
path: root/api
diff options
context:
space:
mode:
authorAndrey Logvin <landrey@webrtc.org>2020-05-13 08:02:26 +0000
committerCommit Bot <commit-bot@chromium.org>2020-05-13 09:16:40 +0000
commitf3319816ad981ead6a584e3ff6a4dc9fe24e7996 (patch)
tree3050cca35c3d3ccd53fcd95a779eaa99604ce8e4 /api
parent381d10963ae256d3d0bce7d74a7b08f600c63439 (diff)
downloadwebrtc-f3319816ad981ead6a584e3ff6a4dc9fe24e7996.tar.gz
Separate capturing device index from VideoConfig
The last step of the pc framework tests migration. Bug: webrtc:11534 Change-Id: I344c443b6d21422ef418315b7e5a6cb26ae3473d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174741 Commit-Queue: Andrey Logvin <landrey@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31232}
Diffstat (limited to 'api')
-rw-r--r--api/test/peerconnection_quality_test_fixture.h17
1 files changed, 11 insertions, 6 deletions
diff --git a/api/test/peerconnection_quality_test_fixture.h b/api/test/peerconnection_quality_test_fixture.h
index 20ca065052..8165443d36 100644
--- a/api/test/peerconnection_quality_test_fixture.h
+++ b/api/test/peerconnection_quality_test_fixture.h
@@ -54,6 +54,12 @@ constexpr size_t kDefaultSlidesHeight = 1110;
// API is in development. Can be changed/removed without notice.
class PeerConnectionE2EQualityTestFixture {
public:
+ // The index of required capturing device in OS provided list of video
+ // devices. On Linux and Windows the list will be obtained via
+ // webrtc::VideoCaptureModule::DeviceInfo, on Mac OS via
+ // [RTCCameraVideoCapturer captureDevices].
+ enum class CapturingDeviceIndex : size_t {};
+
// Contains parameters for screen share scrolling.
//
// If scrolling is enabled, then it will be done by putting sliding window
@@ -185,12 +191,6 @@ class PeerConnectionE2EQualityTestFixture {
// Will be set for current video track. If equals to kText or kDetailed -
// screencast in on.
absl::optional<VideoTrackInterface::ContentHint> content_hint;
- // If specified this capturing device will be used to get input video. The
- // |capturing_device_index| is the index of required capturing device in OS
- // provided list of video devices. On Linux and Windows the list will be
- // obtained via webrtc::VideoCaptureModule::DeviceInfo, on Mac OS via
- // [RTCCameraVideoCapturer captureDevices].
- absl::optional<size_t> capturing_device_index;
// If presented video will be transfered in simulcast/SVC mode depending on
// which encoder is used.
//
@@ -319,6 +319,11 @@ class PeerConnectionE2EQualityTestFixture {
virtual PeerConfigurer* AddVideoConfig(
VideoConfig config,
std::unique_ptr<test::FrameGeneratorInterface> generator) = 0;
+ // Add new video stream to the call that will be sent from this peer.
+ // Capturing device with specified index will be used to get input video.
+ virtual PeerConfigurer* AddVideoConfig(
+ VideoConfig config,
+ CapturingDeviceIndex capturing_device_index) = 0;
// Set the audio stream for the call from this peer. If this method won't
// be invoked, this peer will send no audio.
virtual PeerConfigurer* SetAudioConfig(AudioConfig config) = 0;