diff options
author | Markus Handell <handellm@webrtc.org> | 2021-06-22 10:46:48 +0200 |
---|---|---|
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-06-22 14:51:04 +0000 |
commit | eb61b7f620c1f84cb9d34c7752cea65fe5d1d721 (patch) | |
tree | 4240c7418e1c2a9fde352664bd6927b20fac07f9 /audio/voip/voip_core.h | |
parent | 6e65f6a4288674ff33614f557c33c9dc871fa2e2 (diff) | |
download | webrtc-eb61b7f620c1f84cb9d34c7752cea65fe5d1d721.tar.gz |
ModuleRtcRtcpImpl2: remove Module inheritance.upstream-master
This change achieves an Idle Wakeup savings of 200 Hz.
ModuleRtcRtcpImpl2 had Process() logic only active if TMMBR() is
enabled in RtcpSender, which it never is. Hence the Module
inheritance could be removed. The change removes all known
dependencies of the module inheritance, and any related mentions
of ProcessThread.
Fixed: webrtc:11581
Change-Id: I440942f07187fdb9ac18186dab088633969b340e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/222604
Reviewed-by: Tommi <tommi@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34358}
Diffstat (limited to 'audio/voip/voip_core.h')
-rw-r--r-- | audio/voip/voip_core.h | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/audio/voip/voip_core.h b/audio/voip/voip_core.h index b7c1f2947f..359e07272d 100644 --- a/audio/voip/voip_core.h +++ b/audio/voip/voip_core.h @@ -33,7 +33,6 @@ #include "modules/audio_device/include/audio_device.h" #include "modules/audio_mixer/audio_mixer_impl.h" #include "modules/audio_processing/include/audio_processing.h" -#include "modules/utility/include/process_thread.h" #include "rtc_base/synchronization/mutex.h" namespace webrtc { @@ -61,8 +60,7 @@ class VoipCore : public VoipEngine, rtc::scoped_refptr<AudioDecoderFactory> decoder_factory, std::unique_ptr<TaskQueueFactory> task_queue_factory, rtc::scoped_refptr<AudioDeviceModule> audio_device_module, - rtc::scoped_refptr<AudioProcessing> audio_processing, - std::unique_ptr<ProcessThread> process_thread = nullptr); + rtc::scoped_refptr<AudioProcessing> audio_processing); ~VoipCore() override = default; // Implements VoipEngine interfaces. @@ -160,10 +158,6 @@ class VoipCore : public VoipEngine, // Synchronization is handled internally by AudioDeviceModule. rtc::scoped_refptr<AudioDeviceModule> audio_device_module_; - // Synchronization is handled internally by ProcessThread. - // Must be placed before |channels_| for proper destruction. - std::unique_ptr<ProcessThread> process_thread_; - Mutex lock_; // Member to track a next ChannelId for new AudioChannel. |