diff options
| author | Mirko Bonadei <mbonadei@webrtc.org> | 2018-01-26 11:57:47 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2018-01-26 13:34:12 +0000 |
| commit | 65ce31158fdd6e1e580bdc47e51cac7b5844ffdd (patch) | |
| tree | abac8c4fa3d47d3e01060f2c95a14c365f5ecdcc /audio | |
| parent | 5e4833cc908b6d33855102a947159e406f384c75 (diff) | |
| download | webrtc-65ce31158fdd6e1e580bdc47e51cac7b5844ffdd.tar.gz | |
Removing useless dependencies on //testing/gmock.
If a WebRTC build target requires gmock it has to include
test/gmock.h and just depend on //test:test_support.
Unfortunately //testtest_support was a leaky abstraction because it
wasn't propagating the correct -I compiler flag. To make everything
work, all the targets that use gmock started also to depend on
//testing/gmock (even if they were not including any gmock header
directly).
This CL makes //testtest_support propagate the include path up in the
dependency chain so it is possible to remove unused dependencies.
Note: all_dependent_configs should probably be used in the original
gmock target. There is an ongoing discussion about it. This CL solves
the problem on WebRTC side and it is forward compatible.
TBR=phoglund@webrtc.org
Bug: webrtc:8603
Change-Id: If08daf2ce9a6431a6e881a236743b4ec33b59ea7
Reviewed-on: https://webrtc-review.googlesource.com/44340
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21776}
Diffstat (limited to 'audio')
| -rw-r--r-- | audio/BUILD.gn | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/audio/BUILD.gn b/audio/BUILD.gn index 2eee20be23..6a359aabf7 100644 --- a/audio/BUILD.gn +++ b/audio/BUILD.gn @@ -152,7 +152,6 @@ if (rtc_include_tests) { "../test:test_common", "../test:test_support", "utility:utility_tests", - "//testing/gmock", "//testing/gtest", ] @@ -183,7 +182,6 @@ if (rtc_include_tests) { "../test:fake_audio_device", "../test:test_common", "../test:test_main", - "//testing/gmock", "//testing/gtest", ] if (is_android) { @@ -237,7 +235,6 @@ if (rtc_include_tests) { "../test:single_threaded_task_queue", "../test:test_common", "../test:test_main", - "//testing/gmock", "//testing/gtest", ] |