Add unit tests for audio receive channel frame transformer delegate.

Bug: webrtc:11380
Change-Id: I4630b75c83886d722e7be64d50a9790c20956ba4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/174004
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31157}

2 files changed, 120 insertions, 0 deletions

diff --git a/audio/BUILD.gn b/audio/BUILD.gn
index 7c49cd480c..4f5e55b452 100644
--- a/audio/BUILD.gn
+++ b/audio/BUILD.gn
@@ -127,6 +127,7 @@ if (rtc_include_tests) {
       "audio_send_stream_tests.cc",
       "audio_send_stream_unittest.cc",
       "audio_state_unittest.cc",
+      "channel_receive_frame_transformer_delegate_unittest.cc",
       "mock_voe_channel_proxy.h",
       "remix_resample_unittest.cc",
       "test/audio_stats_test.cc",
@@ -172,6 +173,8 @@ if (rtc_include_tests) {
       "../system_wrappers",
       "../test:audio_codec_mocks",
       "../test:field_trial",
+      "../test:mock_frame_transformer",
+      "../test:mock_transformable_frame",
       "../test:mock_transport",
       "../test:rtp_test_utils",
       "../test:test_common",
diff --git a/audio/channel_receive_frame_transformer_delegate_unittest.cc b/audio/channel_receive_frame_transformer_delegate_unittest.cc
new file mode 100644
index 0000000000..e7f5a454b8
--- /dev/null
+++ b/audio/channel_receive_frame_transformer_delegate_unittest.cc
@@ -0,0 +1,117 @@
+/*
+ *  Copyright (c) 2020 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "audio/channel_receive_frame_transformer_delegate.h"
+
+#include <memory>
+#include <utility>
+
+#include "rtc_base/ref_counted_object.h"
+#include "test/gmock.h"
+#include "test/gtest.h"
+#include "test/mock_frame_transformer.h"
+#include "test/mock_transformable_frame.h"
+
+namespace webrtc {
+namespace {
+
+using ::testing::NiceMock;
+using ::testing::SaveArg;
+
+class MockChannelReceive {
+ public:
+  MOCK_METHOD(void,
+              ReceiveFrame,
+              (rtc::ArrayView<const uint8_t> packet, const RTPHeader& header));
+
+  ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback callback() {
+    return [this](rtc::ArrayView<const uint8_t> packet,
+                  const RTPHeader& header) { ReceiveFrame(packet, header); };
+  }
+};
+
+// Test that the delegate registers itself with the frame transformer on Init().
+TEST(ChannelReceiveFrameTransformerDelegateTest,
+     RegisterTransformedFrameCallbackOnInit) {
+  rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
+      new rtc::RefCountedObject<MockFrameTransformer>();
+  rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
+      new rtc::RefCountedObject<ChannelReceiveFrameTransformerDelegate>(
+          ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback(),
+          mock_frame_transformer, nullptr);
+  EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback);
+  delegate->Init();
+}
+
+// Test that the delegate unregisters itself from the frame transformer on
+// Reset().
+TEST(ChannelReceiveFrameTransformerDelegateTest,
+     UnregisterTransformedFrameCallbackOnReset) {
+  rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
+      new rtc::RefCountedObject<MockFrameTransformer>();
+  rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
+      new rtc::RefCountedObject<ChannelReceiveFrameTransformerDelegate>(
+          ChannelReceiveFrameTransformerDelegate::ReceiveFrameCallback(),
+          mock_frame_transformer, nullptr);
+  EXPECT_CALL(*mock_frame_transformer, UnregisterTransformedFrameCallback);
+  delegate->Reset();
+}
+
+// Test that when the delegate receives a transformed frame from the frame
+// transformer, it passes it to the channel using the ReceiveFrameCallback.
+TEST(ChannelReceiveFrameTransformerDelegateTest,
+     TransformRunsChannelReceiveCallback) {
+  rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
+      new rtc::RefCountedObject<NiceMock<MockFrameTransformer>>();
+  MockChannelReceive mock_channel;
+  rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
+      new rtc::RefCountedObject<ChannelReceiveFrameTransformerDelegate>(
+          mock_channel.callback(), mock_frame_transformer,
+          rtc::Thread::Current());
+  rtc::scoped_refptr<TransformedFrameCallback> callback;
+  EXPECT_CALL(*mock_frame_transformer, RegisterTransformedFrameCallback)
+      .WillOnce(SaveArg<0>(&callback));
+  delegate->Init();
+  ASSERT_TRUE(callback);
+
+  const uint8_t data[] = {1, 2, 3, 4};
+  rtc::ArrayView<const uint8_t> packet(data, sizeof(data));
+  RTPHeader header;
+  EXPECT_CALL(mock_channel, ReceiveFrame);
+  ON_CALL(*mock_frame_transformer, Transform)
+      .WillByDefault(
+          [&callback](std::unique_ptr<TransformableFrameInterface> frame) {
+            callback->OnTransformedFrame(std::move(frame));
+          });
+  delegate->Transform(packet, header, 1111 /*ssrc*/);
+  rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
+}
+
+// Test that if the delegate receives a transformed frame after it has been
+// reset, it does not run the ReceiveFrameCallback, as the channel is destroyed
+// after resetting the delegate.
+TEST(ChannelReceiveFrameTransformerDelegateTest,
+     OnTransformedDoesNotRunChannelReceiveCallbackAfterReset) {
+  rtc::scoped_refptr<MockFrameTransformer> mock_frame_transformer =
+      new rtc::RefCountedObject<testing::NiceMock<MockFrameTransformer>>();
+  MockChannelReceive mock_channel;
+  rtc::scoped_refptr<ChannelReceiveFrameTransformerDelegate> delegate =
+      new rtc::RefCountedObject<ChannelReceiveFrameTransformerDelegate>(
+          mock_channel.callback(), mock_frame_transformer,
+          rtc::Thread::Current());
+
+  delegate->Reset();
+  EXPECT_CALL(mock_channel, ReceiveFrame).Times(0);
+  delegate->OnTransformedFrame(std::make_unique<MockTransformableFrame>());
+  rtc::ThreadManager::ProcessAllMessageQueuesForTesting();
+}
+
+}  // namespace
+}  // namespace webrtc