aboutsummaryrefslogtreecommitdiff
path: root/common_audio
diff options
context:
space:
mode:
authorBenjamin Wright <benwright@webrtc.org>2019-03-14 14:39:02 -0700
committerCommit Bot <commit-bot@chromium.org>2019-03-15 00:43:12 +0000
commit8965fbc542246c5a234e525c65aea8247395798b (patch)
tree19ae3b26fb319008eb6a1cf1e63dea573d297335 /common_audio
parentc6fa6d9cc43369a816099be7971a0d2ae7b9d855 (diff)
downloadwebrtc-8965fbc542246c5a234e525c65aea8247395798b.tar.gz
ClangTidy fixes for common_audio/
These are manual edits please verify there are no typos. Feel free to auto-submit if there are no issues. Bug: webrtc:10410 Change-Id: If995d9d9d21534d3c66a1e7c1fc1c62569766f40 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127627 Commit-Queue: Benjamin Wright <benwright@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27138}
Diffstat (limited to 'common_audio')
-rw-r--r--common_audio/audio_converter.cc2
-rw-r--r--common_audio/sparse_fir_filter.cc2
-rw-r--r--common_audio/wav_header.cc2
3 files changed, 2 insertions, 4 deletions
diff --git a/common_audio/audio_converter.cc b/common_audio/audio_converter.cc
index c560346e99..485ec80c56 100644
--- a/common_audio/audio_converter.cc
+++ b/common_audio/audio_converter.cc
@@ -20,8 +20,6 @@
#include "rtc_base/checks.h"
#include "rtc_base/numerics/safe_conversions.h"
-using rtc::checked_cast;
-
namespace webrtc {
class CopyConverter : public AudioConverter {
diff --git a/common_audio/sparse_fir_filter.cc b/common_audio/sparse_fir_filter.cc
index 0fc032722e..772eb82e47 100644
--- a/common_audio/sparse_fir_filter.cc
+++ b/common_audio/sparse_fir_filter.cc
@@ -45,7 +45,7 @@ void SparseFIRFilter::Filter(const float* in, size_t length, float* out) {
}
// Update current state.
- if (state_.size() > 0u) {
+ if (!state_.empty()) {
if (length >= state_.size()) {
std::memcpy(&state_[0], &in[length - state_.size()],
state_.size() * sizeof(*in));
diff --git a/common_audio/wav_header.cc b/common_audio/wav_header.cc
index e49b7489b2..9d602e9a01 100644
--- a/common_audio/wav_header.cc
+++ b/common_audio/wav_header.cc
@@ -122,7 +122,7 @@ void FindWaveChunk(ChunkHeader* chunk_header,
if (!readable->SeekForward(chunk_header->Size))
return; // EOF or error.
}
- return; // EOF.
+ // EOF.
}
bool ReadFmtChunkData(FmtSubchunk* fmt_subchunk, ReadableWav* readable) {