diff options
| author | Per Kjellander <perkj@webrtc.org> | 2018-01-10 15:54:53 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2018-01-10 15:55:04 +0000 |
| commit | a7f2d84ad12cbdf41becc980a7dba03322dd5a4e (patch) | |
| tree | 91cae77a5339de9ee1622075f0544c28f27d034b /common_audio | |
| parent | 0e6d2f5118fc0605773e63c7aeea127b30239510 (diff) | |
| download | webrtc-a7f2d84ad12cbdf41becc980a7dba03322dd5a4e.tar.gz | |
Revert "Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*"""
This reverts commit c73e1f437889d882cbf2987f7fb3a029a6150613.
Reason for revert:
The problem with failed deps in chrome content/renderer had already been fixed in https://webrtc-review.googlesource.com/c/src/+/38660
Original change's description:
> Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""
>
> This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.
>
> Reason for revert:
>
> Breaks Chrome FYI:
>
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
> -> returned 1
> ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
> static_library(target_name) {
> ^----------------------------
> The item //content/renderer:renderer
> can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
> because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
> //third_party/webrtc/*
> //third_party/webrtc_overrides/*
> ]
>
> https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
>
> Original change's description:
> > GN rtc_* templates: Set default visibility to webrtc_root + "/*"
> >
> > This means that by default, targets are visible to everything under
> > the WebRTC root, but not visible to anything else.
> >
> > API targets are manually tagged with visibility "*", so that targets
> > outside the WebRTC tree can see them.
> >
> > BUG=webrtc:8254
> >
> > Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509
> > Reviewed-on: https://webrtc-review.googlesource.com/24140
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#21548}
>
> TBR=mbonadei@webrtc.org,kwiberg@webrtc.org
>
> Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8254
> Reviewed-on: https://webrtc-review.googlesource.com/38760
> Reviewed-by: Per Kjellander <perkj@webrtc.org>
> Commit-Queue: Per Kjellander <perkj@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21555}
TBR=mbonadei@webrtc.org,kwiberg@webrtc.org,perkj@webrtc.org
Change-Id: I6f720078ce21bd172e0a6471bae8c4c011e4a657
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38860
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21558}
Diffstat (limited to 'common_audio')
| -rw-r--r-- | common_audio/BUILD.gn | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/common_audio/BUILD.gn b/common_audio/BUILD.gn index 27287ec966..34cdddc803 100644 --- a/common_audio/BUILD.gn +++ b/common_audio/BUILD.gn @@ -107,7 +107,7 @@ rtc_static_library("common_audio") { } rtc_source_set("mock_common_audio") { - visibility += [ "*" ] + visibility += webrtc_default_visibility testonly = true sources = [ "mocks/mock_smoothing_filter.h", @@ -263,14 +263,14 @@ rtc_source_set("sinc_resampler") { } rtc_source_set("fir_filter") { - visibility += [ "*" ] + visibility += webrtc_default_visibility sources = [ "fir_filter.h", ] } rtc_source_set("fir_filter_factory") { - visibility += [ "*" ] + visibility += webrtc_default_visibility sources = [ "fir_filter_c.cc", "fir_filter_c.h", @@ -398,7 +398,7 @@ if (rtc_build_with_neon) { if (rtc_include_tests) { rtc_test("common_audio_unittests") { - visibility += [ "*" ] + visibility += webrtc_default_visibility testonly = true sources = [ |