diff options
author | Danil Chapovalov <danilchap@webrtc.org> | 2019-06-26 15:49:47 +0200 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-06-27 10:03:22 +0000 |
commit | 4ba04b77402278cc2520e55315e3be8d95bc018f (patch) | |
tree | eba1369fd990110972ec01edbb244a4a4f7e5c53 /logging | |
parent | 36c8ef625ee8f3f86963988064c69aff6eb2c32b (diff) | |
download | webrtc-4ba04b77402278cc2520e55315e3be8d95bc018f.tar.gz |
Delete RtcEventLogFactory factory as now unused
Bug: webrtc:10206, webrtc:10284
Change-Id: I34fa780f566b52e375ec625bf0d5d02c505d9912
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143782
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28400}
Diffstat (limited to 'logging')
-rw-r--r-- | logging/BUILD.gn | 20 | ||||
-rw-r--r-- | logging/rtc_event_log/rtc_event_log_factory.cc | 22 | ||||
-rw-r--r-- | logging/rtc_event_log/rtc_event_log_factory.h | 25 | ||||
-rw-r--r-- | logging/rtc_event_log/rtc_event_log_unittest.cc | 2 |
4 files changed, 2 insertions, 67 deletions
diff --git a/logging/BUILD.gn b/logging/BUILD.gn index ca1d2c9eba..9e0b82e65a 100644 --- a/logging/BUILD.gn +++ b/logging/BUILD.gn @@ -19,7 +19,6 @@ group("logging") { deps = [ ":rtc_event_audio", ":rtc_event_bwe", - ":rtc_event_log_impl_base", ":rtc_event_log_impl_encoder", ":rtc_event_pacing", ":rtc_event_rtp_rtcp", @@ -266,23 +265,6 @@ if (rtc_enable_protobuf) { } } -rtc_static_library("rtc_event_log_impl_base") { - # TODO(bugs.webrtc.org/10206): Remove this target when all users switch to - # using target api/rtc_event_log:rtc_event_log_factory directly. - visibility = [ "*" ] - sources = [ - "rtc_event_log/rtc_event_log_factory.cc", - "rtc_event_log/rtc_event_log_factory.h", - ] - - deps = [ - "../api/rtc_event_log", - "../api/rtc_event_log:rtc_event_log_factory", - "../api/task_queue:global_task_queue_factory", - "//third_party/abseil-cpp/absl/memory", - ] -} - rtc_source_set("fake_rtc_event_log") { testonly = true sources = [ @@ -380,7 +362,6 @@ if (rtc_enable_protobuf) { ":rtc_event_generic_packet_events", ":rtc_event_log2_proto", ":rtc_event_log_api", - ":rtc_event_log_impl_base", ":rtc_event_log_impl_encoder", ":rtc_event_log_parser", ":rtc_event_log_proto", @@ -392,6 +373,7 @@ if (rtc_enable_protobuf) { "../api:libjingle_peerconnection_api", "../api:rtc_event_log_output_file", "../api:rtp_headers", + "../api/rtc_event_log:rtc_event_log_factory", "../api/task_queue:default_task_queue_factory", "../call", "../call:call_interfaces", diff --git a/logging/rtc_event_log/rtc_event_log_factory.cc b/logging/rtc_event_log/rtc_event_log_factory.cc deleted file mode 100644 index ff6e4e549a..0000000000 --- a/logging/rtc_event_log/rtc_event_log_factory.cc +++ /dev/null @@ -1,22 +0,0 @@ -/* - * Copyright 2017 The WebRTC project authors. All Rights Reserved. - * - * Use of this source code is governed by a BSD-style license - * that can be found in the LICENSE file in the root of the source - * tree. An additional intellectual property rights grant can be found - * in the file PATENTS. All contributing project authors may - * be found in the AUTHORS file in the root of the source tree. - */ - -#include "logging/rtc_event_log/rtc_event_log_factory.h" - -#include "absl/memory/memory.h" -#include "api/task_queue/global_task_queue_factory.h" - -namespace webrtc { - -std::unique_ptr<RtcEventLogFactoryInterface> CreateRtcEventLogFactory() { - return absl::make_unique<RtcEventLogFactory>(&GlobalTaskQueueFactory()); -} - -} // namespace webrtc diff --git a/logging/rtc_event_log/rtc_event_log_factory.h b/logging/rtc_event_log/rtc_event_log_factory.h deleted file mode 100644 index 63b1b609c3..0000000000 --- a/logging/rtc_event_log/rtc_event_log_factory.h +++ /dev/null @@ -1,25 +0,0 @@ -/* - * Copyright 2017 The WebRTC project authors. All Rights Reserved. - * - * Use of this source code is governed by a BSD-style license - * that can be found in the LICENSE file in the root of the source - * tree. An additional intellectual property rights grant can be found - * in the file PATENTS. All contributing project authors may - * be found in the AUTHORS file in the root of the source tree. - */ - -#ifndef LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_ -#define LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_ - -#include <memory> - -#include "api/rtc_event_log/rtc_event_log_factory.h" -#include "api/rtc_event_log/rtc_event_log_factory_interface.h" - -namespace webrtc { - -// TODO(bugs.webrtc.org/10284): Stop using the RtcEventLogFactory factory. -std::unique_ptr<RtcEventLogFactoryInterface> CreateRtcEventLogFactory(); -} // namespace webrtc - -#endif // LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_FACTORY_H_ diff --git a/logging/rtc_event_log/rtc_event_log_unittest.cc b/logging/rtc_event_log/rtc_event_log_unittest.cc index 896a76df66..4d01dad9d4 100644 --- a/logging/rtc_event_log/rtc_event_log_unittest.cc +++ b/logging/rtc_event_log/rtc_event_log_unittest.cc @@ -18,6 +18,7 @@ #include <vector> #include "absl/memory/memory.h" +#include "api/rtc_event_log/rtc_event_log_factory.h" #include "api/rtc_event_log_output_file.h" #include "api/task_queue/default_task_queue_factory.h" #include "logging/rtc_event_log/events/rtc_event_audio_network_adaptation.h" @@ -41,7 +42,6 @@ #include "logging/rtc_event_log/events/rtc_event_video_receive_stream_config.h" #include "logging/rtc_event_log/events/rtc_event_video_send_stream_config.h" #include "logging/rtc_event_log/rtc_event_log.h" -#include "logging/rtc_event_log/rtc_event_log_factory.h" #include "logging/rtc_event_log/rtc_event_log_parser.h" #include "logging/rtc_event_log/rtc_event_log_unittest_helper.h" #include "logging/rtc_event_log/rtc_stream_config.h" |