diff options
author | Mirko Bonadei <mbonadei@webrtc.org> | 2022-02-07 09:54:08 +0000 |
---|---|---|
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-02-07 10:24:45 +0000 |
commit | c1fd46f8798aa8a167a6e1f8795e88595db61847 (patch) | |
tree | 54b8445527f0bf063ce8d229907d60246dc23e8d /logging | |
parent | e79f85c10e98f3a43570d8017321842aaf4165bf (diff) | |
download | webrtc-c1fd46f8798aa8a167a6e1f8795e88595db61847.tar.gz |
Revert "Mark all bool conversion operators as explicit"
This reverts commit 325789c4576b60147ee1ef225d438cbb740f65ff.
Reason for revert: Breaks downstream clients.
Original change's description:
> Mark all bool conversion operators as explicit
>
> An explicit bool conversion operator will still be used implicitly
> when an expression appears in "bool context", e.g., as the condition
> in an if statement, or as argument to logical operators. The
> `explicit` annotation prevents conversion in other contexts, e.g.,
> converting both a and b to bool in an expression like `a == b`.
>
> Bug: None
> Change-Id: I79ef35b1ea831e6011ae472900375ae8a3e617ab
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250664
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#35927}
TBR=mbonadei@webrtc.org,nisse@webrtc.org,tommi@webrtc.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I392cd0c7bd96c90e0db20831864418adb7d58bc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251080
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35929}
Diffstat (limited to 'logging')
-rw-r--r-- | logging/rtc_event_log/events/rtc_event_field_encoding_parser.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/logging/rtc_event_log/events/rtc_event_field_encoding_parser.h b/logging/rtc_event_log/events/rtc_event_field_encoding_parser.h index d3719e575e..6b0270b127 100644 --- a/logging/rtc_event_log/events/rtc_event_field_encoding_parser.h +++ b/logging/rtc_event_log/events/rtc_event_field_encoding_parser.h @@ -36,9 +36,7 @@ class RtcEventLogParseStatus { } bool ok() const { return error_.empty(); } - ABSL_DEPRECATED("Use ok() instead") explicit operator bool() const { - return ok(); - } + ABSL_DEPRECATED("Use ok() instead") operator bool() const { return ok(); } std::string message() const { return error_; } |