diff options
| author | Victor Boivie <boivie@webrtc.org> | 2021-09-20 20:00:57 +0200 |
|---|---|---|
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-09-22 07:17:29 +0000 |
| commit | f72c06419fe82e78fb6221a990d196cdda95a403 (patch) | |
| tree | 944763dc9fcc6dc466c1798131a65051e93987f2 /media/sctp | |
| parent | 7a9aa356d3b88d64f9c76f3820bdf17408f860e3 (diff) | |
| download | webrtc-f72c06419fe82e78fb6221a990d196cdda95a403.tar.gz | |
sctp: dcsctp: Manage lifecycle explicitly
Prior to this commit, the SCTP association could terminate due to too
many retransmission attempts when there is a long duration of packet
loss. The RTCPeerConnection wouldn't terminate, and when the network
later recovers (possibly using a different ICE candidate), it would be a
RTCPeerConnection with media, but without DataChannels.
This commit will make the dcSCTP library never abort by itself when
there are too many retransmissions. It will also put a cap on the retry
duration so that it will do a retry every three seconds (or lower).
Bug: webrtc:13129
Change-Id: I08162ea20d6a60aa0eae2717966d9a2ddba8fc22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232540
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35061}
Diffstat (limited to 'media/sctp')
| -rw-r--r-- | media/sctp/dcsctp_transport.cc | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/media/sctp/dcsctp_transport.cc b/media/sctp/dcsctp_transport.cc index 49cb4ef042..b6038b2e2f 100644 --- a/media/sctp/dcsctp_transport.cc +++ b/media/sctp/dcsctp_transport.cc @@ -37,6 +37,13 @@ namespace webrtc { namespace { using ::dcsctp::SendPacketStatus; +// When there is packet loss for a long time, the SCTP retry timers will use +// exponential backoff, which can grow to very long durations and when the +// connection recovers, it may take a long time to reach the new backoff +// duration. By limiting it to a reasonable limit, the time to recover reduces. +constexpr dcsctp::DurationMs kMaxTimerBackoffDuration = + dcsctp::DurationMs(3000); + enum class WebrtcPPID : dcsctp::PPID::UnderlyingType { // https://www.rfc-editor.org/rfc/rfc8832.html#section-8.1 kDCEP = 50, @@ -156,6 +163,10 @@ bool DcSctpTransport::Start(int local_sctp_port, options.local_port = local_sctp_port; options.remote_port = remote_sctp_port; options.max_message_size = max_message_size; + options.max_timer_backoff_duration = kMaxTimerBackoffDuration; + // Don't close the connection automatically on too many retransmissions. + options.max_retransmissions = absl::nullopt; + options.max_init_retransmits = absl::nullopt; std::unique_ptr<dcsctp::PacketObserver> packet_observer; if (RTC_LOG_CHECK_LEVEL(LS_VERBOSE)) { |