diff options
author | Danil Chapovalov <danilchap@webrtc.org> | 2020-05-19 13:20:27 +0200 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-05-25 08:46:30 +0000 |
commit | f2c0f15282a7e3cba8dbd2e3e71f4f0d15ebc7bd (patch) | |
tree | e13fe4ec2d05698e0484098e9f826c12417dc142 /media | |
parent | b85889d6d5faa751e8c71180166b4eb19d91151e (diff) | |
download | webrtc-f2c0f15282a7e3cba8dbd2e3e71f4f0d15ebc7bd.tar.gz |
In media/ and modules/video_coding replace mock macros with unified MOCK_METHOD macro
Bug: webrtc:11564
Change-Id: I5c7f5dc99e62619403ed726c23201ab4fbd37cbe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175647
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31340}
Diffstat (limited to 'media')
-rw-r--r-- | media/base/media_engine_unittest.cc | 6 | ||||
-rw-r--r-- | media/engine/simulcast_encoder_adapter_unittest.cc | 20 | ||||
-rw-r--r-- | media/engine/webrtc_video_engine_unittest.cc | 14 |
3 files changed, 24 insertions, 16 deletions
diff --git a/media/base/media_engine_unittest.cc b/media/base/media_engine_unittest.cc index f4c6f5f045..83f80c4669 100644 --- a/media/base/media_engine_unittest.cc +++ b/media/base/media_engine_unittest.cc @@ -26,8 +26,10 @@ namespace { class MockRtpHeaderExtensionQueryInterface : public RtpHeaderExtensionQueryInterface { public: - MOCK_CONST_METHOD0(GetRtpHeaderExtensions, - std::vector<RtpHeaderExtensionCapability>()); + MOCK_METHOD(std::vector<RtpHeaderExtensionCapability>, + GetRtpHeaderExtensions, + (), + (const, override)); }; } // namespace diff --git a/media/engine/simulcast_encoder_adapter_unittest.cc b/media/engine/simulcast_encoder_adapter_unittest.cc index b467c49166..075cb83ee9 100644 --- a/media/engine/simulcast_encoder_adapter_unittest.cc +++ b/media/engine/simulcast_encoder_adapter_unittest.cc @@ -199,8 +199,10 @@ class MockVideoEncoder : public VideoEncoder { video_format_("unknown"), callback_(nullptr) {} - MOCK_METHOD1(SetFecControllerOverride, - void(FecControllerOverride* fec_controller_override)); + MOCK_METHOD(void, + SetFecControllerOverride, + (FecControllerOverride * fec_controller_override), + (override)); // TODO(nisse): Valid overrides commented out, because the gmock // methods don't use any override declarations, and we want to avoid @@ -212,10 +214,11 @@ class MockVideoEncoder : public VideoEncoder { return init_encode_return_value_; } - MOCK_METHOD2( - Encode, - int32_t(const VideoFrame& inputImage, - const std::vector<VideoFrameType>* frame_types) /* override */); + MOCK_METHOD(int32_t, + Encode, + (const VideoFrame& inputImage, + const std::vector<VideoFrameType>* frame_types), + (override)); int32_t RegisterEncodeCompleteCallback( EncodedImageCallback* callback) override { @@ -223,7 +226,7 @@ class MockVideoEncoder : public VideoEncoder { return 0; } - MOCK_METHOD0(Release, int32_t() /* override */); + MOCK_METHOD(int32_t, Release, (), (override)); void SetRates(const RateControlParameters& parameters) { last_set_rates_ = parameters; @@ -334,8 +337,7 @@ std::vector<SdpVideoFormat> MockVideoEncoderFactory::GetSupportedFormats() std::unique_ptr<VideoEncoder> MockVideoEncoderFactory::CreateVideoEncoder( const SdpVideoFormat& format) { - std::unique_ptr<MockVideoEncoder> encoder( - new ::testing::NiceMock<MockVideoEncoder>(this)); + auto encoder = std::make_unique<::testing::NiceMock<MockVideoEncoder>>(this); encoder->set_init_encode_return_value(init_encode_return_value_); const char* encoder_name = encoder_names_.empty() ? "codec_implementation_name" diff --git a/media/engine/webrtc_video_engine_unittest.cc b/media/engine/webrtc_video_engine_unittest.cc index ce36073449..1b839e932a 100644 --- a/media/engine/webrtc_video_engine_unittest.cc +++ b/media/engine/webrtc_video_engine_unittest.cc @@ -209,11 +209,15 @@ int GetMaxDefaultBitrateBps(size_t width, size_t height) { class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> { public: - MOCK_METHOD2(AddOrUpdateSink, - void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink, - const rtc::VideoSinkWants& wants)); - MOCK_METHOD1(RemoveSink, - void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink)); + MOCK_METHOD(void, + AddOrUpdateSink, + (rtc::VideoSinkInterface<webrtc::VideoFrame> * sink, + const rtc::VideoSinkWants& wants), + (override)); + MOCK_METHOD(void, + RemoveSink, + (rtc::VideoSinkInterface<webrtc::VideoFrame> * sink), + (override)); }; } // namespace |