diff options
author | Patrik Höglund <phoglund@webrtc.org> | 2020-03-27 13:05:08 +0000 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-03-27 13:05:34 +0000 |
commit | 36b35d528cfcd3428cd3b52f73799523af6f4da5 (patch) | |
tree | c1c24cd977acd17576bce39bf6c34a7554d18b74 /modules/audio_coding | |
parent | d59805b3fb331bdaf3ab1c1f3371a27451d3020b (diff) | |
download | webrtc-36b35d528cfcd3428cd3b52f73799523af6f4da5.tar.gz |
Reland "Flip histograms to true by default, fix unit in isac_fix_test."
This reverts commit c59a3049016f697e05437b91ae494c40cede3506.
Reason for revert: Other perf tests greening up, can now land this
Original change's description:
> Revert "Flip histograms to true by default, fix unit in isac_fix_test."
>
> This reverts commit 7b201012bc7f7cd95249b8314d0d7ebabe966d8b.
>
> Reason for revert: Seems to work, but need to get low bw tests working first
>
> Original change's description:
> > Flip histograms to true by default, fix unit in isac_fix_test.
> >
> > Requires downstream changes for all WebRTC perf tests, and
> > a corresponding recipe change so isac_fix_test starts using the new
> > flow.
> >
> > Bug: chromium:1029452
> > Change-Id: I8918fca9bef003d365037c1c6bf7c55747dfed99
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170633
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#30906}
>
> TBR=phoglund@webrtc.org,mbonadei@webrtc.org
>
> Change-Id: I96c2309cd71be14c5a27b515736a32f1b256453c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1029452
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171865
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#30913}
TBR=phoglund@webrtc.org,mbonadei@webrtc.org
Change-Id: If39500beeca74b8e0ed9e97724a55529125a2253
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029452
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171876
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30920}
Diffstat (limited to 'modules/audio_coding')
-rw-r--r-- | modules/audio_coding/codecs/isac/fix/test/kenny.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/modules/audio_coding/codecs/isac/fix/test/kenny.cc b/modules/audio_coding/codecs/isac/fix/test/kenny.cc index a0a2dca118..4b431cfdf9 100644 --- a/modules/audio_coding/codecs/isac/fix/test/kenny.cc +++ b/modules/audio_coding/codecs/isac/fix/test/kenny.cc @@ -105,7 +105,7 @@ TEST(IsacFixTest, Kenny) { FILE *inp, *outp, *f_bn, *outbits; int endfile; - const char* chartjson_result_file = NULL; + const char* perf_result_file = NULL; int i; int errtype, h = 0, k, packetLossPercent = 0; @@ -459,7 +459,7 @@ TEST(IsacFixTest, Kenny) { printf("Expected --isolated_script_test_perf_output=/some/filename\n"); exit(1); } - chartjson_result_file = filename_start + 1; + perf_result_file = filename_start + 1; } } @@ -858,10 +858,10 @@ TEST(IsacFixTest, Kenny) { // Record the results with Perf test tools. webrtc::test::PrintResult("isac", "", "time_per_10ms_frame", - (runtime * 10000) / length_file, "us", false); + (runtime * 10) / length_file, "ms", false); - if (chartjson_result_file) { - EXPECT_TRUE(webrtc::test::WritePerfResults(chartjson_result_file)); + if (perf_result_file) { + EXPECT_TRUE(webrtc::test::WritePerfResults(perf_result_file)); } fclose(inp); |