diff options
| author | Lahiru Ginnaliya Gamathige <glahiru@webrtc.org> | 2020-10-08 13:55:10 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-09 03:06:34 +0000 |
| commit | c5f71087589b18bb4df1b78f2c452c4083edf2d9 (patch) | |
| tree | 6c2cad299d52cf8109a484473f564edbe481cea3 /p2p/base/dtls_transport_internal.h | |
| parent | 0591fbb0314d64c0e3f0af91ceb20999e8c8e15b (diff) | |
| download | webrtc-c5f71087589b18bb4df1b78f2c452c4083edf2d9.tar.gz | |
Reland "Replace sigslot usages with robocaller library."
This is a reland of 40261c3663fe316cfe40262c59cee993165ccf63
Note: Instead of changing the type of JsepTransportController->SignalSSLHandshakeError
added a new member with a different name and used it in webrtc code.
After this change do two more follow up CLs to completely remove the old code
from google3.
Original change's description:
> Replace sigslot usages with robocaller library.
>
> - Replace all the top level signals from jsep_transport_controller.
> - There are still sigslot usages in this file so keep the inheritance
> and that is the reason for not having a binary size gain in this CL.
>
> Bug: webrtc:11943
> Change-Id: I249d3b9710783aef70ba273e082ceeafe3056898
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185540
> Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32321}
Bug: webrtc:11943
Change-Id: Ia07394ee395f94836f6b576c3a97d119a7678e1a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186946
Commit-Queue: Lahiru Ginnaliya Gamathige <glahiru@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32359}
Diffstat (limited to 'p2p/base/dtls_transport_internal.h')
| -rw-r--r-- | p2p/base/dtls_transport_internal.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/p2p/base/dtls_transport_internal.h b/p2p/base/dtls_transport_internal.h index 4c35d7371f..f4ca1cb36f 100644 --- a/p2p/base/dtls_transport_internal.h +++ b/p2p/base/dtls_transport_internal.h @@ -23,6 +23,7 @@ #include "p2p/base/ice_transport_internal.h" #include "p2p/base/packet_transport_internal.h" #include "rtc_base/constructor_magic.h" +#include "rtc_base/robo_caller.h" #include "rtc_base/ssl_certificate.h" #include "rtc_base/ssl_fingerprint.h" #include "rtc_base/ssl_stream_adapter.h" @@ -115,7 +116,9 @@ class DtlsTransportInternal : public rtc::PacketTransportInternal { sigslot::signal2<DtlsTransportInternal*, DtlsTransportState> SignalDtlsState; // Emitted whenever the Dtls handshake failed on some transport channel. + // TODO(bugs.webrtc.org/11943): Remove sigslot and use one variable. sigslot::signal1<rtc::SSLHandshakeError> SignalDtlsHandshakeError; + webrtc::RoboCaller<rtc::SSLHandshakeError> DtlsHandshakeErrorSignal; protected: DtlsTransportInternal(); |