diff options
| author | Yura Yaroshevich <yura.yaroshevich@gmail.com> | 2021-04-12 15:56:08 +0300 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-04-12 15:12:39 +0000 |
| commit | 9ff75a6206142fbe17997bb092f8ec5485c2a084 (patch) | |
| tree | 15c69d33bb3002d32990552d9c69afae4f6bf8be /p2p | |
| parent | 3928e8fdb198c51eb95894f12c12f20fcb10b73a (diff) | |
| download | webrtc-9ff75a6206142fbe17997bb092f8ec5485c2a084.tar.gz | |
Add addr in error msg if stun sock sent with error
Before:
```
(stun_port.cc:596): sendto : [0x00000041] No route to host
```
After:
```
(stun_port.cc:598): UDP send of 20 bytes to host stun1.l.google.com:19302 (74.125.200.127:19302) failed with error 65 : [0x00000041] No route to host
```
Bug: None
Change-Id: Ibcd487e97b37677225814562df30af66f655cddb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215000
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/master@{#33694}
Diffstat (limited to 'p2p')
| -rw-r--r-- | p2p/base/stun_port.cc | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/p2p/base/stun_port.cc b/p2p/base/stun_port.cc index 7a76af5fa1..7b1a2a83a2 100644 --- a/p2p/base/stun_port.cc +++ b/p2p/base/stun_port.cc @@ -306,7 +306,9 @@ int UDPPort::SendTo(const void* data, if (send_error_count_ < kSendErrorLogLimit) { ++send_error_count_; RTC_LOG(LS_ERROR) << ToString() << ": UDP send of " << size - << " bytes failed with error " << error_; + << " bytes to host " << addr.ToSensitiveString() << " (" + << addr.ToResolvedSensitiveString() + << ") failed with error " << error_; } } else { send_error_count_ = 0; @@ -593,7 +595,11 @@ void UDPPort::OnSendPacket(const void* data, size_t size, StunRequest* req) { options.info_signaled_after_sent.packet_type = rtc::PacketType::kStunMessage; CopyPortInformationToPacketInfo(&options.info_signaled_after_sent); if (socket_->SendTo(data, size, sreq->server_addr(), options) < 0) { - RTC_LOG_ERR_EX(LERROR, socket_->GetError()) << "sendto"; + RTC_LOG_ERR_EX(LERROR, socket_->GetError()) + << "UDP send of " << size << " bytes to host " + << sreq->server_addr().ToSensitiveString() << " (" + << sreq->server_addr().ToResolvedSensitiveString() + << ") failed with error " << error_; } stats_.stun_binding_requests_sent++; } |