aboutsummaryrefslogtreecommitdiff
path: root/pc
diff options
context:
space:
mode:
authorJohannes Kron <kron@webrtc.org>2020-01-23 13:10:44 +0000
committerCommit Bot <commit-bot@chromium.org>2020-01-23 13:10:53 +0000
commit00a30873c415d717af8dcdf21c2df7fd4b6d1ed2 (patch)
tree3d5b6bd128b2f45daa25b45a6934e19654a6baca /pc
parent897776e36c2510e5d5dc77746bce25106146666f (diff)
downloadwebrtc-00a30873c415d717af8dcdf21c2df7fd4b6d1ed2.tar.gz
Revert "Reland "Distinguish between send and receive codecs""
This reverts commit 133bf2bd28596aab5c7684e0ea3da99b1fece77f. Reason for revert: Breaks Chromium import due to flaky test in Chromium. Original change's description: > Reland "Distinguish between send and receive codecs" > > This reverts commit e57b266a20334e47f105a0bd777190ec8c6562e8. > > Reason for revert: Fixed negotiation of send-only clients. > > Original change's description: > > Revert "Distinguish between send and receive codecs" > > > > This reverts commit c0f25cf762a6946666c812f7a3df3f0a7f98b38d. > > > > Reason for revert: breaks negotiation with send-only clients > > > > (webrtc_video_engine.cc:985): SetRecvParameters called with unsupported video codec: VideoCodec[96:H264] > > (peer_connection.cc:6043): Failed to set local video description recv parameters. (INVALID_PARAMETER) > > (peer_connection.cc:2591): Failed to set local offer sdp: Failed to set local video description recv parameters. > > > > Original change's description: > > > Distinguish between send and receive codecs > > > > > > Even though send and receive codecs may be the same, they might have > > > different support in HW. Distinguish between send and receive codecs > > > to be able to keep track of which codecs have HW support. > > > > > > Bug: chromium:1029737 > > > Change-Id: Id119560becadfe0aaf861c892a6485f1c2eb378d > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165763 > > > Commit-Queue: Johannes Kron <kron@webrtc.org> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#30284} > > > > TBR=steveanton@webrtc.org,kron@webrtc.org > > > > Change-Id: Iacb7059436b2313b52577b65f164ee363c4816aa > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:1029737 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166420 > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Commit-Queue: Steve Anton <steveanton@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30292} > > TBR=steveanton@webrtc.org,kron@webrtc.org > > > Bug: chromium:1029737 > Change-Id: I287efcfdcd1c9a3f2c410aeec8fe26a84204d1fd > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166604 > Reviewed-by: Johannes Kron <kron@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Commit-Queue: Johannes Kron <kron@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30348} TBR=steveanton@webrtc.org,kron@webrtc.org Change-Id: I9f8731309749e07ce7e651e1550ecfabddb1735f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1029737 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167205 Reviewed-by: Johannes Kron <kron@webrtc.org> Commit-Queue: Johannes Kron <kron@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30360}
Diffstat (limited to 'pc')
-rw-r--r--pc/channel.cc39
-rw-r--r--pc/channel_manager.cc21
-rw-r--r--pc/channel_manager.h3
-rw-r--r--pc/channel_manager_unittest.cc27
-rw-r--r--pc/media_session.cc168
-rw-r--r--pc/media_session.h21
-rw-r--r--pc/media_session_unittest.cc72
-rw-r--r--pc/peer_connection_factory.cc4
-rw-r--r--pc/peer_connection_integrationtest.cc166
-rw-r--r--pc/peer_connection_media_unittest.cc10
-rw-r--r--pc/rtp_transceiver.cc182
11 files changed, 234 insertions, 479 deletions
diff --git a/pc/channel.cc b/pc/channel.cc
index e3f13e27b1..d6f884ce5e 100644
--- a/pc/channel.cc
+++ b/pc/channel.cc
@@ -993,8 +993,7 @@ bool VideoChannel::SetLocalContent_w(const MediaContentDescription* content,
VideoSendParameters send_params = last_send_params_;
bool needs_send_params_update = false;
- if ((type == SdpType::kAnswer || type == SdpType::kPrAnswer) &&
- webrtc::RtpTransceiverDirectionHasSend(video->direction())) {
+ if (type == SdpType::kAnswer || type == SdpType::kPrAnswer) {
for (auto& send_codec : send_params.codecs) {
auto* recv_codec = FindMatchingCodec(recv_params.codecs, send_codec);
if (recv_codec) {
@@ -1011,13 +1010,13 @@ bool VideoChannel::SetLocalContent_w(const MediaContentDescription* content,
}
}
- if (webrtc::RtpTransceiverDirectionHasRecv(video->direction())) {
- if (!media_channel()->SetRecvParameters(recv_params)) {
- SafeSetError("Failed to set local video description recv parameters.",
- error_desc);
- return false;
- }
+ if (!media_channel()->SetRecvParameters(recv_params)) {
+ SafeSetError("Failed to set local video description recv parameters.",
+ error_desc);
+ return false;
+ }
+ if (webrtc::RtpTransceiverDirectionHasRecv(video->direction())) {
for (const VideoCodec& codec : video->codecs()) {
AddHandledPayloadType(codec.id);
}
@@ -1026,11 +1025,11 @@ bool VideoChannel::SetLocalContent_w(const MediaContentDescription* content,
RTC_LOG(LS_ERROR) << "Failed to set up video demuxing.";
return false;
}
- last_recv_params_ = recv_params;
}
+ last_recv_params_ = recv_params;
+
if (needs_send_params_update) {
- RTC_DCHECK(webrtc::RtpTransceiverDirectionHasSend(video->direction()));
if (!media_channel()->SetSendParameters(send_params)) {
SafeSetError("Failed to set send parameters.", error_desc);
return false;
@@ -1080,10 +1079,7 @@ bool VideoChannel::SetRemoteContent_w(const MediaContentDescription* content,
VideoRecvParameters recv_params = last_recv_params_;
bool needs_recv_params_update = false;
- // Require SEND direction for receive parameters since we're in
- // SetRemoteContent_w.
- if ((type == SdpType::kAnswer || type == SdpType::kPrAnswer) &&
- webrtc::RtpTransceiverDirectionHasSend(video->direction())) {
+ if (type == SdpType::kAnswer || type == SdpType::kPrAnswer) {
for (auto& recv_codec : recv_params.codecs) {
auto* send_codec = FindMatchingCodec(send_params.codecs, recv_codec);
if (send_codec) {
@@ -1100,19 +1096,14 @@ bool VideoChannel::SetRemoteContent_w(const MediaContentDescription* content,
}
}
- // Require RECV direction for send parameters since we're in
- // SetRemoteContent_w.
- if (webrtc::RtpTransceiverDirectionHasRecv(video->direction())) {
- if (!media_channel()->SetSendParameters(send_params)) {
- SafeSetError("Failed to set remote video description send parameters.",
- error_desc);
- return false;
- }
- last_send_params_ = send_params;
+ if (!media_channel()->SetSendParameters(send_params)) {
+ SafeSetError("Failed to set remote video description send parameters.",
+ error_desc);
+ return false;
}
+ last_send_params_ = send_params;
if (needs_recv_params_update) {
- RTC_DCHECK(webrtc::RtpTransceiverDirectionHasSend(video->direction()));
if (!media_channel()->SetRecvParameters(recv_params)) {
SafeSetError("Failed to set recv parameters.", error_desc);
return false;
diff --git a/pc/channel_manager.cc b/pc/channel_manager.cc
index 16814bd493..ce8f473600 100644
--- a/pc/channel_manager.cc
+++ b/pc/channel_manager.cc
@@ -87,31 +87,14 @@ void ChannelManager::GetSupportedAudioRtpHeaderExtensions(
*ext = media_engine_->voice().GetCapabilities().header_extensions;
}
-void ChannelManager::GetSupportedVideoSendCodecs(
+void ChannelManager::GetSupportedVideoCodecs(
std::vector<VideoCodec>* codecs) const {
if (!media_engine_) {
return;
}
codecs->clear();
- std::vector<VideoCodec> video_codecs = media_engine_->video().send_codecs();
- for (const auto& video_codec : video_codecs) {
- if (!enable_rtx_ &&
- absl::EqualsIgnoreCase(kRtxCodecName, video_codec.name)) {
- continue;
- }
- codecs->push_back(video_codec);
- }
-}
-
-void ChannelManager::GetSupportedVideoReceiveCodecs(
- std::vector<VideoCodec>* codecs) const {
- if (!media_engine_) {
- return;
- }
- codecs->clear();
-
- std::vector<VideoCodec> video_codecs = media_engine_->video().recv_codecs();
+ std::vector<VideoCodec> video_codecs = media_engine_->video().codecs();
for (const auto& video_codec : video_codecs) {
if (!enable_rtx_ &&
absl::EqualsIgnoreCase(kRtxCodecName, video_codec.name)) {
diff --git a/pc/channel_manager.h b/pc/channel_manager.h
index f66ad4bfc1..661ab4bbde 100644
--- a/pc/channel_manager.h
+++ b/pc/channel_manager.h
@@ -76,8 +76,7 @@ class ChannelManager final {
void GetSupportedAudioSendCodecs(std::vector<AudioCodec>* codecs) const;
void GetSupportedAudioReceiveCodecs(std::vector<AudioCodec>* codecs) const;
void GetSupportedAudioRtpHeaderExtensions(RtpHeaderExtensions* ext) const;
- void GetSupportedVideoSendCodecs(std::vector<VideoCodec>* codecs) const;
- void GetSupportedVideoReceiveCodecs(std::vector<VideoCodec>* codecs) const;
+ void GetSupportedVideoCodecs(std::vector<VideoCodec>* codecs) const;
void GetSupportedVideoRtpHeaderExtensions(RtpHeaderExtensions* ext) const;
void GetSupportedDataCodecs(std::vector<DataCodec>* codecs) const;
diff --git a/pc/channel_manager_unittest.cc b/pc/channel_manager_unittest.cc
index 6f3128ebde..90785131f9 100644
--- a/pc/channel_manager_unittest.cc
+++ b/pc/channel_manager_unittest.cc
@@ -142,29 +142,22 @@ TEST_F(ChannelManagerTest, StartupShutdownOnThread) {
}
TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
- std::vector<VideoCodec> send_codecs;
- std::vector<VideoCodec> recv_codecs;
+ std::vector<VideoCodec> codecs;
const VideoCodec rtx_codec(96, "rtx");
// By default RTX is disabled.
- cm_->GetSupportedVideoSendCodecs(&send_codecs);
- EXPECT_FALSE(ContainsMatchingCodec(send_codecs, rtx_codec));
- cm_->GetSupportedVideoSendCodecs(&recv_codecs);
- EXPECT_FALSE(ContainsMatchingCodec(recv_codecs, rtx_codec));
+ cm_->GetSupportedVideoCodecs(&codecs);
+ EXPECT_FALSE(ContainsMatchingCodec(codecs, rtx_codec));
// Enable and check.
EXPECT_TRUE(cm_->SetVideoRtxEnabled(true));
- cm_->GetSupportedVideoSendCodecs(&send_codecs);
- EXPECT_TRUE(ContainsMatchingCodec(send_codecs, rtx_codec));
- cm_->GetSupportedVideoSendCodecs(&recv_codecs);
- EXPECT_TRUE(ContainsMatchingCodec(recv_codecs, rtx_codec));
+ cm_->GetSupportedVideoCodecs(&codecs);
+ EXPECT_TRUE(ContainsMatchingCodec(codecs, rtx_codec));
// Disable and check.
EXPECT_TRUE(cm_->SetVideoRtxEnabled(false));
- cm_->GetSupportedVideoSendCodecs(&send_codecs);
- EXPECT_FALSE(ContainsMatchingCodec(send_codecs, rtx_codec));
- cm_->GetSupportedVideoSendCodecs(&recv_codecs);
- EXPECT_FALSE(ContainsMatchingCodec(recv_codecs, rtx_codec));
+ cm_->GetSupportedVideoCodecs(&codecs);
+ EXPECT_FALSE(ContainsMatchingCodec(codecs, rtx_codec));
// Cannot toggle rtx after initialization.
EXPECT_TRUE(cm_->Init());
@@ -174,10 +167,8 @@ TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
// Can set again after terminate.
cm_->Terminate();
EXPECT_TRUE(cm_->SetVideoRtxEnabled(true));
- cm_->GetSupportedVideoSendCodecs(&send_codecs);
- EXPECT_TRUE(ContainsMatchingCodec(send_codecs, rtx_codec));
- cm_->GetSupportedVideoSendCodecs(&recv_codecs);
- EXPECT_TRUE(ContainsMatchingCodec(recv_codecs, rtx_codec));
+ cm_->GetSupportedVideoCodecs(&codecs);
+ EXPECT_TRUE(ContainsMatchingCodec(codecs, rtx_codec));
}
TEST_F(ChannelManagerTest, CreateDestroyChannels) {
diff --git a/pc/media_session.cc b/pc/media_session.cc
index e764101eef..59f140f951 100644
--- a/pc/media_session.cc
+++ b/pc/media_session.cc
@@ -1330,12 +1330,10 @@ MediaSessionDescriptionFactory::MediaSessionDescriptionFactory(
channel_manager->GetSupportedAudioSendCodecs(&audio_send_codecs_);
channel_manager->GetSupportedAudioReceiveCodecs(&audio_recv_codecs_);
channel_manager->GetSupportedAudioRtpHeaderExtensions(&audio_rtp_extensions_);
- channel_manager->GetSupportedVideoSendCodecs(&video_send_codecs_);
- channel_manager->GetSupportedVideoReceiveCodecs(&video_recv_codecs_);
+ channel_manager->GetSupportedVideoCodecs(&video_codecs_);
channel_manager->GetSupportedVideoRtpHeaderExtensions(&video_rtp_extensions_);
channel_manager->GetSupportedDataCodecs(&rtp_data_codecs_);
ComputeAudioCodecsIntersectionAndUnion();
- ComputeVideoCodecsIntersectionAndUnion();
}
const AudioCodecs& MediaSessionDescriptionFactory::audio_sendrecv_codecs()
@@ -1359,27 +1357,6 @@ void MediaSessionDescriptionFactory::set_audio_codecs(
ComputeAudioCodecsIntersectionAndUnion();
}
-const VideoCodecs& MediaSessionDescriptionFactory::video_sendrecv_codecs()
- const {
- return video_sendrecv_codecs_;
-}
-
-const VideoCodecs& MediaSessionDescriptionFactory::video_send_codecs() const {
- return video_send_codecs_;
-}
-
-const VideoCodecs& MediaSessionDescriptionFactory::video_recv_codecs() const {
- return video_recv_codecs_;
-}
-
-void MediaSessionDescriptionFactory::set_video_codecs(
- const VideoCodecs& send_codecs,
- const VideoCodecs& recv_codecs) {
- video_send_codecs_ = send_codecs;
- video_recv_codecs_ = recv_codecs;
- ComputeVideoCodecsIntersectionAndUnion();
-}
-
static void RemoveUnifiedPlanExtensions(RtpHeaderExtensions* extensions) {
RTC_DCHECK(extensions);
@@ -1760,41 +1737,6 @@ const AudioCodecs& MediaSessionDescriptionFactory::GetAudioCodecsForAnswer(
return audio_sendrecv_codecs_;
}
-const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForOffer(
- const RtpTransceiverDirection& direction) const {
- switch (direction) {
- // If stream is inactive - generate list as if sendrecv.
- case RtpTransceiverDirection::kSendRecv:
- case RtpTransceiverDirection::kInactive:
- return video_sendrecv_codecs_;
- case RtpTransceiverDirection::kSendOnly:
- return video_send_codecs_;
- case RtpTransceiverDirection::kRecvOnly:
- return video_recv_codecs_;
- }
- RTC_NOTREACHED();
- return video_sendrecv_codecs_;
-}
-
-const VideoCodecs& MediaSessionDescriptionFactory::GetVideoCodecsForAnswer(
- const RtpTransceiverDirection& offer,
- const RtpTransceiverDirection& answer) const {
- switch (answer) {
- // For inactive and sendrecv answers, generate lists as if we were to accept
- // the offer's direction. See RFC 3264 Section 6.1.
- case RtpTransceiverDirection::kSendRecv:
- case RtpTransceiverDirection::kInactive:
- return GetVideoCodecsForOffer(
- webrtc::RtpTransceiverDirectionReversed(offer));
- case RtpTransceiverDirection::kSendOnly:
- return video_send_codecs_;
- case RtpTransceiverDirection::kRecvOnly:
- return video_recv_codecs_;
- }
- RTC_NOTREACHED();
- return video_sendrecv_codecs_;
-}
-
void MergeCodecsFromDescription(
const std::vector<const ContentInfo*>& current_active_contents,
AudioCodecs* audio_codecs,
@@ -1842,7 +1784,7 @@ void MediaSessionDescriptionFactory::GetCodecsForOffer(
// Add our codecs that are not in the current description.
MergeCodecs<AudioCodec>(all_audio_codecs_, audio_codecs, &used_pltypes);
- MergeCodecs<VideoCodec>(all_video_codecs_, video_codecs, &used_pltypes);
+ MergeCodecs<VideoCodec>(video_codecs_, video_codecs, &used_pltypes);
MergeCodecs<DataCodec>(rtp_data_codecs_, rtp_data_codecs, &used_pltypes);
}
@@ -1890,7 +1832,7 @@ void MediaSessionDescriptionFactory::GetCodecsForAnswer(
if (!FindMatchingCodec<VideoCodec>(video->codecs(),
filtered_offered_video_codecs,
offered_video_codec, nullptr) &&
- FindMatchingCodec<VideoCodec>(video->codecs(), all_video_codecs_,
+ FindMatchingCodec<VideoCodec>(video->codecs(), video_codecs_,
offered_video_codec, nullptr)) {
filtered_offered_video_codecs.push_back(offered_video_codec);
}
@@ -2097,7 +2039,7 @@ bool MediaSessionDescriptionFactory::AddAudioContentForOffer(
IsDtlsActive(current_content, current_description) ? cricket::SEC_DISABLED
: secure();
- auto audio = std::make_unique<AudioContentDescription>();
+ std::unique_ptr<AudioContentDescription> audio(new AudioContentDescription());
std::vector<std::string> crypto_suites;
GetSupportedAudioSdesCryptoSuiteNames(session_options.crypto_options,
&crypto_suites);
@@ -2125,8 +2067,6 @@ bool MediaSessionDescriptionFactory::AddAudioContentForOffer(
return true;
}
-// TODO(kron): This function is very similar to AddAudioContentForOffer.
-// Refactor to reuse shared code.
bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
const MediaDescriptionOptions& media_description_options,
const MediaSessionOptions& session_options,
@@ -2137,10 +2077,14 @@ bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
StreamParamsVec* current_streams,
SessionDescription* desc,
IceCredentialsIterator* ice_credentials) const {
- // Filter video_codecs (which includes all codecs, with correctly remapped
- // payload types) based on transceiver direction.
- const VideoCodecs& supported_video_codecs =
- GetVideoCodecsForOffer(media_description_options.direction);
+ cricket::SecurePolicy sdes_policy =
+ IsDtlsActive(current_content, current_description) ? cricket::SEC_DISABLED
+ : secure();
+
+ std::unique_ptr<VideoContentDescription> video(new VideoContentDescription());
+ std::vector<std::string> crypto_suites;
+ GetSupportedVideoSdesCryptoSuiteNames(session_options.crypto_options,
+ &crypto_suites);
VideoCodecs filtered_codecs;
@@ -2148,7 +2092,7 @@ bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
// Add the codecs from the current transceiver's codec preferences.
// They override any existing codecs from previous negotiations.
filtered_codecs = MatchCodecPreference(
- media_description_options.codec_preferences, supported_video_codecs);
+ media_description_options.codec_preferences, video_codecs_);
} else {
// Add the codecs from current content if it exists and is not rejected nor
// recycled.
@@ -2166,11 +2110,11 @@ bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
}
// Add other supported video codecs.
VideoCodec found_codec;
- for (const VideoCodec& codec : supported_video_codecs) {
- if (FindMatchingCodec<VideoCodec>(supported_video_codecs, video_codecs,
- codec, &found_codec) &&
- !FindMatchingCodec<VideoCodec>(supported_video_codecs,
- filtered_codecs, codec, nullptr)) {
+ for (const VideoCodec& codec : video_codecs_) {
+ if (FindMatchingCodec<VideoCodec>(video_codecs_, video_codecs, codec,
+ &found_codec) &&
+ !FindMatchingCodec<VideoCodec>(video_codecs_, filtered_codecs, codec,
+ nullptr)) {
// Use the |found_codec| from |video_codecs| because it has the
// correctly mapped payload type.
filtered_codecs.push_back(found_codec);
@@ -2186,13 +2130,6 @@ bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
}
}
- cricket::SecurePolicy sdes_policy =
- IsDtlsActive(current_content, current_description) ? cricket::SEC_DISABLED
- : secure();
- auto video = std::make_unique<VideoContentDescription>();
- std::vector<std::string> crypto_suites;
- GetSupportedVideoSdesCryptoSuiteNames(session_options.crypto_options,
- &crypto_suites);
if (!CreateMediaContentOffer(media_description_options, session_options,
filtered_codecs, sdes_policy,
GetCryptos(current_content), crypto_suites,
@@ -2215,7 +2152,6 @@ bool MediaSessionDescriptionFactory::AddVideoContentForOffer(
current_description, desc, ice_credentials)) {
return false;
}
-
return true;
}
@@ -2227,7 +2163,8 @@ bool MediaSessionDescriptionFactory::AddSctpDataContentForOffer(
StreamParamsVec* current_streams,
SessionDescription* desc,
IceCredentialsIterator* ice_credentials) const {
- auto data = std::make_unique<SctpDataContentDescription>();
+ std::unique_ptr<SctpDataContentDescription> data(
+ new SctpDataContentDescription());
bool secure_transport = (transport_desc_factory_->secure() != SEC_DISABLED);
@@ -2273,7 +2210,8 @@ bool MediaSessionDescriptionFactory::AddRtpDataContentForOffer(
StreamParamsVec* current_streams,
SessionDescription* desc,
IceCredentialsIterator* ice_credentials) const {
- auto data = std::make_unique<RtpDataContentDescription>();
+ std::unique_ptr<RtpDataContentDescription> data(
+ new RtpDataContentDescription());
bool secure_transport = (transport_desc_factory_->secure() != SEC_DISABLED);
cricket::SecurePolicy sdes_policy =
@@ -2413,7 +2351,8 @@ bool MediaSessionDescriptionFactory::AddAudioContentForAnswer(
bool bundle_enabled = offer_description->HasGroup(GROUP_TYPE_BUNDLE) &&
session_options.bundle_enabled;
- auto audio_answer = std::make_unique<AudioContentDescription>();
+ std::unique_ptr<AudioContentDescription> audio_answer(
+ new AudioContentDescription());
// Do not require or create SDES cryptos if DTLS is used.
cricket::SecurePolicy sdes_policy =
audio_transport->secure() ? cricket::SEC_DISABLED : secure();
@@ -2453,8 +2392,6 @@ bool MediaSessionDescriptionFactory::AddAudioContentForAnswer(
return true;
}
-// TODO(kron): This function is very similar to AddAudioContentForAnswer.
-// Refactor to reuse shared code.
bool MediaSessionDescriptionFactory::AddVideoContentForAnswer(
const MediaDescriptionOptions& media_description_options,
const MediaSessionOptions& session_options,
@@ -2479,20 +2416,11 @@ bool MediaSessionDescriptionFactory::AddVideoContentForAnswer(
return false;
}
- // Pick codecs based on the requested communications direction in the offer
- // and the selected direction in the answer.
- // Note these will be filtered one final time in CreateMediaContentAnswer.
- auto wants_rtd = media_description_options.direction;
- auto offer_rtd = offer_video_description->direction();
- auto answer_rtd = NegotiateRtpTransceiverDirection(offer_rtd, wants_rtd);
- VideoCodecs supported_video_codecs =
- GetVideoCodecsForAnswer(offer_rtd, answer_rtd);
-
VideoCodecs filtered_codecs;
if (!media_description_options.codec_preferences.empty()) {
filtered_codecs = MatchCodecPreference(
- media_description_options.codec_preferences, supported_video_codecs);
+ media_description_options.codec_preferences, video_codecs_);
} else {
// Add the codecs from current content if it exists and is not rejected nor
// recycled.
@@ -2509,11 +2437,11 @@ bool MediaSessionDescriptionFactory::AddVideoContentForAnswer(
}
}
// Add other supported video codecs.
- for (const VideoCodec& codec : supported_video_codecs) {
- if (FindMatchingCodec<VideoCodec>(supported_video_codecs, video_codecs,
- codec, nullptr) &&
- !FindMatchingCodec<VideoCodec>(supported_video_codecs,
- filtered_codecs, codec, nullptr)) {
+ for (const VideoCodec& codec : video_codecs_) {
+ if (FindMatchingCodec<VideoCodec>(video_codecs_, video_codecs, codec,
+ nullptr) &&
+ !FindMatchingCodec<VideoCodec>(video_codecs_, filtered_codecs, codec,
+ nullptr)) {
// We should use the local codec with local parameters and the codec id
// would be correctly mapped in |NegotiateCodecs|.
filtered_codecs.push_back(codec);
@@ -2531,7 +2459,9 @@ bool MediaSessionDescriptionFactory::AddVideoContentForAnswer(
bool bundle_enabled = offer_description->HasGroup(GROUP_TYPE_BUNDLE) &&
session_options.bundle_enabled;
- auto video_answer = std::make_unique<VideoContentDescription>();
+
+ std::unique_ptr<VideoContentDescription> video_answer(
+ new VideoContentDescription());
// Do not require or create SDES cryptos if DTLS is used.
cricket::SecurePolicy sdes_policy =
video_transport->secure() ? cricket::SEC_DISABLED : secure();
@@ -2701,38 +2631,6 @@ void MediaSessionDescriptionFactory::ComputeAudioCodecsIntersectionAndUnion() {
&audio_sendrecv_codecs_, true);
}
-void MediaSessionDescriptionFactory::ComputeVideoCodecsIntersectionAndUnion() {
- video_sendrecv_codecs_.clear();
- all_video_codecs_.clear();
- // Compute the video codecs union.
- for (const VideoCodec& send : video_send_codecs_) {
- all_video_codecs_.push_back(send);
- if (!FindMatchingCodec<VideoCodec>(video_send_codecs_, video_recv_codecs_,
- send, nullptr)) {
- // TODO(kron): This check is violated by the unit test:
- // MediaSessionDescriptionFactoryTest.RtxWithoutApt
- // Remove either the test or the check.
-
- // It doesn't make sense to have an RTX codec we support sending but not
- // receiving.
- // RTC_DCHECK(!IsRtxCodec(send));
- }
- }
- for (const VideoCodec& recv : video_recv_codecs_) {
- if (!FindMatchingCodec<VideoCodec>(video_recv_codecs_, video_send_codecs_,
- recv, nullptr)) {
- all_video_codecs_.push_back(recv);
- }
- }
- // Use NegotiateCodecs to merge our codec lists, since the operation is
- // essentially the same. Put send_codecs as the offered_codecs, which is the
- // order we'd like to follow. The reasoning is that encoding is usually more
- // expensive than decoding, and prioritizing a codec in the send list probably
- // means it's a codec we can handle efficiently.
- NegotiateCodecs(video_recv_codecs_, video_send_codecs_,
- &video_sendrecv_codecs_, true);
-}
-
bool IsMediaContent(const ContentInfo* content) {
return (content && (content->type == MediaProtocolType::kRtp ||
content->type == MediaProtocolType::kSctp));
diff --git a/pc/media_session.h b/pc/media_session.h
index ef83834318..235945c4f9 100644
--- a/pc/media_session.h
+++ b/pc/media_session.h
@@ -151,11 +151,8 @@ class MediaSessionDescriptionFactory {
audio_rtp_extensions_ = extensions;
}
RtpHeaderExtensions audio_rtp_header_extensions() const;
- const VideoCodecs& video_sendrecv_codecs() const;
- const VideoCodecs& video_send_codecs() const;
- const VideoCodecs& video_recv_codecs() const;
- void set_video_codecs(const VideoCodecs& send_codecs,
- const VideoCodecs& recv_codecs);
+ const VideoCodecs& video_codecs() const { return video_codecs_; }
+ void set_video_codecs(const VideoCodecs& codecs) { video_codecs_ = codecs; }
void set_video_rtp_header_extensions(const RtpHeaderExtensions& extensions) {
video_rtp_extensions_ = extensions;
}
@@ -189,11 +186,6 @@ class MediaSessionDescriptionFactory {
const AudioCodecs& GetAudioCodecsForAnswer(
const webrtc::RtpTransceiverDirection& offer,
const webrtc::RtpTransceiverDirection& answer) const;
- const VideoCodecs& GetVideoCodecsForOffer(
- const webrtc::RtpTransceiverDirection& direction) const;
- const VideoCodecs& GetVideoCodecsForAnswer(
- const webrtc::RtpTransceiverDirection& offer,
- const webrtc::RtpTransceiverDirection& answer) const;
void GetCodecsForOffer(
const std::vector<const ContentInfo*>& current_active_contents,
AudioCodecs* audio_codecs,
@@ -325,8 +317,6 @@ class MediaSessionDescriptionFactory {
void ComputeAudioCodecsIntersectionAndUnion();
- void ComputeVideoCodecsIntersectionAndUnion();
-
bool is_unified_plan_ = false;
AudioCodecs audio_send_codecs_;
AudioCodecs audio_recv_codecs_;
@@ -335,12 +325,7 @@ class MediaSessionDescriptionFactory {
// Union of send and recv.
AudioCodecs all_audio_codecs_;
RtpHeaderExtensions audio_rtp_extensions_;
- VideoCodecs video_send_codecs_;
- VideoCodecs video_recv_codecs_;
- // Intersection of send and recv.
- VideoCodecs video_sendrecv_codecs_;
- // Union of send and recv.
- VideoCodecs all_video_codecs_;
+ VideoCodecs video_codecs_;
RtpHeaderExtensions video_rtp_extensions_;
RtpDataCodecs rtp_data_codecs_;
// This object is not owned by the channel so it must outlive it.
diff --git a/pc/media_session_unittest.cc b/pc/media_session_unittest.cc
index a901dedb70..a2416c4dcc 100644
--- a/pc/media_session_unittest.cc
+++ b/pc/media_session_unittest.cc
@@ -415,13 +415,11 @@ class MediaSessionDescriptionFactoryTest : public ::testing::Test {
: f1_(&tdf1_, &ssrc_generator1), f2_(&tdf2_, &ssrc_generator2) {
f1_.set_audio_codecs(MAKE_VECTOR(kAudioCodecs1),
MAKE_VECTOR(kAudioCodecs1));
- f1_.set_video_codecs(MAKE_VECTOR(kVideoCodecs1),
- MAKE_VECTOR(kVideoCodecs1));
+ f1_.set_video_codecs(MAKE_VECTOR(kVideoCodecs1));
f1_.set_rtp_data_codecs(MAKE_VECTOR(kDataCodecs1));
f2_.set_audio_codecs(MAKE_VECTOR(kAudioCodecs2),
MAKE_VECTOR(kAudioCodecs2));
- f2_.set_video_codecs(MAKE_VECTOR(kVideoCodecs2),
- MAKE_VECTOR(kVideoCodecs2));
+ f2_.set_video_codecs(MAKE_VECTOR(kVideoCodecs2));
f2_.set_rtp_data_codecs(MAKE_VECTOR(kDataCodecs2));
tdf1_.set_certificate(rtc::RTCCertificate::Create(
std::unique_ptr<rtc::SSLIdentity>(new rtc::FakeSSLIdentity("id1"))));
@@ -799,7 +797,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, TestCreateVideoOffer) {
ASSERT_CRYPTO(acd, 1U, kDefaultSrtpCryptoSuite);
EXPECT_EQ(cricket::kMediaProtocolSavpf, acd->protocol());
EXPECT_EQ(MEDIA_TYPE_VIDEO, vcd->type());
- EXPECT_EQ(f1_.video_sendrecv_codecs(), vcd->codecs());
+ EXPECT_EQ(f1_.video_codecs(), vcd->codecs());
EXPECT_EQ(0U, vcd->first_ssrc()); // no sender is attached
EXPECT_EQ(kAutoBandwidth, vcd->bandwidth()); // default bandwidth (auto)
EXPECT_TRUE(vcd->rtcp_mux()); // rtcp-mux defaults on
@@ -811,7 +809,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, TestCreateVideoOffer) {
// RTP playlod type. The test verifies that the offer don't contain the
// duplicate RTP payload types.
TEST_F(MediaSessionDescriptionFactoryTest, TestBundleOfferWithSameCodecPlType) {
- const VideoCodec& offered_video_codec = f2_.video_sendrecv_codecs()[0];
+ const VideoCodec& offered_video_codec = f2_.video_codecs()[0];
const AudioCodec& offered_audio_codec = f2_.audio_sendrecv_codecs()[0];
const RtpDataCodec& offered_data_codec = f2_.rtp_data_codecs()[0];
ASSERT_EQ(offered_video_codec.id, offered_audio_codec.id);
@@ -2063,7 +2061,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, TestCreateMultiStreamVideoOffer) {
ASSERT_CRYPTO(acd, 1U, kDefaultSrtpCryptoSuite);
EXPECT_EQ(MEDIA_TYPE_VIDEO, vcd->type());
- EXPECT_EQ(f1_.video_sendrecv_codecs(), vcd->codecs());
+ EXPECT_EQ(f1_.video_codecs(), vcd->codecs());
ASSERT_CRYPTO(vcd, 1U, kDefaultSrtpCryptoSuite);
const StreamParamsVec& video_streams = vcd->streams();
@@ -2559,8 +2557,8 @@ TEST_F(MediaSessionDescriptionFactoryTest,
// that is being recycled.
TEST_F(MediaSessionDescriptionFactoryTest,
ReOfferDoesNotReUseRecycledAudioCodecs) {
- f1_.set_video_codecs({}, {});
- f2_.set_video_codecs({}, {});
+ f1_.set_video_codecs({});
+ f2_.set_video_codecs({});
MediaSessionOptions opts;
AddMediaDescriptionOptions(MEDIA_TYPE_AUDIO, "a0",
@@ -2612,8 +2610,8 @@ TEST_F(MediaSessionDescriptionFactoryTest,
// section that is being recycled.
TEST_F(MediaSessionDescriptionFactoryTest,
ReAnswerDoesNotReUseRecycledAudioCodecs) {
- f1_.set_video_codecs({}, {});
- f2_.set_video_codecs({}, {});
+ f1_.set_video_codecs({});
+ f2_.set_video_codecs({});
// Perform initial offer/answer in reverse (|f2_| as offerer) so that the
// second offer/answer is forward (|f1_| as offerer).
@@ -2682,12 +2680,12 @@ TEST_F(MediaSessionDescriptionFactoryTest,
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates rtx for H264 with the payload type |f1_| uses.
AddRtxCodec(VideoCodec::CreateRtxCodec(126, kVideoCodecs1[1].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::vector<VideoCodec> f2_codecs = MAKE_VECTOR(kVideoCodecs2);
// This creates rtx for H264 with the payload type |f2_| uses.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs2[0].id), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::unique_ptr<SessionDescription> offer = f1_.CreateOffer(opts, NULL);
ASSERT_TRUE(offer.get() != NULL);
@@ -2746,8 +2744,8 @@ TEST_F(MediaSessionDescriptionFactoryTest,
std::vector<VideoCodec> f2_codecs = {vp9, vp9_rtx, vp8_answerer,
vp8_answerer_rtx};
- f1_.set_video_codecs(f1_codecs, f1_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f1_.set_video_codecs(f1_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::vector<AudioCodec> audio_codecs;
f1_.set_audio_codecs(audio_codecs, audio_codecs);
f2_.set_audio_codecs(audio_codecs, audio_codecs);
@@ -2782,7 +2780,7 @@ TEST_F(MediaSessionDescriptionFactoryTest,
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates rtx for H264 with the payload type |f1_| uses.
AddRtxCodec(VideoCodec::CreateRtxCodec(126, kVideoCodecs1[1].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
MediaSessionOptions opts;
AddMediaDescriptionOptions(MEDIA_TYPE_AUDIO, "audio",
@@ -2807,7 +2805,7 @@ TEST_F(MediaSessionDescriptionFactoryTest,
int used_pl_type = acd->codecs()[0].id;
f2_codecs[0].id = used_pl_type; // Set the payload type for H264.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, used_pl_type), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::unique_ptr<SessionDescription> updated_offer(
f2_.CreateOffer(opts, answer.get()));
@@ -2843,7 +2841,7 @@ TEST_F(MediaSessionDescriptionFactoryTest,
std::vector<VideoCodec> f2_codecs = MAKE_VECTOR(kVideoCodecs2);
// This creates rtx for H264 with the payload type |f2_| uses.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs2[0].id), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::unique_ptr<SessionDescription> offer = f1_.CreateOffer(opts, nullptr);
ASSERT_TRUE(offer.get() != nullptr);
@@ -2882,12 +2880,12 @@ TEST_F(MediaSessionDescriptionFactoryTest, RtxWithoutApt) {
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates RTX without associated payload type parameter.
AddRtxCodec(VideoCodec(126, cricket::kRtxCodecName), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::vector<VideoCodec> f2_codecs = MAKE_VECTOR(kVideoCodecs2);
// This creates RTX for H264 with the payload type |f2_| uses.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs2[0].id), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::unique_ptr<SessionDescription> offer = f1_.CreateOffer(opts, NULL);
ASSERT_TRUE(offer.get() != NULL);
@@ -2925,12 +2923,12 @@ TEST_F(MediaSessionDescriptionFactoryTest, FilterOutRtxIfAptDoesntMatch) {
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates RTX for H264 in sender.
AddRtxCodec(VideoCodec::CreateRtxCodec(126, kVideoCodecs1[1].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::vector<VideoCodec> f2_codecs = MAKE_VECTOR(kVideoCodecs2);
// This creates RTX for H263 in receiver.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs2[1].id), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f2_codecs);
+ f2_.set_video_codecs(f2_codecs);
std::unique_ptr<SessionDescription> offer = f1_.CreateOffer(opts, NULL);
ASSERT_TRUE(offer.get() != NULL);
@@ -2955,16 +2953,16 @@ TEST_F(MediaSessionDescriptionFactoryTest,
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates RTX for H264-SVC in sender.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs1[0].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
// This creates RTX for H264 in sender.
AddRtxCodec(VideoCodec::CreateRtxCodec(126, kVideoCodecs1[1].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::vector<VideoCodec> f2_codecs = MAKE_VECTOR(kVideoCodecs2);
// This creates RTX for H264 in receiver.
AddRtxCodec(VideoCodec::CreateRtxCodec(124, kVideoCodecs2[0].id), &f2_codecs);
- f2_.set_video_codecs(f2_codecs, f1_codecs);
+ f2_.set_video_codecs(f2_codecs);
// H264-SVC codec is removed in the answer, therefore, associated RTX codec
// for H264-SVC should also be removed.
@@ -2991,7 +2989,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, AddSecondRtxInNewOffer) {
std::vector<VideoCodec> f1_codecs = MAKE_VECTOR(kVideoCodecs1);
// This creates RTX for H264 for the offerer.
AddRtxCodec(VideoCodec::CreateRtxCodec(126, kVideoCodecs1[1].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::unique_ptr<SessionDescription> offer = f1_.CreateOffer(opts, nullptr);
ASSERT_TRUE(offer);
@@ -3005,7 +3003,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, AddSecondRtxInNewOffer) {
// Now, attempt to add RTX for H264-SVC.
AddRtxCodec(VideoCodec::CreateRtxCodec(125, kVideoCodecs1[0].id), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
std::unique_ptr<SessionDescription> updated_offer(
f1_.CreateOffer(opts, offer.get()));
@@ -3032,7 +3030,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, SimSsrcsGenerateMultipleRtxSsrcs) {
std::vector<VideoCodec> f1_codecs;
f1_codecs.push_back(VideoCodec(97, "H264"));
AddRtxCodec(VideoCodec::CreateRtxCodec(125, 97), &f1_codecs);
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
// Ensure that the offer has an RTX ssrc for each regular ssrc, and that there
// is a FID ssrc + grouping for each.
@@ -3074,7 +3072,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, GenerateFlexfecSsrc) {
std::vector<VideoCodec> f1_codecs;
f1_codecs.push_back(VideoCodec(97, "H264"));
f1_codecs.push_back(VideoCodec(118, "flexfec-03"));
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
// Ensure that the offer has a single FlexFEC ssrc and that
// there is no FEC-FR ssrc + grouping for each.
@@ -3115,7 +3113,7 @@ TEST_F(MediaSessionDescriptionFactoryTest, SimSsrcsGenerateNoFlexfecSsrcs) {
std::vector<VideoCodec> f1_codecs;
f1_codecs.push_back(VideoCodec(97, "H264"));
f1_codecs.push_back(VideoCodec(118, "flexfec-03"));
- f1_.set_video_codecs(f1_codecs, f1_codecs);
+ f1_.set_video_codecs(f1_codecs);
// Ensure that the offer has no FlexFEC ssrcs for each regular ssrc, and that
// there is no FEC-FR ssrc + grouping for each.
@@ -4253,9 +4251,9 @@ TEST_F(MediaSessionDescriptionFactoryTest, CreateAnswerWithLocalCodecParams) {
video_codecs2[0].SetParam(video_param_name, video_value2);
f1_.set_audio_codecs(audio_codecs1, audio_codecs1);
- f1_.set_video_codecs(video_codecs1, video_codecs1);
+ f1_.set_video_codecs(video_codecs1);
f2_.set_audio_codecs(audio_codecs2, audio_codecs2);
- f2_.set_video_codecs(video_codecs2, video_codecs2);
+ f2_.set_video_codecs(video_codecs2);
MediaSessionOptions opts;
AddMediaDescriptionOptions(MEDIA_TYPE_AUDIO, "audio",
@@ -4305,8 +4303,8 @@ TEST_F(MediaSessionDescriptionFactoryTest,
// Offerer will send both codecs, answerer should choose the one with matching
// packetization mode (and not the first one it sees).
- f1_.set_video_codecs({h264_pm0, h264_pm1}, {h264_pm0, h264_pm1});
- f2_.set_video_codecs({h264_pm1}, {h264_pm1});
+ f1_.set_video_codecs({h264_pm0, h264_pm1});
+ f2_.set_video_codecs({h264_pm1});
MediaSessionOptions opts;
AddMediaDescriptionOptions(MEDIA_TYPE_VIDEO, "video",
@@ -4335,13 +4333,11 @@ class MediaProtocolTest : public ::testing::TestWithParam<const char*> {
: f1_(&tdf1_, &ssrc_generator1), f2_(&tdf2_, &ssrc_generator2) {
f1_.set_audio_codecs(MAKE_VECTOR(kAudioCodecs1),
MAKE_VECTOR(kAudioCodecs1));
- f1_.set_video_codecs(MAKE_VECTOR(kVideoCodecs1),
- MAKE_VECTOR(kVideoCodecs1));
+ f1_.set_video_codecs(MAKE_VECTOR(kVideoCodecs1));
f1_.set_rtp_data_codecs(MAKE_VECTOR(kDataCodecs1));
f2_.set_audio_codecs(MAKE_VECTOR(kAudioCodecs2),
MAKE_VECTOR(kAudioCodecs2));
- f2_.set_video_codecs(MAKE_VECTOR(kVideoCodecs2),
- MAKE_VECTOR(kVideoCodecs2));
+ f2_.set_video_codecs(MAKE_VECTOR(kVideoCodecs2));
f2_.set_rtp_data_codecs(MAKE_VECTOR(kDataCodecs2));
f1_.set_secure(SEC_ENABLED);
f2_.set_secure(SEC_ENABLED);
diff --git a/pc/peer_connection_factory.cc b/pc/peer_connection_factory.cc
index c8bb22e43e..4523121b58 100644
--- a/pc/peer_connection_factory.cc
+++ b/pc/peer_connection_factory.cc
@@ -169,7 +169,7 @@ RtpCapabilities PeerConnectionFactory::GetRtpSenderCapabilities(
case cricket::MEDIA_TYPE_VIDEO: {
cricket::VideoCodecs cricket_codecs;
cricket::RtpHeaderExtensions cricket_extensions;
- channel_manager_->GetSupportedVideoSendCodecs(&cricket_codecs);
+ channel_manager_->GetSupportedVideoCodecs(&cricket_codecs);
channel_manager_->GetSupportedVideoRtpHeaderExtensions(
&cricket_extensions);
return ToRtpCapabilities(cricket_codecs, cricket_extensions);
@@ -196,7 +196,7 @@ RtpCapabilities PeerConnectionFactory::GetRtpReceiverCapabilities(
case cricket::MEDIA_TYPE_VIDEO: {
cricket::VideoCodecs cricket_codecs;
cricket::RtpHeaderExtensions cricket_extensions;
- channel_manager_->GetSupportedVideoReceiveCodecs(&cricket_codecs);
+ channel_manager_->GetSupportedVideoCodecs(&cricket_codecs);
channel_manager_->GetSupportedVideoRtpHeaderExtensions(
&cricket_extensions);
return ToRtpCapabilities(cricket_codecs, cricket_extensions);
diff --git a/pc/peer_connection_integrationtest.cc b/pc/peer_connection_integrationtest.cc
index df231f572c..399001f9f3 100644
--- a/pc/peer_connection_integrationtest.cc
+++ b/pc/peer_connection_integrationtest.cc
@@ -214,9 +214,7 @@ class PeerConnectionWrapper : public webrtc::PeerConnectionObserver,
dependencies.cert_generator = std::move(cert_generator);
if (!client->Init(nullptr, nullptr, std::move(dependencies), network_thread,
worker_thread, nullptr,
- /*media_transport_factory=*/nullptr,
- /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false)) {
+ /*media_transport_factory=*/nullptr)) {
delete client;
return nullptr;
}
@@ -606,9 +604,7 @@ class PeerConnectionWrapper : public webrtc::PeerConnectionObserver,
rtc::Thread* network_thread,
rtc::Thread* worker_thread,
std::unique_ptr<webrtc::FakeRtcEventLogFactory> event_log_factory,
- std::unique_ptr<webrtc::MediaTransportFactory> media_transport_factory,
- bool reset_encoder_factory,
- bool reset_decoder_factory) {
+ std::unique_ptr<webrtc::MediaTransportFactory> media_transport_factory) {
// There's an error in this test code if Init ends up being called twice.
RTC_DCHECK(!peer_connection_);
RTC_DCHECK(!peer_connection_factory_);
@@ -636,14 +632,6 @@ class PeerConnectionWrapper : public webrtc::PeerConnectionObserver,
pc_factory_dependencies.task_queue_factory.get();
media_deps.adm = fake_audio_capture_module_;
webrtc::SetMediaEngineDefaults(&media_deps);
-
- if (reset_encoder_factory) {
- media_deps.video_encoder_factory.reset();
- }
- if (reset_decoder_factory) {
- media_deps.video_decoder_factory.reset();
- }
-
pc_factory_dependencies.media_engine =
cricket::CreateMediaEngine(std::move(media_deps));
pc_factory_dependencies.call_factory = webrtc::CreateCallFactory();
@@ -1277,9 +1265,7 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
const RTCConfiguration* config,
webrtc::PeerConnectionDependencies dependencies,
std::unique_ptr<webrtc::FakeRtcEventLogFactory> event_log_factory,
- std::unique_ptr<webrtc::MediaTransportFactory> media_transport_factory,
- bool reset_encoder_factory,
- bool reset_decoder_factory) {
+ std::unique_ptr<webrtc::MediaTransportFactory> media_transport_factory) {
RTCConfiguration modified_config;
if (config) {
modified_config = *config;
@@ -1295,8 +1281,7 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
if (!client->Init(options, &modified_config, std::move(dependencies),
network_thread_.get(), worker_thread_.get(),
std::move(event_log_factory),
- std::move(media_transport_factory), reset_encoder_factory,
- reset_decoder_factory)) {
+ std::move(media_transport_factory))) {
return nullptr;
}
return client;
@@ -1310,11 +1295,10 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
webrtc::PeerConnectionDependencies dependencies) {
std::unique_ptr<webrtc::FakeRtcEventLogFactory> event_log_factory(
new webrtc::FakeRtcEventLogFactory(rtc::Thread::Current()));
- return CreatePeerConnectionWrapper(
- debug_name, options, config, std::move(dependencies),
- std::move(event_log_factory),
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ return CreatePeerConnectionWrapper(debug_name, options, config,
+ std::move(dependencies),
+ std::move(event_log_factory),
+ /*media_transport_factory=*/nullptr);
}
bool CreatePeerConnectionWrappers() {
@@ -1335,15 +1319,11 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
sdp_semantics_ = caller_semantics;
caller_ = CreatePeerConnectionWrapper(
"Caller", nullptr, nullptr, webrtc::PeerConnectionDependencies(nullptr),
- nullptr, /*media_transport_factory=*/nullptr,
- /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ nullptr, /*media_transport_factory=*/nullptr);
sdp_semantics_ = callee_semantics;
callee_ = CreatePeerConnectionWrapper(
"Callee", nullptr, nullptr, webrtc::PeerConnectionDependencies(nullptr),
- nullptr, /*media_transport_factory=*/nullptr,
- /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ nullptr, /*media_transport_factory=*/nullptr);
sdp_semantics_ = original_semantics;
return caller_ && callee_;
}
@@ -1354,13 +1334,11 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
caller_ = CreatePeerConnectionWrapper(
"Caller", nullptr, &caller_config,
webrtc::PeerConnectionDependencies(nullptr), nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ /*media_transport_factory=*/nullptr);
callee_ = CreatePeerConnectionWrapper(
"Callee", nullptr, &callee_config,
webrtc::PeerConnectionDependencies(nullptr), nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ /*media_transport_factory=*/nullptr);
return caller_ && callee_;
}
@@ -1369,16 +1347,14 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
const PeerConnectionInterface::RTCConfiguration& callee_config,
std::unique_ptr<webrtc::MediaTransportFactory> caller_factory,
std::unique_ptr<webrtc::MediaTransportFactory> callee_factory) {
- caller_ = CreatePeerConnectionWrapper(
- "Caller", nullptr, &caller_config,
- webrtc::PeerConnectionDependencies(nullptr), nullptr,
- std::move(caller_factory), /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
- callee_ = CreatePeerConnectionWrapper(
- "Callee", nullptr, &callee_config,
- webrtc::PeerConnectionDependencies(nullptr), nullptr,
- std::move(callee_factory), /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ caller_ =
+ CreatePeerConnectionWrapper("Caller", nullptr, &caller_config,
+ webrtc::PeerConnectionDependencies(nullptr),
+ nullptr, std::move(caller_factory));
+ callee_ =
+ CreatePeerConnectionWrapper("Callee", nullptr, &callee_config,
+ webrtc::PeerConnectionDependencies(nullptr),
+ nullptr, std::move(callee_factory));
return caller_ && callee_;
}
@@ -1387,16 +1363,14 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
webrtc::PeerConnectionDependencies caller_dependencies,
const PeerConnectionInterface::RTCConfiguration& callee_config,
webrtc::PeerConnectionDependencies callee_dependencies) {
- caller_ = CreatePeerConnectionWrapper(
- "Caller", nullptr, &caller_config, std::move(caller_dependencies),
- nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
- callee_ = CreatePeerConnectionWrapper(
- "Callee", nullptr, &callee_config, std::move(callee_dependencies),
- nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ caller_ =
+ CreatePeerConnectionWrapper("Caller", nullptr, &caller_config,
+ std::move(caller_dependencies), nullptr,
+ /*media_transport_factory=*/nullptr);
+ callee_ =
+ CreatePeerConnectionWrapper("Callee", nullptr, &callee_config,
+ std::move(callee_dependencies), nullptr,
+ /*media_transport_factory=*/nullptr);
return caller_ && callee_;
}
@@ -1406,13 +1380,11 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
caller_ = CreatePeerConnectionWrapper(
"Caller", &caller_options, nullptr,
webrtc::PeerConnectionDependencies(nullptr), nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ /*media_transport_factory=*/nullptr);
callee_ = CreatePeerConnectionWrapper(
"Callee", &callee_options, nullptr,
webrtc::PeerConnectionDependencies(nullptr), nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ /*media_transport_factory=*/nullptr);
return caller_ && callee_;
}
@@ -1435,24 +1407,9 @@ class PeerConnectionIntegrationBaseTest : public ::testing::Test {
webrtc::PeerConnectionDependencies dependencies(nullptr);
dependencies.cert_generator = std::move(cert_generator);
- return CreatePeerConnectionWrapper(
- "New Peer", nullptr, nullptr, std::move(dependencies), nullptr,
- /*media_transport_factory=*/nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
- }
-
- bool CreateOneDirectionalPeerConnectionWrappers(bool caller_to_callee) {
- caller_ = CreatePeerConnectionWrapper(
- "Caller", nullptr, nullptr, webrtc::PeerConnectionDependencies(nullptr),
- nullptr, /*media_transport_factory=*/nullptr,
- /*reset_encoder_factory=*/!caller_to_callee,
- /*reset_decoder_factory=*/caller_to_callee);
- callee_ = CreatePeerConnectionWrapper(
- "Callee", nullptr, nullptr, webrtc::PeerConnectionDependencies(nullptr),
- nullptr, /*media_transport_factory=*/nullptr,
- /*reset_encoder_factory=*/caller_to_callee,
- /*reset_decoder_factory=*/!caller_to_callee);
- return caller_ && callee_;
+ return CreatePeerConnectionWrapper("New Peer", nullptr, nullptr,
+ std::move(dependencies), nullptr,
+ /*media_transport_factory=*/nullptr);
}
cricket::TestTurnServer* CreateTurnServer(
@@ -2081,56 +2038,6 @@ TEST_P(PeerConnectionIntegrationTest, OneWayMediaCall) {
ASSERT_TRUE(ExpectNewFrames(media_expectations));
}
-// Tests that send only works without the caller having a decoder factory and
-// the callee having an encoder factory.
-TEST_P(PeerConnectionIntegrationTest, EndToEndCallWithSendOnlyVideo) {
- ASSERT_TRUE(
- CreateOneDirectionalPeerConnectionWrappers(/*caller_to_callee=*/true));
- ConnectFakeSignaling();
- // Add one-directional video, from caller to callee.
- rtc::scoped_refptr<webrtc::VideoTrackInterface> track =
- caller()->CreateLocalVideoTrack();
- caller()->AddTrack(track);
- PeerConnectionInterface::RTCOfferAnswerOptions options;
- options.offer_to_receive_video = 0;
- caller()->SetOfferAnswerOptions(options);
- caller()->CreateAndSetAndSignalOffer();
- ASSERT_TRUE_WAIT(SignalingStateStable(), kDefaultTimeout);
- ASSERT_EQ(callee()->pc()->GetReceivers().size(), 1u);
-
- // Expect video to be received in one direction.
- MediaExpectations media_expectations;
- media_expectations.CallerExpectsNoVideo();
- media_expectations.CalleeExpectsSomeVideo();
-
- EXPECT_TRUE(ExpectNewFrames(media_expectations));
-}
-
-// Tests that receive only works without the caller having an encoder factory
-// and the callee having a dncoder factory.
-TEST_P(PeerConnectionIntegrationTest, EndToEndCallWithReceiveOnlyVideo) {
- ASSERT_TRUE(
- CreateOneDirectionalPeerConnectionWrappers(/*caller_to_callee=*/false));
- ConnectFakeSignaling();
- // Add one-directional video, from caller to callee.
- rtc::scoped_refptr<webrtc::VideoTrackInterface> track =
- callee()->CreateLocalVideoTrack();
- callee()->AddTrack(track);
- PeerConnectionInterface::RTCOfferAnswerOptions options;
- options.offer_to_receive_video = 1;
- caller()->SetOfferAnswerOptions(options);
- caller()->CreateAndSetAndSignalOffer();
- ASSERT_TRUE_WAIT(SignalingStateStable(), kDefaultTimeout);
- ASSERT_EQ(caller()->pc()->GetReceivers().size(), 1u);
-
- // Expect video to be received in one direction.
- MediaExpectations media_expectations;
- media_expectations.CallerExpectsSomeVideo();
- media_expectations.CalleeExpectsNoVideo();
-
- EXPECT_TRUE(ExpectNewFrames(media_expectations));
-}
-
// This test sets up a audio call initially, with the callee rejecting video
// initially. Then later the callee decides to upgrade to audio/video, and
// initiates a new offer/answer exchange.
@@ -5349,10 +5256,9 @@ TEST_P(PeerConnectionIntegrationTest, IceTransportFactoryUsedForConnections) {
auto ice_transport_factory = std::make_unique<MockIceTransportFactory>();
EXPECT_CALL(*ice_transport_factory, RecordIceTransportCreated()).Times(1);
dependencies.ice_transport_factory = std::move(ice_transport_factory);
- auto wrapper = CreatePeerConnectionWrapper(
- "Caller", nullptr, &default_config, std::move(dependencies), nullptr,
- nullptr, /*reset_encoder_factory=*/false,
- /*reset_decoder_factory=*/false);
+ auto wrapper =
+ CreatePeerConnectionWrapper("Caller", nullptr, &default_config,
+ std::move(dependencies), nullptr, nullptr);
ASSERT_TRUE(wrapper);
wrapper->CreateDataChannel();
rtc::scoped_refptr<MockSetSessionDescriptionObserver> observer(
diff --git a/pc/peer_connection_media_unittest.cc b/pc/peer_connection_media_unittest.cc
index c9ffd776d9..077c4a3e43 100644
--- a/pc/peer_connection_media_unittest.cc
+++ b/pc/peer_connection_media_unittest.cc
@@ -1434,11 +1434,9 @@ TEST_F(PeerConnectionMediaTestUnifiedPlan,
TEST_F(PeerConnectionMediaTestUnifiedPlan,
SetCodecPreferencesVideoRejectsOnlyRtxRedFec) {
auto fake_engine = std::make_unique<FakeMediaEngine>();
- auto video_codecs = fake_engine->video().send_codecs();
+ auto video_codecs = fake_engine->video().codecs();
video_codecs.push_back(
cricket::VideoCodec(video_codecs.back().id + 1, cricket::kRtxCodecName));
- video_codecs.back().params[cricket::kCodecParamAssociatedPayloadType] =
- std::to_string(video_codecs.back().id - 1);
video_codecs.push_back(
cricket::VideoCodec(video_codecs.back().id + 1, cricket::kRedCodecName));
video_codecs.push_back(cricket::VideoCodec(video_codecs.back().id + 1,
@@ -1542,7 +1540,7 @@ TEST_F(PeerConnectionMediaTestUnifiedPlan,
TEST_F(PeerConnectionMediaTestUnifiedPlan, SetCodecPreferencesVideoWithRtx) {
auto caller_fake_engine = std::make_unique<FakeMediaEngine>();
- auto caller_video_codecs = caller_fake_engine->video().send_codecs();
+ auto caller_video_codecs = caller_fake_engine->video().codecs();
caller_video_codecs.push_back(cricket::VideoCodec(
caller_video_codecs.back().id + 1, cricket::kVp8CodecName));
caller_video_codecs.push_back(cricket::VideoCodec(
@@ -1594,7 +1592,7 @@ TEST_F(PeerConnectionMediaTestUnifiedPlan, SetCodecPreferencesVideoWithRtx) {
TEST_F(PeerConnectionMediaTestUnifiedPlan,
SetCodecPreferencesVideoCodecsNegotiation) {
auto caller_fake_engine = std::make_unique<FakeMediaEngine>();
- auto caller_video_codecs = caller_fake_engine->video().send_codecs();
+ auto caller_video_codecs = caller_fake_engine->video().codecs();
caller_video_codecs.push_back(cricket::VideoCodec(
caller_video_codecs.back().id + 1, cricket::kVp8CodecName));
caller_video_codecs.push_back(cricket::VideoCodec(
@@ -1668,7 +1666,7 @@ TEST_F(PeerConnectionMediaTestUnifiedPlan,
TEST_F(PeerConnectionMediaTestUnifiedPlan,
SetCodecPreferencesVideoCodecsNegotiationReverseOrder) {
auto caller_fake_engine = std::make_unique<FakeMediaEngine>();
- auto caller_video_codecs = caller_fake_engine->video().send_codecs();
+ auto caller_video_codecs = caller_fake_engine->video().codecs();
caller_video_codecs.push_back(cricket::VideoCodec(
caller_video_codecs.back().id + 1, cricket::kVp8CodecName));
caller_video_codecs.push_back(cricket::VideoCodec(
diff --git a/pc/rtp_transceiver.cc b/pc/rtp_transceiver.cc
index fcb54b54c2..d3281d5e6e 100644
--- a/pc/rtp_transceiver.cc
+++ b/pc/rtp_transceiver.cc
@@ -20,83 +20,6 @@
#include "rtc_base/logging.h"
namespace webrtc {
-namespace {
-template <class T>
-RTCError VerifyCodecPreferences(const std::vector<RtpCodecCapability>& codecs,
- const std::vector<T>& send_codecs,
- const std::vector<T>& recv_codecs) {
- // 6. If the intersection between codecs and
- // RTCRtpSender.getCapabilities(kind).codecs or the intersection between
- // codecs and RTCRtpReceiver.getCapabilities(kind).codecs only contains RTX,
- // RED or FEC codecs or is an empty set, throw InvalidModificationError.
- // This ensures that we always have something to offer, regardless of
- // transceiver.direction.
-
- if (!absl::c_any_of(codecs, [&recv_codecs](const RtpCodecCapability& codec) {
- return codec.name != cricket::kRtxCodecName &&
- codec.name != cricket::kRedCodecName &&
- codec.name != cricket::kFlexfecCodecName &&
- absl::c_any_of(recv_codecs, [&codec](const T& recv_codec) {
- return recv_codec.MatchesCapability(codec);
- });
- })) {
- return RTCError(RTCErrorType::INVALID_MODIFICATION,
- "Invalid codec preferences: Missing codec from recv "
- "codec capabilities.");
- }
-
- if (!absl::c_any_of(codecs, [&send_codecs](const RtpCodecCapability& codec) {
- return codec.name != cricket::kRtxCodecName &&
- codec.name != cricket::kRedCodecName &&
- codec.name != cricket::kFlexfecCodecName &&
- absl::c_any_of(send_codecs, [&codec](const T& send_codec) {
- return send_codec.MatchesCapability(codec);
- });
- })) {
- return RTCError(RTCErrorType::INVALID_MODIFICATION,
- "Invalid codec preferences: Missing codec from send "
- "codec capabilities.");
- }
-
- // 7. Let codecCapabilities be the union of
- // RTCRtpSender.getCapabilities(kind).codecs and
- // RTCRtpReceiver.getCapabilities(kind).codecs. 8.1 For each codec in
- // codecs, If codec is not in codecCapabilities, throw
- // InvalidModificationError.
- for (const auto& codec_preference : codecs) {
- bool is_recv_codec =
- absl::c_any_of(recv_codecs, [&codec_preference](const T& codec) {
- return codec.MatchesCapability(codec_preference);
- });
-
- bool is_send_codec =
- absl::c_any_of(send_codecs, [&codec_preference](const T& codec) {
- return codec.MatchesCapability(codec_preference);
- });
-
- if (!is_recv_codec && !is_send_codec) {
- return RTCError(
- RTCErrorType::INVALID_MODIFICATION,
- std::string("Invalid codec preferences: invalid codec with name \"") +
- codec_preference.name + "\".");
- }
- }
-
- // Check we have a real codec (not just rtx, red or fec)
- if (absl::c_all_of(codecs, [](const RtpCodecCapability& codec) {
- return codec.name == cricket::kRtxCodecName ||
- codec.name == cricket::kRedCodecName ||
- codec.name == cricket::kUlpfecCodecName;
- })) {
- return RTCError(RTCErrorType::INVALID_MODIFICATION,
- "Invalid codec preferences: codec list must have a non "
- "RTX, RED or FEC entry.");
- }
-
- return RTCError::OK();
-}
-
-} // namespace
RtpTransceiver::RtpTransceiver(cricket::MediaType media_type)
: unified_plan_(false), media_type_(media_type) {
@@ -328,26 +251,111 @@ RTCError RtpTransceiver::SetCodecPreferences(
return absl::c_linear_search(codecs, codec);
});
- RTCError result;
if (media_type_ == cricket::MEDIA_TYPE_AUDIO) {
+ std::vector<cricket::AudioCodec> audio_codecs;
+
std::vector<cricket::AudioCodec> recv_codecs, send_codecs;
channel_manager_->GetSupportedAudioReceiveCodecs(&recv_codecs);
channel_manager_->GetSupportedAudioSendCodecs(&send_codecs);
- result = VerifyCodecPreferences(codecs, send_codecs, recv_codecs);
- } else if (media_type_ == cricket::MEDIA_TYPE_VIDEO) {
- std::vector<cricket::VideoCodec> recv_codecs, send_codecs;
- channel_manager_->GetSupportedVideoReceiveCodecs(&recv_codecs);
- channel_manager_->GetSupportedVideoSendCodecs(&send_codecs);
+ // 6. If the intersection between codecs and
+ // RTCRtpSender.getCapabilities(kind).codecs or the intersection between
+ // codecs and RTCRtpReceiver.getCapabilities(kind).codecs only contains RTX,
+ // RED or FEC codecs or is an empty set, throw InvalidModificationError.
+ // This ensures that we always have something to offer, regardless of
+ // transceiver.direction.
+
+ if (!absl::c_any_of(
+ codecs, [&recv_codecs](const RtpCodecCapability& codec) {
+ return codec.name != cricket::kRtxCodecName &&
+ codec.name != cricket::kRedCodecName &&
+ codec.name != cricket::kFlexfecCodecName &&
+ absl::c_any_of(
+ recv_codecs,
+ [&codec](const cricket::AudioCodec& recv_codec) {
+ return recv_codec.MatchesCapability(codec);
+ });
+ })) {
+ return RTCError(RTCErrorType::INVALID_MODIFICATION,
+ "Invalid codec preferences: Missing codec from recv "
+ "codec capabilities.");
+ }
- result = VerifyCodecPreferences(codecs, send_codecs, recv_codecs);
+ if (!absl::c_any_of(
+ codecs, [&send_codecs](const RtpCodecCapability& codec) {
+ return codec.name != cricket::kRtxCodecName &&
+ codec.name != cricket::kRedCodecName &&
+ codec.name != cricket::kFlexfecCodecName &&
+ absl::c_any_of(
+ send_codecs,
+ [&codec](const cricket::AudioCodec& send_codec) {
+ return send_codec.MatchesCapability(codec);
+ });
+ })) {
+ return RTCError(RTCErrorType::INVALID_MODIFICATION,
+ "Invalid codec preferences: Missing codec from send "
+ "codec capabilities.");
+ }
+
+ // 7. Let codecCapabilities be the union of
+ // RTCRtpSender.getCapabilities(kind).codecs and
+ // RTCRtpReceiver.getCapabilities(kind).codecs. 8.1 For each codec in
+ // codecs, If codec is not in codecCapabilities, throw
+ // InvalidModificationError.
+ for (const auto& codec_preference : codecs) {
+ bool is_recv_codec = absl::c_any_of(
+ recv_codecs, [&codec_preference](const cricket::AudioCodec& codec) {
+ return codec.MatchesCapability(codec_preference);
+ });
+
+ bool is_send_codec = absl::c_any_of(
+ send_codecs, [&codec_preference](const cricket::AudioCodec& codec) {
+ return codec.MatchesCapability(codec_preference);
+ });
+
+ if (!is_recv_codec && !is_send_codec) {
+ return RTCError(
+ RTCErrorType::INVALID_MODIFICATION,
+ std::string(
+ "Invalid codec preferences: invalid codec with name \"") +
+ codec_preference.name + "\".");
+ }
+ }
+ } else if (media_type_ == cricket::MEDIA_TYPE_VIDEO) {
+ std::vector<cricket::VideoCodec> video_codecs;
+ // Video codecs are both for the receive and send side, so the checks are
+ // simpler than the audio ones.
+ channel_manager_->GetSupportedVideoCodecs(&video_codecs);
+
+ // Validate codecs
+ for (const auto& codec_preference : codecs) {
+ if (!absl::c_any_of(video_codecs, [&codec_preference](
+ const cricket::VideoCodec& codec) {
+ return codec.MatchesCapability(codec_preference);
+ })) {
+ return RTCError(
+ RTCErrorType::INVALID_MODIFICATION,
+ std::string(
+ "Invalid codec preferences: invalid codec with name \"") +
+ codec_preference.name + "\".");
+ }
+ }
}
- if (result.ok()) {
- codec_preferences_ = codecs;
+ // Check we have a real codec (not just rtx, red or fec)
+ if (absl::c_all_of(codecs, [](const RtpCodecCapability& codec) {
+ return codec.name == cricket::kRtxCodecName ||
+ codec.name == cricket::kRedCodecName ||
+ codec.name == cricket::kUlpfecCodecName;
+ })) {
+ return RTCError(RTCErrorType::INVALID_MODIFICATION,
+ "Invalid codec preferences: codec list must have a non "
+ "RTX, RED or FEC entry.");
}
- return result;
+ codec_preferences_ = codecs;
+
+ return RTCError::OK();
}
} // namespace webrtc