diff options
| author | Artem Titov <titovartem@webrtc.org> | 2020-03-11 11:18:54 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-03-11 12:08:32 +0000 |
| commit | e618cc9c1ed030f33dd54396d04141b66dd24f97 (patch) | |
| tree | 712be5c4e5d62dd2360680316aa7ef1f7d4efed4 /pc | |
| parent | c46385c346d5a98b83ecef16bd4b4aa219a61d71 (diff) | |
| download | webrtc-e618cc9c1ed030f33dd54396d04141b66dd24f97.tar.gz | |
Add jitterBufferTargetDelay as RTCNonStandardStatsMember to new GetStats API
Bug: webrtc:11381
Change-Id: I7df3450e50da49d178e1e3a5d9f4970672d91aac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169120
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30758}
Diffstat (limited to 'pc')
| -rw-r--r-- | pc/rtc_stats_collector.cc | 2 | ||||
| -rw-r--r-- | pc/rtc_stats_collector_unittest.cc | 2 | ||||
| -rw-r--r-- | pc/rtc_stats_integrationtest.cc | 6 |
3 files changed, 10 insertions, 0 deletions
diff --git a/pc/rtc_stats_collector.cc b/pc/rtc_stats_collector.cc index 5b34f1cac8..29c7d099b2 100644 --- a/pc/rtc_stats_collector.cc +++ b/pc/rtc_stats_collector.cc @@ -648,6 +648,8 @@ ProduceMediaStreamTrackStatsFromVoiceReceiverInfo( voice_receiver_info.delayed_packet_outage_samples; audio_track_stats->relative_packet_arrival_delay = voice_receiver_info.relative_packet_arrival_delay_seconds; + audio_track_stats->jitter_buffer_target_delay = + voice_receiver_info.jitter_buffer_target_delay_seconds; audio_track_stats->interruption_count = voice_receiver_info.interruption_count >= 0 ? voice_receiver_info.interruption_count diff --git a/pc/rtc_stats_collector_unittest.cc b/pc/rtc_stats_collector_unittest.cc index f886e14333..12f6059d9f 100644 --- a/pc/rtc_stats_collector_unittest.cc +++ b/pc/rtc_stats_collector_unittest.cc @@ -1547,6 +1547,7 @@ TEST_F(RTCStatsCollectorTest, voice_receiver_info.silent_concealed_samples = 765; voice_receiver_info.jitter_buffer_delay_seconds = 3456; voice_receiver_info.jitter_buffer_emitted_count = 13; + voice_receiver_info.jitter_buffer_target_delay_seconds = 7.894; voice_receiver_info.jitter_buffer_flushes = 7; voice_receiver_info.delayed_packet_outage_samples = 15; voice_receiver_info.relative_packet_arrival_delay_seconds = 16; @@ -1591,6 +1592,7 @@ TEST_F(RTCStatsCollectorTest, expected_remote_audio_track.silent_concealed_samples = 765; expected_remote_audio_track.jitter_buffer_delay = 3456; expected_remote_audio_track.jitter_buffer_emitted_count = 13; + expected_remote_audio_track.jitter_buffer_target_delay = 7.894; expected_remote_audio_track.jitter_buffer_flushes = 7; expected_remote_audio_track.delayed_packet_outage_samples = 15; expected_remote_audio_track.relative_packet_arrival_delay = 16; diff --git a/pc/rtc_stats_integrationtest.cc b/pc/rtc_stats_integrationtest.cc index 93a46efb8e..fa7d56a896 100644 --- a/pc/rtc_stats_integrationtest.cc +++ b/pc/rtc_stats_integrationtest.cc @@ -650,6 +650,8 @@ class RTCStatsReportVerifier { verifier.TestMemberIsUndefined(media_stream_track.interruption_count); verifier.TestMemberIsUndefined( media_stream_track.total_interruption_duration); + verifier.TestMemberIsUndefined( + media_stream_track.jitter_buffer_target_delay); } else { RTC_DCHECK_EQ(*media_stream_track.kind, RTCMediaStreamTrackKind::kAudio); // The type of the referenced media source depends on kind. @@ -660,6 +662,8 @@ class RTCStatsReportVerifier { media_stream_track.jitter_buffer_delay); verifier.TestMemberIsNonNegative<uint64_t>( media_stream_track.jitter_buffer_emitted_count); + verifier.TestMemberIsNonNegative<double>( + media_stream_track.jitter_buffer_target_delay); verifier.TestMemberIsPositive<double>(media_stream_track.audio_level); verifier.TestMemberIsPositive<double>( media_stream_track.total_audio_energy); @@ -694,6 +698,8 @@ class RTCStatsReportVerifier { verifier.TestMemberIsUndefined(media_stream_track.jitter_buffer_delay); verifier.TestMemberIsUndefined( media_stream_track.jitter_buffer_emitted_count); + verifier.TestMemberIsUndefined( + media_stream_track.jitter_buffer_target_delay); verifier.TestMemberIsUndefined(media_stream_track.audio_level); verifier.TestMemberIsUndefined(media_stream_track.total_audio_energy); verifier.TestMemberIsUndefined( |