diff options
| author | Ilya Nikolaevskiy <ilnik@webrtc.org> | 2018-05-28 10:24:22 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2018-05-28 12:30:19 +0000 |
| commit | 97b4ee5b4c311bcb28ad941e7b50c4668d8aea68 (patch) | |
| tree | be3418ee9d965fec03b90cc778b5de7ea28f4571 /pc | |
| parent | 66eaed03932170b8c36ad92a54dd4bacb0321dec (diff) | |
| download | webrtc-97b4ee5b4c311bcb28ad941e7b50c4668d8aea68.tar.gz | |
Wire up VAAPI VP8 experimental support in WebRTC.
Experiment flag added to PeerConnectionInterface::RtcConfiguration and
propagated down to VideoStreamEncoder.
Artificial Sdp parameter is added to the sdp format if the flag is set.
Additionally, sdp format is propagated in vp8 simulcast adapters.
Bug: chromium:794608
Change-Id: I2dec54d19ae7bfbd5f2777ec682da5a84194da94
Reviewed-on: https://webrtc-review.googlesource.com/78500
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23412}
Diffstat (limited to 'pc')
| -rw-r--r-- | pc/peerconnectioninterface_unittest.cc | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/pc/peerconnectioninterface_unittest.cc b/pc/peerconnectioninterface_unittest.cc index ef3f317de4..ce4a7abe90 100644 --- a/pc/peerconnectioninterface_unittest.cc +++ b/pc/peerconnectioninterface_unittest.cc @@ -4043,6 +4043,7 @@ TEST_F(PeerConnectionMediaConfigTest, TestDefaults) { EXPECT_TRUE(media_config.video.enable_prerenderer_smoothing); EXPECT_FALSE(media_config.video.suspend_below_min_bitrate); EXPECT_FALSE(media_config.video.experiment_cpu_load_estimator); + EXPECT_FALSE(media_config.video.experiment_vaapi_vp8_hw_encoding); } // This test verifies the DSCP constraint is recognized and passed to @@ -4098,6 +4099,19 @@ TEST_F(PeerConnectionMediaConfigTest, TestEnableExperimentCpuLoadEstimator) { EXPECT_TRUE(media_config.video.experiment_cpu_load_estimator); } +// This test verifies that the experiment_vaapi_vp8_hw_encoding flag is +// propagated from RTCConfiguration to the PeerConnection. +TEST_F(PeerConnectionMediaConfigTest, TestEnableExperimentVaapiVp8HwEncoding) { + PeerConnectionInterface::RTCConfiguration config; + FakeConstraints constraints; + + config.set_experiment_vaapi_vp8_hw_encoding(true); + const cricket::MediaConfig& media_config = + TestCreatePeerConnection(config, &constraints); + + EXPECT_TRUE(media_config.video.experiment_vaapi_vp8_hw_encoding); +} + // This test verifies the suspend below min bitrate constraint is // recognized and passed to the PeerConnection. TEST_F(PeerConnectionMediaConfigTest, |