diff options
| author | Mirko Bonadei <mbonadei@webrtc.org> | 2020-04-01 13:43:08 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-02 14:38:30 +0000 |
| commit | 06d3559b794a29ff3abfb3b5def71f39ea781f4b (patch) | |
| tree | 69a7d094d166935a1e0ff675df50da7babb78b68 /rtc_base | |
| parent | 55c991cc81ae26e43e94f56c218f9254436aa269 (diff) | |
| download | webrtc-06d3559b794a29ff3abfb3b5def71f39ea781f4b.tar.gz | |
Replace std::string::find() == 0 with absl::StartsWith (part 2).
This CL has been generated using clang-tidy [1] except for changes to
BUILD.gn files.
[1] - https://clang.llvm.org/extra/clang-tidy/checks/abseil-string-find-startswith.html
Bug: None
Change-Id: Ibf75601065a53bde28623b8eef57bec067235640
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172586
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30984}
Diffstat (limited to 'rtc_base')
| -rw-r--r-- | rtc_base/experiments/BUILD.gn | 1 | ||||
| -rw-r--r-- | rtc_base/experiments/rate_control_settings.cc | 3 | ||||
| -rw-r--r-- | rtc_base/network_unittest.cc | 5 |
3 files changed, 6 insertions, 3 deletions
diff --git a/rtc_base/experiments/BUILD.gn b/rtc_base/experiments/BUILD.gn index 058e9b7f20..f557526945 100644 --- a/rtc_base/experiments/BUILD.gn +++ b/rtc_base/experiments/BUILD.gn @@ -164,6 +164,7 @@ rtc_library("rate_control_settings") { "../../api/units:data_size", "../../api/video_codecs:video_codecs_api", "../../system_wrappers:field_trial", + "//third_party/abseil-cpp/absl/strings", "//third_party/abseil-cpp/absl/types:optional", ] } diff --git a/rtc_base/experiments/rate_control_settings.cc b/rtc_base/experiments/rate_control_settings.cc index ce77c9e631..ff5bb650ba 100644 --- a/rtc_base/experiments/rate_control_settings.cc +++ b/rtc_base/experiments/rate_control_settings.cc @@ -15,6 +15,7 @@ #include <string> +#include "absl/strings/match.h" #include "api/transport/field_trial_based_config.h" #include "rtc_base/logging.h" #include "rtc_base/numerics/safe_conversions.h" @@ -42,7 +43,7 @@ const char* kScreenshareHysteresisFieldTrialname = bool IsEnabled(const WebRtcKeyValueConfig* const key_value_config, absl::string_view key) { - return key_value_config->Lookup(key).find("Enabled") == 0; + return absl::StartsWith(key_value_config->Lookup(key), "Enabled"); } void ParseHysteresisFactor(const WebRtcKeyValueConfig* const key_value_config, diff --git a/rtc_base/network_unittest.cc b/rtc_base/network_unittest.cc index 41358646fe..d5aa8ac317 100644 --- a/rtc_base/network_unittest.cc +++ b/rtc_base/network_unittest.cc @@ -15,6 +15,7 @@ #include <memory> #include <vector> +#include "absl/strings/match.h" #include "rtc_base/checks.h" #include "rtc_base/net_helpers.h" #include "rtc_base/network_monitor.h" @@ -47,10 +48,10 @@ class FakeNetworkMonitor : public NetworkMonitorBase { AdapterType GetAdapterType(const std::string& if_name) override { // Note that the name matching rules are different from the // GetAdapterTypeFromName in NetworkManager. - if (if_name.find("wifi") == 0) { + if (absl::StartsWith(if_name, "wifi")) { return ADAPTER_TYPE_WIFI; } - if (if_name.find("cellular") == 0) { + if (absl::StartsWith(if_name, "cellular")) { return ADAPTER_TYPE_CELLULAR; } return ADAPTER_TYPE_UNKNOWN; |