diff options
| author | tommi@webrtc.org <tommi@webrtc.org> | 2015-03-05 08:42:01 +0000 |
|---|---|---|
| committer | tommi@webrtc.org <tommi@webrtc.org> | 2015-03-05 08:42:13 +0000 |
| commit | 5af41aabae428f261702ef287d8f07b198a7f9ba (patch) | |
| tree | dcaf1831e8a07b2adb3dadc5ab3c770e484fc2d9 /talk/app/webrtc/mediastreamsignaling.cc | |
| parent | fa67463d379884f2843d84e1625d472821f143b6 (diff) | |
| download | webrtc-5af41aabae428f261702ef287d8f07b198a7f9ba.tar.gz | |
Fix uninitialized variable. If FindConstraint() returns false, we check |value| in two places and at that point, it can hold an uninitialized value. Caught by Linux Memcheck builder.
http://chromegw.corp.google.com/i/client.webrtc/builders/Linux%20Memcheck/builds/3351/steps/libjingle_peerconnection_unittest/logs/0A34BA777AB03D08
TBR=perkj@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/43579004
Cr-Commit-Position: refs/heads/master@{#8611}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8611 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'talk/app/webrtc/mediastreamsignaling.cc')
| -rw-r--r-- | talk/app/webrtc/mediastreamsignaling.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/talk/app/webrtc/mediastreamsignaling.cc b/talk/app/webrtc/mediastreamsignaling.cc index 3c3112107a..1f5f14fd7b 100644 --- a/talk/app/webrtc/mediastreamsignaling.cc +++ b/talk/app/webrtc/mediastreamsignaling.cc @@ -54,7 +54,7 @@ using rtc::scoped_refptr; static bool ParseConstraintsForAnswer( const MediaConstraintsInterface* constraints, cricket::MediaSessionOptions* options) { - bool value; + bool value = false; size_t mandatory_constraints_satisfied = 0; // kOfferToReceiveAudio defaults to true according to spec. @@ -67,6 +67,7 @@ static bool ParseConstraintsForAnswer( // kOfferToReceiveVideo defaults to false according to spec. But // if it is an answer and video is offered, we should still accept video // per default. + value = false; if (!FindConstraint(constraints, MediaConstraintsInterface::kOfferToReceiveVideo, &value, &mandatory_constraints_satisfied) || value) { |