aboutsummaryrefslogtreecommitdiff
path: root/talk/media/webrtc
diff options
context:
space:
mode:
authorHenrik Lundin <henrik.lundin@webrtc.org>2015-06-05 11:04:13 +0200
committerHenrik Lundin <henrik.lundin@webrtc.org>2015-06-05 09:04:20 +0000
commit3fbf3f8841b5460503fb646eaedcb063620434a8 (patch)
tree2c05795aa8fa963e3b5afcf958a233783d3dffe7 /talk/media/webrtc
parentbdd185faabeed81006cb376c638ca28ad6666d75 (diff)
downloadwebrtc-3fbf3f8841b5460503fb646eaedcb063620434a8.tar.gz
Revert r9378 "Rename APM Config DelayCorrection to ExtendedFilter"
This reverts commit 5f4b7e2873864c61e2ad6d88679dcd5d321bfd16, since it broke some of the build bots. BUG=4696 TBR=bjornv@webrtc.org Review URL: https://codereview.webrtc.org/1166463006 Cr-Commit-Position: refs/heads/master@{#9380}
Diffstat (limited to 'talk/media/webrtc')
-rw-r--r--talk/media/webrtc/webrtcvoiceengine.cc18
-rw-r--r--talk/media/webrtc/webrtcvoiceengine.h4
-rw-r--r--talk/media/webrtc/webrtcvoiceengine_unittest.cc2
3 files changed, 12 insertions, 12 deletions
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 84a26c51b8..aad0d43aa8 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -357,7 +357,7 @@ static AudioOptions GetDefaultEngineOptions() {
options.conference_mode.Set(false);
options.adjust_agc_delta.Set(0);
options.experimental_agc.Set(false);
- options.extended_filter_aec.Set(false);
+ options.experimental_aec.Set(false);
options.delay_agnostic_aec.Set(false);
options.experimental_ns.Set(false);
options.aec_dump.Set(false);
@@ -661,7 +661,7 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
agc_mode = webrtc::kAgcFixedDigital;
options.typing_detection.Set(false);
options.experimental_agc.Set(false);
- options.extended_filter_aec.Set(false);
+ options.experimental_aec.Set(false);
options.experimental_ns.Set(false);
#endif
@@ -672,7 +672,7 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
if (options.delay_agnostic_aec.Get(&use_delay_agnostic_aec)) {
if (use_delay_agnostic_aec) {
options.echo_cancellation.Set(true);
- options.extended_filter_aec.Set(true);
+ options.experimental_aec.Set(true);
ec_mode = webrtc::kEcConference;
}
}
@@ -848,12 +848,12 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) {
new webrtc::ReportedDelay(!delay_agnostic_aec));
}
- extended_filter_aec_.SetFrom(options.extended_filter_aec);
- bool extended_filter;
- if (extended_filter_aec_.Get(&extended_filter)) {
- LOG(LS_INFO) << "Extended filter aec is enabled? " << extended_filter;
- config.Set<webrtc::ExtendedFilter>(
- new webrtc::ExtendedFilter(extended_filter));
+ experimental_aec_.SetFrom(options.experimental_aec);
+ bool experimental_aec;
+ if (experimental_aec_.Get(&experimental_aec)) {
+ LOG(LS_INFO) << "Experimental aec is enabled? " << experimental_aec;
+ config.Set<webrtc::DelayCorrection>(
+ new webrtc::DelayCorrection(experimental_aec));
}
experimental_ns_.SetFrom(options.experimental_ns);
diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h
index 35f2dbc93e..65dde08545 100644
--- a/talk/media/webrtc/webrtcvoiceengine.h
+++ b/talk/media/webrtc/webrtcvoiceengine.h
@@ -266,11 +266,11 @@ class WebRtcVoiceEngine
rtc::CriticalSection signal_media_critical_;
- // Cache received extended_filter_aec, delay_agnostic_aec and experimental_ns
+ // Cache received experimental_aec, delay_agnostic_aec and experimental_ns
// values, and apply them in case they are missing in the audio options. We
// need to do this because SetExtraOptions() will revert to defaults for
// options which are not provided.
- Settable<bool> extended_filter_aec_;
+ Settable<bool> experimental_aec_;
Settable<bool> delay_agnostic_aec_;
Settable<bool> experimental_ns_;
};
diff --git a/talk/media/webrtc/webrtcvoiceengine_unittest.cc b/talk/media/webrtc/webrtcvoiceengine_unittest.cc
index 0dc7b510ee..cf8100b06a 100644
--- a/talk/media/webrtc/webrtcvoiceengine_unittest.cc
+++ b/talk/media/webrtc/webrtcvoiceengine_unittest.cc
@@ -2895,7 +2895,7 @@ TEST_F(WebRtcVoiceEngineTestFake, SetAudioOptions) {
// Turn off echo cancellation and delay agnostic aec.
options.delay_agnostic_aec.Set(false);
- options.extended_filter_aec.Set(false);
+ options.experimental_aec.Set(false);
options.echo_cancellation.Set(false);
ASSERT_TRUE(engine_.SetOptions(options));
voe_.GetEcStatus(ec_enabled, ec_mode);