diff options
| author | Artem Titov <titovartem@webrtc.org> | 2020-05-14 13:54:17 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-14 13:55:22 +0000 |
| commit | 28685dc08cb34f756f9200519fba3222ba3a66f2 (patch) | |
| tree | 96e19c368317fd48105e0a9b95fe2ecda9b37dc6 /test | |
| parent | af1b9ceb62dce3462083f9a44e26ee6d79639cef (diff) | |
| download | webrtc-28685dc08cb34f756f9200519fba3222ba3a66f2.tar.gz | |
Revert "Make sure that "current" rtc::Thread instances are always current for TaskQueueBase."
This reverts commit 46b3bc6c24c233fe41a2401ce6e8eb8204a2d5a8.
Reason for revert: Speculative revert. Breaks downstream project
Original change's description:
> Make sure that "current" rtc::Thread instances are always current for TaskQueueBase.
>
> This is a necessary part of fulfilling the TaskQueueBase
> interface. If a thread does not register as the current TQ, yet offers
> the TQ interface, TQ 'current' checks will not work as expected and
> code that relies them (TaskQueueBase::Current() and IsCurrent())
> will run in unexpected ways.
>
> Bug: webrtc:11572
> Change-Id: Iab747bc474e74e6ce4f9e914cfd5b0578b19d19c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175080
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31254}
TBR=mbonadei@webrtc.org,tommi@webrtc.org
Change-Id: I69ff3355f0ec447b25604bd95fdacbdb4d4f3f27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175104
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31259}
Diffstat (limited to 'test')
| -rw-r--r-- | test/run_loop_unittest.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/test/run_loop_unittest.cc b/test/run_loop_unittest.cc index 160aba0716..a356cc265a 100644 --- a/test/run_loop_unittest.cc +++ b/test/run_loop_unittest.cc @@ -17,6 +17,7 @@ namespace webrtc { TEST(RunLoopTest, TaskQueueOnThread) { + EXPECT_EQ(TaskQueueBase::Current(), nullptr); test::RunLoop loop; EXPECT_EQ(TaskQueueBase::Current(), loop.task_queue()); EXPECT_TRUE(loop.task_queue()->IsCurrent()); |