diff options
author | Erik Språng <sprang@webrtc.org> | 2020-05-10 14:29:03 +0200 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2020-05-20 11:49:21 +0000 |
commit | b46df3da44c42f6e5055c69a8247a344887108ea (patch) | |
tree | 94d290021f4df12754a37cc08dbc7a08f4349aa9 /test | |
parent | 4b860c1fb389b641acf8595a1ca38fd07f11bc2d (diff) | |
download | webrtc-b46df3da44c42f6e5055c69a8247a344887108ea.tar.gz |
Reland "Removes lock release in PacedSender callback."
This is a reland of 6b9c60b06d04bc519195fca1f621b10accfeb46b
Original change's description:
> Removes lock release in PacedSender callback.
>
> The PacedSender currently has logic to temporarily release its internal
> lock while sending or asking for padding.
> This creates some tricky situations in the pacing controller where we
> need to consider if some thread can enter while we the process thread is
> actually processing, just temporarily busy sending.
>
> Since the pacing call stack is no longer cyclic, we can actually remove
> this lock-release now.
>
> Bug: webrtc:10809
> Change-Id: Ic59c605252bed1f96a03406c908a30cd1012f995
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173592
> Reviewed-by: Sebastian Jansson <srte@webrtc.org>
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31206}
Bug: webrtc:10809
Change-Id: Id39fc49b0a038e7ae3a0d9818fb0806c33ae0ae0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175656
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31332}
Diffstat (limited to 'test')
-rw-r--r-- | test/direct_transport.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/test/direct_transport.cc b/test/direct_transport.cc index 818480b18b..f4ae047870 100644 --- a/test/direct_transport.cc +++ b/test/direct_transport.cc @@ -55,7 +55,6 @@ DirectTransport::~DirectTransport() { } void DirectTransport::SetReceiver(PacketReceiver* receiver) { - rtc::CritScope cs(&process_lock_); fake_network_->SetReceiver(receiver); } |