aboutsummaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorHenrik Lundin <henrik.lundin@webrtc.org>2018-06-21 12:36:28 +0000
committerCommit Bot <commit-bot@chromium.org>2018-06-21 12:36:44 +0000
commit1ff41eb784ffe919982124fae0c3f294467aafc8 (patch)
tree77be93278588193b0f407d4931732d97b90c8892 /test
parent07efe436c9002e139845f62486e3ee4e29f0d85b (diff)
downloadwebrtc-1ff41eb784ffe919982124fae0c3f294467aafc8.tar.gz
Revert "NetEq: Deprecate playout modes Fax, Off and Streaming"
This reverts commit 80c4cca4915dbc6094a5bfae749f85f7371eadd1. Reason for revert: Breaks downstream tests. Original change's description: > NetEq: Deprecate playout modes Fax, Off and Streaming > > The playout modes other than Normal have not been reachable for a long > time, other than through tests. It is time to deprecate them. > > The only meaningful use was that Fax mode was sometimes set from > tests, in order to avoid time-stretching operations (accelerate and > pre-emptive expand) from messing with the test results. With this CL, > a new config is added instead, which lets the user specify exactly > this: don't do time-stretching. > > As a result of Fax and Off modes being removed, the following code > clean-up was done: > - Fold DecisionLogicNormal into DecisionLogic. > - Remove AudioRepetition and AlternativePlc operations, since they can > no longer be reached. > > Bug: webrtc:9421 > Change-Id: I651458e9c1931a99f3b07e242817d303bac119df > Reviewed-on: https://webrtc-review.googlesource.com/84123 > Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> > Reviewed-by: Ivo Creusen <ivoc@webrtc.org> > Reviewed-by: Minyue Li <minyue@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23704} TBR=henrik.lundin@webrtc.org,ivoc@webrtc.org,minyue@webrtc.org Change-Id: I555aae8850fc4ac1ea919bfa72c11b5218066f30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9421 Reviewed-on: https://webrtc-review.googlesource.com/84680 Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23706}
Diffstat (limited to 'test')
-rw-r--r--test/fuzzers/neteq_rtp_fuzzer.cc30
-rw-r--r--test/fuzzers/neteq_signal_fuzzer.cc41
2 files changed, 48 insertions, 23 deletions
diff --git a/test/fuzzers/neteq_rtp_fuzzer.cc b/test/fuzzers/neteq_rtp_fuzzer.cc
index 2b150a73b2..e28af90f31 100644
--- a/test/fuzzers/neteq_rtp_fuzzer.cc
+++ b/test/fuzzers/neteq_rtp_fuzzer.cc
@@ -133,13 +133,29 @@ void FuzzOneInputTest(const uint8_t* data, size_t size) {
std::unique_ptr<AudioChecksum> output(new AudioChecksum);
NetEqTest::Callbacks callbacks;
NetEq::Config config;
- auto codecs = NetEqTest::StandardDecoderMap();
- // kPayloadType is the payload type that will be used for encoding. Verify
- // that it is included in the standard decoder map, and that it points to the
- // expected decoder type.
- RTC_CHECK_EQ(codecs.count(kPayloadType), 1);
- RTC_CHECK(codecs[kPayloadType].first == NetEqDecoder::kDecoderPCM16Bswb32kHz);
-
+ NetEqTest::DecoderMap codecs;
+ codecs[0] = std::make_pair(NetEqDecoder::kDecoderPCMu, "pcmu");
+ codecs[8] = std::make_pair(NetEqDecoder::kDecoderPCMa, "pcma");
+ codecs[103] = std::make_pair(NetEqDecoder::kDecoderISAC, "isac");
+ codecs[104] = std::make_pair(NetEqDecoder::kDecoderISACswb, "isac-swb");
+ codecs[111] = std::make_pair(NetEqDecoder::kDecoderOpus, "opus");
+ codecs[93] = std::make_pair(NetEqDecoder::kDecoderPCM16B, "pcm16-nb");
+ codecs[94] = std::make_pair(NetEqDecoder::kDecoderPCM16Bwb, "pcm16-wb");
+ codecs[96] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16Bswb48kHz, "pcm16-swb48");
+ codecs[9] = std::make_pair(NetEqDecoder::kDecoderG722, "g722");
+ codecs[106] = std::make_pair(NetEqDecoder::kDecoderAVT, "avt");
+ codecs[114] = std::make_pair(NetEqDecoder::kDecoderAVT16kHz, "avt-16");
+ codecs[115] = std::make_pair(NetEqDecoder::kDecoderAVT32kHz, "avt-32");
+ codecs[116] = std::make_pair(NetEqDecoder::kDecoderAVT48kHz, "avt-48");
+ codecs[117] = std::make_pair(NetEqDecoder::kDecoderRED, "red");
+ codecs[13] = std::make_pair(NetEqDecoder::kDecoderCNGnb, "cng-nb");
+ codecs[98] = std::make_pair(NetEqDecoder::kDecoderCNGwb, "cng-wb");
+ codecs[99] = std::make_pair(NetEqDecoder::kDecoderCNGswb32kHz, "cng-swb32");
+ codecs[100] = std::make_pair(NetEqDecoder::kDecoderCNGswb48kHz, "cng-swb48");
+ // This is the payload type that will be used for encoding.
+ codecs[kPayloadType] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16Bswb32kHz, "pcm16-swb32");
NetEqTest::ExtDecoderMap ext_codecs;
NetEqTest test(config, codecs, ext_codecs, std::move(input),
diff --git a/test/fuzzers/neteq_signal_fuzzer.cc b/test/fuzzers/neteq_signal_fuzzer.cc
index 0ba25d5842..611964d70e 100644
--- a/test/fuzzers/neteq_signal_fuzzer.cc
+++ b/test/fuzzers/neteq_signal_fuzzer.cc
@@ -167,22 +167,31 @@ void FuzzOneInputTest(const uint8_t* data, size_t size) {
NetEq::Config config;
config.enable_post_decode_vad = true;
config.enable_fast_accelerate = true;
- auto codecs = NetEqTest::StandardDecoderMap();
- // rate_types contains the payload types that will be used for encoding.
- // Verify that they all are included in the standard decoder map, and that
- // they point to the expected decoder types.
- RTC_CHECK_EQ(codecs.count(rate_types[0].second), 1);
- RTC_CHECK(codecs[rate_types[0].second].first == NetEqDecoder::kDecoderPCM16B);
- RTC_CHECK_EQ(codecs.count(rate_types[1].second), 1);
- RTC_CHECK(codecs[rate_types[1].second].first ==
- NetEqDecoder::kDecoderPCM16Bwb);
- RTC_CHECK_EQ(codecs.count(rate_types[2].second), 1);
- RTC_CHECK(codecs[rate_types[2].second].first ==
- NetEqDecoder::kDecoderPCM16Bswb32kHz);
- RTC_CHECK_EQ(codecs.count(rate_types[3].second), 1);
- RTC_CHECK(codecs[rate_types[3].second].first ==
- NetEqDecoder::kDecoderPCM16Bswb48kHz);
-
+ NetEqTest::DecoderMap codecs;
+ codecs[0] = std::make_pair(NetEqDecoder::kDecoderPCMu, "pcmu");
+ codecs[8] = std::make_pair(NetEqDecoder::kDecoderPCMa, "pcma");
+ codecs[103] = std::make_pair(NetEqDecoder::kDecoderISAC, "isac");
+ codecs[104] = std::make_pair(NetEqDecoder::kDecoderISACswb, "isac-swb");
+ codecs[111] = std::make_pair(NetEqDecoder::kDecoderOpus, "opus");
+ codecs[9] = std::make_pair(NetEqDecoder::kDecoderG722, "g722");
+ codecs[106] = std::make_pair(NetEqDecoder::kDecoderAVT, "avt");
+ codecs[114] = std::make_pair(NetEqDecoder::kDecoderAVT16kHz, "avt-16");
+ codecs[115] = std::make_pair(NetEqDecoder::kDecoderAVT32kHz, "avt-32");
+ codecs[116] = std::make_pair(NetEqDecoder::kDecoderAVT48kHz, "avt-48");
+ codecs[117] = std::make_pair(NetEqDecoder::kDecoderRED, "red");
+ codecs[13] = std::make_pair(NetEqDecoder::kDecoderCNGnb, "cng-nb");
+ codecs[98] = std::make_pair(NetEqDecoder::kDecoderCNGwb, "cng-wb");
+ codecs[99] = std::make_pair(NetEqDecoder::kDecoderCNGswb32kHz, "cng-swb32");
+ codecs[100] = std::make_pair(NetEqDecoder::kDecoderCNGswb48kHz, "cng-swb48");
+ // One of these payload types will be used for encoding.
+ codecs[rate_types[0].second] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16B, "pcm16-nb");
+ codecs[rate_types[1].second] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16Bwb, "pcm16-wb");
+ codecs[rate_types[2].second] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16Bswb32kHz, "pcm16-swb32");
+ codecs[rate_types[3].second] =
+ std::make_pair(NetEqDecoder::kDecoderPCM16Bswb48kHz, "pcm16-swb48");
NetEqTest::ExtDecoderMap ext_codecs;
NetEqTest test(config, codecs, ext_codecs, std::move(input),