diff options
| author | Edward Lemur <ehmaldonado@webrtc.org> | 2018-02-01 15:14:53 +0100 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2018-02-05 16:37:01 +0000 |
| commit | 0501e1cd971fd91bf95d8e71c5f2df9db57196f6 (patch) | |
| tree | 4615f4b29d24c4efeefa2fa96bcae7901fd3ea2f /tools_webrtc | |
| parent | 0488fcf2931b690eba558df14c42449d0ae02d24 (diff) | |
| download | webrtc-0501e1cd971fd91bf95d8e71c5f2df9db57196f6.tar.gz | |
Pass chartjson_result_file to gtest_parallel tests.
Translate --isolate-script-test-perf-output to --chartjson_result_file
and pass it to the test.
That way we can use Chromium's recipe code to report results to the
Perf dashboard.
TBR=phoglund@webrtc.org
Bug: chromium:807737
Change-Id: I2d3479fe29431cc1a8faf9a73b054a5f4ec610a4
Reviewed-on: https://webrtc-review.googlesource.com/47121
Commit-Queue: Edward Lemur <ehmaldonado@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21894}
Diffstat (limited to 'tools_webrtc')
| -rwxr-xr-x | tools_webrtc/gtest-parallel-wrapper.py | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/tools_webrtc/gtest-parallel-wrapper.py b/tools_webrtc/gtest-parallel-wrapper.py index 42e523343e..b527a5e815 100755 --- a/tools_webrtc/gtest-parallel-wrapper.py +++ b/tools_webrtc/gtest-parallel-wrapper.py @@ -107,8 +107,7 @@ def _ParseArgs(): parser.add_argument('--store-test-artifacts', action='store_true', default=False) - # We don't need to implement this flag, and possibly can't, since it's - # intended for results of Telemetry tests. See + # Used to store results of perf tests. See # https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/HEAD/dashboard/docs/data-format.md parser.add_argument('--isolated-script-test-perf-output', type=str, default=None) @@ -146,6 +145,13 @@ def _ParseArgs(): test_artifacts_dir, ] + # The corresponding flag in WebRTC is called 'chartjson_result_file'. + if options.isolated_script_test_perf_output: + executable_args += [ + '--chartjson_result_file', + options.isolated_script_test_perf_output, + ] + # GTEST_SHARD_INDEX and GTEST_TOTAL_SHARDS must be removed from the # environment. Otherwise it will be picked up by the binary, causing a bug # where only tests in the first shard are executed. |