diff options
| author | Mirta Dvornicic <mirtad@webrtc.org> | 2020-07-15 14:10:31 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-07-16 09:42:47 +0000 |
| commit | fca30875b66c26a7f1d380f2d58e3e6297ab487d (patch) | |
| tree | a2b7c2bd27de2d0eda5a4249dd9b5fc32f3c059b /video | |
| parent | e51d6ac5d2880f652e51a9352ca80afbdd99bf97 (diff) | |
| download | webrtc-fca30875b66c26a7f1d380f2d58e3e6297ab487d.tar.gz | |
Do not use internal source in video send stream tests.
Unless testing a behavior specific to video encoders with internal source.
Bug: None
Change-Id: Ia42177f2a0b7e658060208444870a7466c6779dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/179362
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31740}
Diffstat (limited to 'video')
| -rw-r--r-- | video/video_send_stream_tests.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/video/video_send_stream_tests.cc b/video/video_send_stream_tests.cc index efbcef7278..64a1a55710 100644 --- a/video/video_send_stream_tests.cc +++ b/video/video_send_stream_tests.cc @@ -2280,13 +2280,15 @@ TEST_F(VideoSendStreamTest, CanReconfigureToUseStartBitrateAbovePreviousMax) { StartBitrateObserver encoder; test::VideoEncoderProxyFactory encoder_factory(&encoder); - // Since this test does not use a capturer, set |internal_source| = true. - // Encoder configuration is otherwise updated on the next video frame. - encoder_factory.SetHasInternalSource(true); GetVideoSendConfig()->encoder_settings.encoder_factory = &encoder_factory; CreateVideoStreams(); + // Start capturing and encoding frames to force encoder reconfiguration. + CreateFrameGeneratorCapturer(kDefaultFramerate, kDefaultWidth, + kDefaultHeight); + frame_generator_capturer_->Start(); + EXPECT_TRUE(encoder.WaitForStartBitrate()); EXPECT_EQ(GetVideoEncoderConfig()->max_bitrate_bps / 1000, encoder.GetStartBitrateKbps()); |