aboutsummaryrefslogtreecommitdiff
path: root/webrtc/call/rtc_event_log.cc
diff options
context:
space:
mode:
authorIvo Creusen <ivoc@webrtc.org>2015-10-08 18:07:41 +0200
committerIvo Creusen <ivoc@webrtc.org>2015-10-08 16:07:53 +0000
commit301aaed813b55e28c12e89bb58ae8f8d8136c47e (patch)
treea2def3443a1031d41bc030f44f91f3c056db155a /webrtc/call/rtc_event_log.cc
parent8ac544e811439f79b2ec0c676f383ddc51ef2ed5 (diff)
downloadwebrtc-301aaed813b55e28c12e89bb58ae8f8d8136c47e.tar.gz
Update to the RtcEventLog protobuf to remove the DebugEvent message.
This CL restructures the RtcEventLog protobuf format, by removing the DebugEvent message. This is done by moving the LOG_START and LOG_END events to the EventType enum and making a seperate message for audio playout events. In addition to these changes, some fields were added to the AudioReceiveConfig and AudioSendConfig messages, but these are for future use and are not currently logged yet. This is a follow-up to CL 1340283002 which adds a SSRC to AudioPlayout events in the RtcEventLog. BUG=webrtc:4741 R=henrik.lundin@webrtc.org, stefan@webrtc.org, terelius@webrtc.org Review URL: https://codereview.webrtc.org/1348113003 . Cr-Commit-Position: refs/heads/master@{#10221}
Diffstat (limited to 'webrtc/call/rtc_event_log.cc')
-rw-r--r--webrtc/call/rtc_event_log.cc17
1 files changed, 6 insertions, 11 deletions
diff --git a/webrtc/call/rtc_event_log.cc b/webrtc/call/rtc_event_log.cc
index 058879ae0b..97885cc066 100644
--- a/webrtc/call/rtc_event_log.cc
+++ b/webrtc/call/rtc_event_log.cc
@@ -174,9 +174,7 @@ void RtcEventLogImpl::StartLogging(const std::string& file_name,
// Write a LOG_START event to the file.
rtclog::Event start_event;
start_event.set_timestamp_us(start_time_us_);
- start_event.set_type(rtclog::Event::DEBUG_EVENT);
- auto debug_event = start_event.mutable_debug_event();
- debug_event->set_type(rtclog::DebugEvent_EventType_LOG_START);
+ start_event.set_type(rtclog::Event::LOG_START);
StoreToFile(&start_event);
}
@@ -323,23 +321,20 @@ void RtcEventLogImpl::LogAudioPlayout(uint32_t ssrc) {
rtclog::Event event;
const int64_t timestamp = clock_->TimeInMicroseconds();
event.set_timestamp_us(timestamp);
- event.set_type(rtclog::Event::DEBUG_EVENT);
- auto debug_event = event.mutable_debug_event();
- debug_event->set_type(rtclog::DebugEvent_EventType_AUDIO_PLAYOUT);
- debug_event->set_local_ssrc(ssrc);
+ event.set_type(rtclog::Event::AUDIO_PLAYOUT_EVENT);
+ auto playout_event = event.mutable_audio_playout_event();
+ playout_event->set_local_ssrc(ssrc);
HandleEvent(&event);
}
void RtcEventLogImpl::StopLoggingLocked() {
if (currently_logging_) {
currently_logging_ = false;
- // Create a LogEnd debug event
+ // Create a LogEnd event
rtclog::Event event;
int64_t timestamp = clock_->TimeInMicroseconds();
event.set_timestamp_us(timestamp);
- event.set_type(rtclog::Event::DEBUG_EVENT);
- auto debug_event = event.mutable_debug_event();
- debug_event->set_type(rtclog::DebugEvent_EventType_LOG_END);
+ event.set_type(rtclog::Event::LOG_END);
// Store the event and close the file
RTC_DCHECK(file_->Open());
StoreToFile(&event);