diff options
author | Peter Kasting <pkasting@google.com> | 2015-08-24 14:52:23 -0700 |
---|---|---|
committer | Peter Kasting <pkasting@google.com> | 2015-08-24 21:52:45 +0000 |
commit | dce40cf804019a9898b6ab8d8262466b697c56e0 (patch) | |
tree | 83ae06d5acc897bbf2fe73ea0c944b5ea4a0414d /webrtc/common_audio/sparse_fir_filter.h | |
parent | b594041ec8a3ae9f501260e2456d9d5ce6482819 (diff) | |
download | webrtc-dce40cf804019a9898b6ab8d8262466b697c56e0.tar.gz |
Update a ton of audio code to use size_t more correctly and in general reduce
use of int16_t/uint16_t.
This is the upshot of a recommendation by henrik.lundin and kwiberg on an original small change ( https://webrtc-codereview.appspot.com/42569004/#ps1 ) to stop using int16_t just because values could fit in it, and is similar in nature to a previous "mass change to use size_t more" ( https://webrtc-codereview.appspot.com/23129004/ ) which also needed to be split up for review but to land all at once, since, like adding "const", such changes tend to cause a lot of transitive effects.
This was be reviewed and approved in pieces:
https://codereview.webrtc.org/1224093003
https://codereview.webrtc.org/1224123002
https://codereview.webrtc.org/1224163002
https://codereview.webrtc.org/1225133003
https://codereview.webrtc.org/1225173002
https://codereview.webrtc.org/1227163003
https://codereview.webrtc.org/1227203003
https://codereview.webrtc.org/1227213002
https://codereview.webrtc.org/1227893002
https://codereview.webrtc.org/1228793004
https://codereview.webrtc.org/1228803003
https://codereview.webrtc.org/1228823002
https://codereview.webrtc.org/1228823003
https://codereview.webrtc.org/1228843002
https://codereview.webrtc.org/1230693002
https://codereview.webrtc.org/1231713002
The change is being landed as TBR to all the folks who reviewed the above.
BUG=chromium:81439
TEST=none
R=andrew@webrtc.org, pbos@webrtc.org
TBR=aluebs, andrew, asapersson, henrika, hlundin, jan.skoglund, kwiberg, minyue, pbos, pthatcher
Review URL: https://codereview.webrtc.org/1230503003 .
Cr-Commit-Position: refs/heads/master@{#9768}
Diffstat (limited to 'webrtc/common_audio/sparse_fir_filter.h')
-rw-r--r-- | webrtc/common_audio/sparse_fir_filter.h | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/webrtc/common_audio/sparse_fir_filter.h b/webrtc/common_audio/sparse_fir_filter.h index 4526ad7892..9322afcdcc 100644 --- a/webrtc/common_audio/sparse_fir_filter.h +++ b/webrtc/common_audio/sparse_fir_filter.h @@ -30,17 +30,17 @@ class SparseFIRFilter final { // B = [0 coeffs[0] 0 0 coeffs[1] 0 0 coeffs[2] ... ] // All initial state values will be zeros. SparseFIRFilter(const float* nonzero_coeffs, - int num_nonzero_coeffs, - int sparsity, - int offset); + size_t num_nonzero_coeffs, + size_t sparsity, + size_t offset); // Filters the |in| data supplied. // |out| must be previously allocated and it must be at least of |length|. - void Filter(const float* in, int length, float* out); + void Filter(const float* in, size_t length, float* out); private: - const int sparsity_; - const int offset_; + const size_t sparsity_; + const size_t offset_; const std::vector<float> nonzero_coeffs_; std::vector<float> state_; |