diff options
author | tnakamura@webrtc.org <tnakamura@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2013-07-16 19:25:04 +0000 |
---|---|---|
committer | tnakamura@webrtc.org <tnakamura@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> | 2013-07-16 19:25:04 +0000 |
commit | aa4d96a134a03f998d52fb9699845d9c644eb24b (patch) | |
tree | a1d0d10b80d3122ebf63c1665f35d79b141acb78 /webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc | |
parent | 7b2f955e565a64d182b25ae3763b09b60fc682b8 (diff) | |
download | webrtc-aa4d96a134a03f998d52fb9699845d9c644eb24b.tar.gz |
Revert r4301
R=mikhal@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4357 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc')
-rw-r--r-- | webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc index 8ef10741f1..2f1e9169db 100644 --- a/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc +++ b/webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc @@ -8,7 +8,7 @@ * be found in the AUTHORS file in the root of the source tree. */ -#include "webrtc/modules/rtp_rtcp/interface/rtp_payload_registry.h" +#include "webrtc/modules/rtp_rtcp/source/rtp_payload_registry.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" @@ -74,8 +74,8 @@ TEST_F(RtpPayloadRegistryTest, RegistersAndRemembersPayloadsUntilDeregistered) { EXPECT_TRUE(new_payload_created) << "A new payload WAS created."; ModuleRTPUtility::Payload* retrieved_payload = NULL; - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type, - retrieved_payload)); + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload(payload_type, + retrieved_payload)); // We should get back the exact pointer to the payload returned by the // payload strategy. @@ -83,7 +83,7 @@ TEST_F(RtpPayloadRegistryTest, RegistersAndRemembersPayloadsUntilDeregistered) { // Now forget about it and verify it's gone. EXPECT_EQ(0, rtp_payload_registry_->DeRegisterReceivePayload(payload_type)); - EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload( + EXPECT_EQ(-1, rtp_payload_registry_->PayloadTypeToPayload( payload_type, retrieved_payload)); } @@ -101,8 +101,8 @@ TEST_F(RtpPayloadRegistryTest, DoesNotCreateNewPayloadTypeIfRed) { ASSERT_EQ(red_type_of_the_day, rtp_payload_registry_->red_payload_type()); ModuleRTPUtility::Payload* retrieved_payload = NULL; - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(red_type_of_the_day, - retrieved_payload)); + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload(red_type_of_the_day, + retrieved_payload)); EXPECT_FALSE(retrieved_payload->audio); EXPECT_STRCASEEQ("red", retrieved_payload->name); } @@ -131,11 +131,11 @@ TEST_F(RtpPayloadRegistryTest, // Ensure both payloads are preserved. ModuleRTPUtility::Payload* retrieved_payload = NULL; - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type, - retrieved_payload)); + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload(payload_type, + retrieved_payload)); EXPECT_EQ(first_payload_on_heap, retrieved_payload); - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1, - retrieved_payload)); + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload(payload_type - 1, + retrieved_payload)); EXPECT_EQ(second_payload_on_heap, retrieved_payload); // Ok, update the rate for one of the codecs. If either the incoming rate or @@ -170,10 +170,10 @@ TEST_F(RtpPayloadRegistryTest, kTypicalChannels, kTypicalRate, &ignored)); ModuleRTPUtility::Payload* retrieved_payload = NULL; - EXPECT_FALSE(rtp_payload_registry_->PayloadTypeToPayload( + EXPECT_EQ(-1, rtp_payload_registry_->PayloadTypeToPayload( payload_type, retrieved_payload)) << "The first payload should be " "deregistered because the only thing that differs is payload type."; - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload( payload_type - 1, retrieved_payload)) << "The second payload should still be registered though."; @@ -185,10 +185,10 @@ TEST_F(RtpPayloadRegistryTest, kTypicalPayloadName, payload_type + 1, kTypicalFrequency, kTypicalChannels, kTypicalRate, &ignored)); - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload( payload_type - 1, retrieved_payload)) << "Not compatible; both payloads should be kept."; - EXPECT_TRUE(rtp_payload_registry_->PayloadTypeToPayload( + EXPECT_EQ(0, rtp_payload_registry_->PayloadTypeToPayload( payload_type + 1, retrieved_payload)) << "Not compatible; both payloads should be kept."; } |