diff options
author | kjellander@webrtc.org <kjellander@webrtc.org> | 2014-08-25 14:15:35 +0000 |
---|---|---|
committer | kjellander@webrtc.org <kjellander@webrtc.org> | 2014-08-25 14:15:35 +0000 |
commit | 42ee5b54b59d766066bac540c3e8ddf7d49b649f (patch) | |
tree | 3097058691b4f3957a585a3b133077e312582a8e /webrtc/modules/video_processing/BUILD.gn | |
parent | b4c7b09c1352174ecc1faf8c0cd93c66028a0485 (diff) | |
download | webrtc-42ee5b54b59d766066bac540c3e8ddf7d49b649f.tar.gz |
GN: Disable Chromium clang plugins for standalone build.
Now that WebRTC has rolled the chromium_revision past
http://crrev.com/284372 in r6784, clang has become the
default compiler. Since WebRTC standalone code doesn't
yet compile the Chromium Clang plugins enabled, this CL
disables them for the parts of the code that doesn't yet pass
compilation with them enabled.
The buildbots are using Goma which is not yet switched
over to Clang by default. That's why they're not red yet.
BUG=163
TEST=Passing compile locally on Linux using:
gn gen out/Debug --args="build_with_chromium=false is_debug=true" && ninja
-C out/Debug
gn gen out/Release --args="build_with_chromium=false is_debug=false" && ninja
-C out/Release
gn gen out/Default --args="build_with_chromium=false os=\"android\" cpu_arch=\"arm\" arm_version=7" && ninja -C out/Default
R=brettw@chromium.org
Review URL: https://webrtc-codereview.appspot.com/16279004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6966 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'webrtc/modules/video_processing/BUILD.gn')
-rw-r--r-- | webrtc/modules/video_processing/BUILD.gn | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/webrtc/modules/video_processing/BUILD.gn b/webrtc/modules/video_processing/BUILD.gn index 59bde18767..42ef94bfa9 100644 --- a/webrtc/modules/video_processing/BUILD.gn +++ b/webrtc/modules/video_processing/BUILD.gn @@ -44,15 +44,25 @@ source_set("video_processing") { if (build_video_processing_sse2) { deps += [ ":video_processing_sse2" ] } + + if (is_clang) { + # Suppress warnings from Chrome's Clang plugins. + # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + configs -= [ "//build/config/clang:find_bad_constructs" ] + } } if (build_video_processing_sse2) { source_set("video_processing_sse2") { sources = [ "main/source/content_analysis_sse2.cc" ] - configs += [ - "../..:common_inherited_config", - ] + configs += [ "../..:common_inherited_config" ] + + if (is_clang) { + # Suppress warnings from Chrome's Clang plugins. + # See http://code.google.com/p/webrtc/issues/detail?id=163 for details. + configs -= [ "//build/config/clang:find_bad_constructs" ] + } if (is_posix) { cflags = [ "-msse2" ] |