diff options
| author | pbos@webrtc.org <pbos@webrtc.org> | 2015-03-18 14:11:39 +0000 |
|---|---|---|
| committer | pbos@webrtc.org <pbos@webrtc.org> | 2015-03-18 14:12:38 +0000 |
| commit | 5a477a0bc6fd3657eb7173d2c8a2e1a01a88dbb3 (patch) | |
| tree | 0b08abda12efb15547fec2f0e84321ecd24adc74 /webrtc/video_frame.h | |
| parent | 4346d92578e5acbf3c40c89967c548e8f72e7543 (diff) | |
| download | webrtc-5a477a0bc6fd3657eb7173d2c8a2e1a01a88dbb3.tar.gz | |
DCHECK frame parameters instead of return codes.
We should never be creating video frames without width/height. If these
DCHECKs fire we should be fixing the calling code instead.
BUG=4359
R=magjed@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46639004
Cr-Commit-Position: refs/heads/master@{#8779}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8779 4adac7df-926f-26a2-2b94-8c16560cd09d
Diffstat (limited to 'webrtc/video_frame.h')
| -rw-r--r-- | webrtc/video_frame.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h index c99dc63f52..67699a49eb 100644 --- a/webrtc/video_frame.h +++ b/webrtc/video_frame.h @@ -32,6 +32,9 @@ class I420VideoFrame { uint32_t timestamp, int64_t render_time_ms); + // TODO(pbos): Make all create/copy functions void, they should not be able to + // fail (which should be DCHECK/CHECKed instead). + // CreateEmptyFrame: Sets frame dimensions and allocates buffers based // on set dimensions - height and plane stride. // If required size is bigger than the allocated one, new buffers of adequate |