diff options
Diffstat (limited to 'talk')
-rw-r--r-- | talk/media/webrtc/webrtcvideocapturer.cc | 7 | ||||
-rw-r--r-- | talk/media/webrtc/webrtcvideocapturer.h | 4 | ||||
-rw-r--r-- | talk/media/webrtc/webrtcvideoengine2.cc | 6 | ||||
-rw-r--r-- | talk/media/webrtc/webrtcvideoengine2_unittest.cc | 5 | ||||
-rw-r--r-- | talk/media/webrtc/webrtcvideoengine2_unittest.h | 2 |
5 files changed, 13 insertions, 11 deletions
diff --git a/talk/media/webrtc/webrtcvideocapturer.cc b/talk/media/webrtc/webrtcvideocapturer.cc index aaa6f1e480..0e8f56bfdd 100644 --- a/talk/media/webrtc/webrtcvideocapturer.cc +++ b/talk/media/webrtc/webrtcvideocapturer.cc @@ -353,8 +353,9 @@ bool WebRtcVideoCapturer::GetPreferredFourccs( return true; } -void WebRtcVideoCapturer::OnIncomingCapturedFrame(const int32_t id, - webrtc::I420VideoFrame& sample) { +void WebRtcVideoCapturer::OnIncomingCapturedFrame( + const int32_t id, + const webrtc::I420VideoFrame& sample) { // This would be a normal CritScope, except that it's possible that: // (1) whatever system component producing this frame has taken a lock, and // (2) Stop() probably calls back into that system component, which may take @@ -395,7 +396,7 @@ void WebRtcVideoCapturer::OnCaptureDelayChanged(const int32_t id, } void WebRtcVideoCapturer::SignalFrameCapturedOnStartThread( - webrtc::I420VideoFrame* frame) { + const webrtc::I420VideoFrame* frame) { DCHECK(start_thread_->IsCurrent()); // Signal down stream components on captured frame. // The CapturedFrame class doesn't support planes. We have to ExtractBuffer diff --git a/talk/media/webrtc/webrtcvideocapturer.h b/talk/media/webrtc/webrtcvideocapturer.h index c0f7807e6f..56896f9cd6 100644 --- a/talk/media/webrtc/webrtcvideocapturer.h +++ b/talk/media/webrtc/webrtcvideocapturer.h @@ -81,7 +81,7 @@ class WebRtcVideoCapturer : public VideoCapturer, private: // Callback when a frame is captured by camera. virtual void OnIncomingCapturedFrame(const int32_t id, - webrtc::I420VideoFrame& frame); + const webrtc::I420VideoFrame& frame); virtual void OnCaptureDelayChanged(const int32_t id, const int32_t delay); @@ -91,7 +91,7 @@ class WebRtcVideoCapturer : public VideoCapturer, // directly from OnIncomingCapturedFrame. // TODO(tommi): Remove this workaround when we've updated the WebRTC capturers // to follow the same contract. - void SignalFrameCapturedOnStartThread(webrtc::I420VideoFrame* frame); + void SignalFrameCapturedOnStartThread(const webrtc::I420VideoFrame* frame); rtc::scoped_ptr<WebRtcVcmFactoryInterface> factory_; webrtc::VideoCaptureModule* module_; diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc index af00928004..e6f59d12ef 100644 --- a/talk/media/webrtc/webrtcvideoengine2.cc +++ b/talk/media/webrtc/webrtcvideoengine2.cc @@ -1412,11 +1412,11 @@ void WebRtcVideoChannel2::WebRtcVideoSendStream::InputFrame( SetDimensions( video_frame_.width(), video_frame_.height(), capturer->IsScreencast()); - LOG(LS_VERBOSE) << "SwapFrame: " << video_frame_.width() << "x" + LOG(LS_VERBOSE) << "IncomingCapturedFrame: " << video_frame_.width() << "x" << video_frame_.height() << " -> (codec) " << parameters_.encoder_config.streams.back().width << "x" << parameters_.encoder_config.streams.back().height; - stream_->Input()->SwapFrame(&video_frame_); + stream_->Input()->IncomingCapturedFrame(video_frame_); } bool WebRtcVideoChannel2::WebRtcVideoSendStream::SetCapturer( @@ -1436,7 +1436,7 @@ bool WebRtcVideoChannel2::WebRtcVideoSendStream::SetCapturer( CreateBlackFrame(&black_frame, last_dimensions_.width, last_dimensions_.height); - stream_->Input()->SwapFrame(&black_frame); + stream_->Input()->IncomingCapturedFrame(black_frame); } capturer_ = NULL; diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc index 637ecf3d43..b29fc51519 100644 --- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc +++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc @@ -139,9 +139,10 @@ int FakeVideoSendStream::GetLastHeight() const { return last_frame_.height(); } -void FakeVideoSendStream::SwapFrame(webrtc::I420VideoFrame* frame) { +void FakeVideoSendStream::IncomingCapturedFrame( + const webrtc::I420VideoFrame& frame) { ++num_swapped_frames_; - last_frame_.SwapFrame(frame); + last_frame_.ShallowCopy(frame); } void FakeVideoSendStream::SetStats( diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.h b/talk/media/webrtc/webrtcvideoengine2_unittest.h index 1149949e06..770353540b 100644 --- a/talk/media/webrtc/webrtcvideoengine2_unittest.h +++ b/talk/media/webrtc/webrtcvideoengine2_unittest.h @@ -54,7 +54,7 @@ class FakeVideoSendStream : public webrtc::VideoSendStream, void SetStats(const webrtc::VideoSendStream::Stats& stats); private: - void SwapFrame(webrtc::I420VideoFrame* frame) override; + void IncomingCapturedFrame(const webrtc::I420VideoFrame& frame) override; webrtc::VideoSendStream::Stats GetStats() override; bool ReconfigureVideoEncoder( |