aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-12-05APM AGC2 InputVolumeController test: rename manager|agc -> controllerAlessio Bazzica
Bug: webrtc:7494 Change-Id: Iaa8144c07541042a543e48b2e726e2d4e20edb7c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286001 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38810}
2022-12-05Add fuchsia_perf_test to the default build group.Christoffer Jansson
Bug: b/232740856 Change-Id: Ifd4932cba4f8223f0baa2483a116bb29e47f66f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286240 Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38809}
2022-12-05AndroidNetworkMonitor - loosen assumptions even moreJonas Oreland
This cl/ attempts to fix (rather) rare crashes in OnNetworkConnected_n by loosening the assumptions that a network handle will keep it's network name. With this cl/ it is possible that a NetworkHandle can call OnNetworkConnected_n with one interface name and then directly afterwards call it with another ( w/o an OnNetworkDisconnected_n inbetween). This is the only scenario in which I could see the previous crash occurring. i.e OnNetworkConnected(handle, "some-if-name") OnNetworkConnected(handle, "some-other-name") - previously this caused crash, - now this is treated as if there was an OnNetworkDisconnected(handle) in between. --- Also 1: shamelessly copy TYPE_MOBILE_DUN & TYPE_MOBILE_HIPRI from chromium: https://eureka-internal.git.corp.google.com/chromium/src/+/87987f0e76e5c045d7196b5da904dc17ce254ba3?pli=1 Also 2: Modify testcase not to use real interface names, so I can ran them on personal test phone w/o the real networks interfering. Bug: webrtc:13741 Change-Id: I5480d5ce7031c2b5c09b958064076d02b3db1248 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285980 Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38808}
2022-12-05Make iOS tests read --webrtc_test_metrics_output_path.Mirko Bonadei
Differently from the ChromePerfDashboardMetricsExporter, this new flag doesn't default to storing the output file to NSDocumentDirectory (and with a default name, for example perftest-output.pb) but instead just stores the file at the location specified by --webrtc_test_metrics_output_path. Bug: b/237982523 Change-Id: Ibb504fdbc94ca5179f4b3da5b06d8cea82140140 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286280 Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38807}
2022-12-05Fix unaligned memory access detected by UBSANByoungchan Lee
Recently, Chromium added -fsanitize=alignment for `is_ubsan=true`, and due to this, unaligned memory access was found in several places, and chromium roll is currently blocked. Modify unaligned memory access in rtc_base/byte_order.h to use memcpy. Since libaom and libsrtp perform unaligned memory accesses, add them to the suppression list. Also, remove any mention of yasm from the UBSAN suppression list, as yasm is no longer used. Bug: chromium:1057551 Change-Id: I4961b66831750f4fa7b6de0b80b2052fe6ef27c5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286200 Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38806}
2022-12-05Update WebRTC code version (2022-12-05T04:02:09).webrtc-version-updater
Bug: None Change-Id: Ie3d1ebfef56e27fd6b0b64d4a5beb0393476d52d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286187 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#38805}
2022-12-04Add new linux code coverage botBjörn Terelius
Bug: b/236797073 Change-Id: I7acd8cbe12c1fe7455db337515178e28dffda523 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285940 Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38804}
2022-12-03Update WebRTC code version (2022-12-03T04:11:05).webrtc-version-updater
Bug: None Change-Id: I003d966f85910bca12e8f59f7849c60895594158 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286040 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#38803}
2022-12-02Reland "Add working Perf tests for Fuchsia"Jeremy Leconte
This is a reland of commit d8d86bd3329d05fdcc5402140917eb70b340c9c6 Original change's description: > Add working Perf tests for Fuchsia > > Utilize VM in perf pool for Fuchsia (separate CL) > > Bug: b/232740856 > Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721 > Reviewed-by: Jeremy Leconte <jleconte@google.com> > Commit-Queue: Christoffer Jansson <jansson@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38787} Bug: b/232740856 Change-Id: I3ae8b17990157bde4a08fd8a98379cffd2c38148 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285881 Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38802}
2022-12-02Update Fuchsia emulatorChristoffer Jansson
Bug: b/232740856 Change-Id: Iace75acac459abaae60ff95c65114efdd20d5ef8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/286000 Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38801}
2022-12-02Use ScopedFieldTrials in FieldTrialsTestEmil Lundmark
Resetting the global state between runs was previously handled by a RAII type, but the semantics of that type changed to remove this behavior in [1]. [1] https://webrtc-review.googlesource.com/c/src/+/276269 Bug: webrtc:14731, webrtc:14705 Change-Id: I8425cb71f49ea000434d500e0b3978324e4c3195 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285782 Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38800}
2022-12-02APM: Prepare to remove `AdaptiveDigitalGainController` wrapperAlessio Bazzica
Isolates the build targets for the `AdaptiveDigitalGainController` dependencies that will be moved into `GainController2`. `AdaptiveDigitalGainController` will be removed because the wrapper itself adds little - that's the reason why it has no unit tests. Bug: webrtc:7494 Change-Id: I2ca41f9255c8faefe4b2cb4ec1f8db536e582f39 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280482 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38799}
2022-12-02Fix AndroidNetworkMonitorTests crash due to DCHECK failureByoungchan Lee
AndroidNetworkMonitor::SetNetworkInfos assumes this method is called only once, but unittests calls it twice. One is called by the startMonitoring Java method, and the other is called by each test. Because of this, these tests will not succeed if dcheck_always_on is true. To solve this problem, use OnNetworkConnected_n instead of SetNetworkInfos in each test. Bug: None Change-Id: I027706ad5ccd597a91e3a66f15e181ee22d4aaa9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285861 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Cr-Commit-Position: refs/heads/main@{#38798}
2022-12-02Add a column_limit=80 to yapf setup.cfgJeremy Leconte
Also apply the formatting to the .pyl files. Change-Id: I5dc668b53570d042862d2de5948b72d1cf6d31b3 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285941 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38797}
2022-12-02Rename test helper for registering field trial keysEmil Lundmark
This new name emphasizes that the field trial keys are only allowed within the current scope. We already have test::ScopedFieldTrials that can be used to ensure that the global field trials string itself is isolated. Bug: webrtc:14705 Change-Id: I8b66bbd9c11d97985292c334d2d3496a047074a1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284862 Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38796}
2022-12-02InputVolumeController: readability improvementsAlessio Bazzica
- use the new naming convention 'input volume' - fix Yoda-style expressions in the unit tests - clarify how the gain map values are generated Bug: webrtc:7494 Change-Id: I4d6ee897a93cdefa6735733b053c57326d01a528 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285467 Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Hanna Silen <silen@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38795}
2022-12-02Reland "Remame VideoSendStream::UpdateActiveSimulcastLayers to ↵Per Kjellander
StartPerRtpStream" This reverts commit 75170be4acc90fece7c65f1a5b9bef03a5cc3880. Reason for revert: Perf regression not affecting open source. Original change's description: > Revert "Remame VideoSendStream::UpdateActiveSimulcastLayers to StartPerRtpStream" > > This reverts commit d8c4de71722c9de38f942932be21d4015f32a3bc. > > Reason for revert: Tentative revert due to possible perf regression. b/260123362 > > Original change's description: > > Remame VideoSendStream::UpdateActiveSimulcastLayers to StartPerRtpStream > > > > VideoSendStreamImpl::Start and VideoSendStream::Start are not used by PeerConnections, only StartPerRtpStream. > > Therefore this cl: > > - Change implementation of VideoSendStream::Start to use VideoSendStream::StartPerRtpStream. VideoSendstream::Start is kept for convenience. > > - Remove VideoSendStreamImpl::Start() since it was only used by tests that use call and is confusing. > > - RtpVideoSender::SetActive is removed/changed to RtpVideoSender::Stop(). For normal operations RtpVideoSender::SetActiveModules is used. > > > > Bug: none > > Change-Id: I43b153250b07c02fe63c84e3c4cec18d4ec0d47a > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283660 > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Commit-Queue: Per Kjellander <perkj@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#38698} > > Bug: none > Change-Id: I4f0d27679e51361b9ec54d2ae8e4d972527875d1 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284940 > Reviewed-by: Per Kjellander <perkj@webrtc.org> > Commit-Queue: Erik Språng <sprang@webrtc.org> > Auto-Submit: Per Kjellander <perkj@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38725} Bug: b/260400659 Change-Id: Ie8e545edcad85284a7d612183a8e4201672d0b5e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285900 Auto-Submit: Per Kjellander <perkj@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#38794}
2022-12-02Always use dedicated queue for frame transformationEvan Shrubsole
The current logic has risks if the encoder queue changes, for example when switching from a hardware encoder to a software encoder, or when switching from two different software implementations. Always using a dedicated task queue simplifies the code and is safer. Bug: chromium:1395308 Change-Id: I0a576ed2f6e892955e0a519567969474d3b99efd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285882 Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38793}
2022-12-02Add infra owners fileChristoffer Jansson
Bug: b/260832909 Change-Id: I6a9e50d37362e05b688560dc4594b37cba03f1ff Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285760 Reviewed-by: Jeremy Leconte <jleconte@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38792}
2022-12-02Delete RGB to I420 and YUV to IVF convertersSergey Silkin
Use external tools like ffmpeg instead. Bug: webrtc:10138 Change-Id: Ia73b2724aefb0688d002e7d6d8bb04df2d284a25 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38791}
2022-12-01Revert "Add working Perf tests for Fuchsia"Jeremy Leconte
This reverts commit d8d86bd3329d05fdcc5402140917eb70b340c9c6. Reason for revert: Seems this causes an issue with the dimensions ? File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_modules/swarming/api.py", line 463, in with_dimensions assert isinstance(k, basestring) and (isinstance(v, basestring) Original change's description: > Add working Perf tests for Fuchsia > > Utilize VM in perf pool for Fuchsia (separate CL) > > Bug: b/232740856 > Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721 > Reviewed-by: Jeremy Leconte <jleconte@google.com> > Commit-Queue: Christoffer Jansson <jansson@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#38787} Bug: b/232740856 Change-Id: Ibedff26cfe38fae0eb36158d5cd9f2bdfded319f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285800 Reviewed-by: Jeremy Leconte <jleconte@google.com> Auto-Submit: Jeremy Leconte <jleconte@google.com> Commit-Queue: Jeremy Leconte <jleconte@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38790}
2022-12-01Expose APM pipeline parameter to select downmixing methodAlessio Bazzica
Bug: b/257289030 Change-Id: I03a666a15752d7a1125af2f8d3edae530493618c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285473 Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38789}
2022-12-01Update some audio modules with new OWNERSHenrik Lundin
Bug: b/260832909 Change-Id: I3d2ebad978988eabf228475c3fc46708e12cf5d2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285780 Auto-Submit: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38788}
2022-12-01Add working Perf tests for FuchsiaChristoffer Jansson
Utilize VM in perf pool for Fuchsia (separate CL) Bug: b/232740856 Change-Id: Ia69f72bbf2046db3bc9b1e5edabda6cc4a339fe6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285721 Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38787}
2022-12-01Delete deprecated disable_ipv6 flag.Henrik Boström
M108 Stable has been released, which does not contain googIPv6 anymore, and today the last downstream dependency on this flag was removed. Let's delete! Bug: webrtc:14608 Change-Id: Ia2d201f0da04b14961f891687b6135fc69b7767e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285720 Auto-Submit: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38786}
2022-12-01In RemoteBitrateEstimator unwrap remote_rate_ member from unique_ptrDanil Chapovalov
That member is always created during construction and thus doesn't need to be wrapped into unique_ptr and rechecked for beeing nullptr Bug: None Change-Id: I5d608c9b7bdfd8ec6e3296245359610ec1cf176c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285660 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38785}
2022-12-01Remove deprecated rtc::StreamInterface functionsHarald Alvestrand
This cleans up the last vestiges of the old interface for rtc::StreamInterface and will cause builds to refer to the old functions to fail. Bug: webrtc:14632 Change-Id: I569b16677754d7f9e08449e273672a59a86e6498 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283844 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38784}
2022-11-30Remove default enabled field trial WebRTC-SendSideBwe-WithOverheadPer Kjellander
Bug: webrtc:6762 Change-Id: I520188a13ee5f50c441226574ccb3df54f842835 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285300 Reviewed-by: Peter Hanspers <peterhanspers@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38783}
2022-11-30Extend mocks for public typesJack Smith
Extends the mocks for rtpreceiver rtpsender and videotrack. This change allows the external HangoutsKit client to remove its own mocks of rtc types. Bug: none Change-Id: I8ba1752fe7633f9e0bba264a1279f74cc1368a2c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282900 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Jack Smith <jackdsmith@google.com> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38782}
2022-11-30Disable Fuchsia perf tests.Jeremy Leconte
Change-Id: Iad6db19fa0ae3bd912ce072b161378e3e5db649a Bug: b/232740856 No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285662 Owners-Override: Jeremy Leconte <jleconte@google.com> Reviewed-by: Jeremy Leconte <jleconte@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38781}
2022-11-30APM: Add a field trial for input volume controllerHanna Silen
Add a field trial WebRTC-Audio-InputVolumeControllerExperiment and a mechanism to adjust the config accordingly. Pass the additional input volume controller config to GainController2. Bug: webrtc:7494 Change-Id: I3dd624df1f4774cb533417747627995e1f60aa68 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284101 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Hanna Silen <silen@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38780}
2022-11-30Delete WebRTC-Bwe-TransportWideFeedbackIntervals as unusedDanil Chapovalov
Bug: webrtc:14179 Change-Id: Id8ab9467293a2ea53a411d217024c64e9f48da85 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285640 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38779}
2022-11-30Disable tests again on 'Win32 Debug (Clang)'.Jeremy Leconte
module_unittests are failing with SEH exceptions. Change-Id: Ic29def1d0f0c5976c1452e198cec2ee67dcaad9a Bug: webrtc:14723 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285472 Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38778}
2022-11-30Remove xooglers from WATCHLISTS and OWNERSChristoffer Jansson
Bug: b/260832909 Change-Id: I683c714da35c21c23404d4b1c6500da28d680ed5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285470 Commit-Queue: Christoffer Jansson <jansson@google.com> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38777}
2022-11-30AudioProcessingImpl: Add the use of AGC2 InputVolumeControllerHanna Silen
The integration relies on GainController2 methods Process() and GetRecommendedInputVolume() to internally take into account whether the input volume controller is enabled in the ctor or not. These methods are called for every frame processed if GainController2 is enabled. Analyze() is called if the input volume controller is enabled. The functionality can be enabled from the APM config and is not enabled by default. If multiple input volume controllers are enabled, an error is logged. Tested: Bitexact on a large number of aecdumps if not enabled Bug: webrtc:7494 Change-Id: I9105483be34eb95fab3c46afbbd368802e956fad Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282720 Reviewed-by: Alessio Bazzica <alessiob@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Commit-Queue: Hanna Silen <silen@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38776}
2022-11-30Specify the Windows version to run the CI tests.Jeremy Leconte
Change-Id: I2a9f1d266ef5fe4d1e43431964f44a1f995c7490 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285468 Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38775}
2022-11-30Fix bugs in discarding stun addressKyutae Lee
If mdns obfuscation is enabled, the stun address "MUST NOT be considered redundant" when it is equal to local socket address. Reference: https://datatracker.ietf.org/doc/html/draft-ietf-mmusic-mdns-ice-candidates-03#section-3.1.2.2 This fixes Bug: webrtc:13426 Change-Id: I28e981fd1b8818f6f8294bc3fedf23b8d9146819 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285421 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38774}
2022-11-30Ensure audio quality tools are downloaded on FuchsiaChristoffer Jansson
Bug: b/232769791 Change-Id: I030b25d589282042bb37ccf85c523541e3bcdbd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285620 Reviewed-by: Jeremy Leconte <jleconte@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@google.com> Cr-Commit-Position: refs/heads/main@{#38773}
2022-11-30Run tests on Windows CI for Release and Debug configuration.Jeremy Leconte
Currently the tests are running only on Windows x86 Release. * Windows capture_tests are moved to run on x64. * win_x64_clang_dbg_win10 is removed because it's a duplicate of * win_x64_clang_dbg. Change-Id: Ibf4db1d1749aa31d665ad30825e9dcfef6910be4 Bug: None Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285540 Reviewed-by: Christoffer Jansson <jansson@google.com> Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38772}
2022-11-30Silence Mac OpenGL deprecationAvi Drissman
macOS has deprecated OpenGL as of macOS 10.14. Chromium is moving to using Metal more and more, but we're going to be forced to keep using OpenGL, so explicitly silence the OpenGL deprecation warnings. Bug: chromium:1393687 Change-Id: I668e8d9bf57669f715f341f940ea12f3293faa9a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285560 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38771}
2022-11-29[DesktopCapture]: Allow toggling the visibility of the cursorMichał Zarach
This is a change needed to implement (cursor: 'never') https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings/cursor constraint. Bug: chromium:1007177 Change-Id: Id7fae62de180d46a3874856978a3fda559aa6477 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282861 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#38770}
2022-11-29AGC2 Input Volume Controller: min input volume field trial updateAlessio Bazzica
Always enforce the minimum input volume, not only if overridden. The only exception is when the applied input volume is zero: in that case zero is still recommended. This CL also adapts the unit tests and replaces "mic level" with the "input volume". Bug: webrtc:7494 Change-Id: I20c14624fbd357ab91ea05521c3723ec1045a8db Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285462 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38769}
2022-11-29Fixed timestamp_offset for RtpSenderEgress during initialization and ↵Dan Tan
SetRtpState call The constructor and SetRtpState calls for ModuleRtpRtcpImpl2 class fail to propagate the RTP timestamp offset of RtpSender class to RtpSenderEgress class. This results in wrong RTP timestamps being propagated in LossNotification messages. Change-Id: I1d293289a4815de29d9dd15208bb7fd1a682be82 Bug: webrtc:14719 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284824 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Dan Tan <dwtan@google.com> Cr-Commit-Position: refs/heads/main@{#38768}
2022-11-29Limit number of TURN servers to 32Philipp Hancke
Limit the number of TURN servers to 32 in order to allow the prioritization to assume a fixed offset for (de)prioritizing candidates. See https://github.com/w3c/webrtc-pc/pull/2679 for discussion including some data on current usage. Guarded by WebRTC-LimitTurnServers which is used as a killswitch. BUG=webrtc:13195 Change-Id: Ib12726af426ae4238aa7eb6aa062c71af52d495f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285340 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38767}
2022-11-29Replace iwyu rules for libcxx with reference to rules maintain by the libraryDanil Chapovalov
No-Try: True Bug: None Change-Id: Ie79dbb1fd5e0b544ca0ea41a58eabd1967e7d5e7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285481 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38766}
2022-11-29Move declaration of --export_perf_results_new_api.Mirko Bonadei
By declaring and defining the flag in a separate and reusable library it can be used by other main() implementations as well. Bug: b/237982523 Change-Id: Ia5445ee6e85bc1d536bee2ddd842439f8832116b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285480 Commit-Queue: Jeremy Leconte <jleconte@google.com> Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38765}
2022-11-29Rename VideoFrameMetadata tests to RTPVideoHeaderTest.Henrik Boström
This is a pure move/rename. The reason for wanting the tests in RTPVideoHeader is that it is the GetAsMetadata() function that we are testing and in a future CL we'll also want to test SetFromMetadata(). // Bots green, no need to wait for the remaining ones, just a move NOTRY=True Bug: webrtc:14709 Change-Id: Iecb938e79e7e8d55e208baea190eef4c6730158e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285460 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38764}
2022-11-29Rename Win 7 to Win 10 to reflect whats being benchmarkedChristoffer Jansson
Bug: None Change-Id: If41eb2d47ee381afba66a9a62e1b7d9481df4efb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285465 Reviewed-by: Jeremy Leconte <jleconte@google.com> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38763}
2022-11-29Roll chromium_revision 8113154ab7..6d86775bf1 (1076706:1076834)chromium-webrtc-autoroll
Change log: https://chromium.googlesource.com/chromium/src/+log/8113154ab7..6d86775bf1 Full diff: https://chromium.googlesource.com/chromium/src/+/8113154ab7..6d86775bf1 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/b4ae821cf6..e89ad07314 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/0efbd89bb5..198be41ce3 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/31d059e03a..0eee1cdab5 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/760f5a33d6..4e41634fa2 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/2f339b3151..ff621271b0 * src/third_party/androidx: DoMiLWGEPZ6MIrAeFkKaGQqFar0ez6bY0nwhdUVEIMMC..YqHXeju2kOGh8x26xULaEyiL6jpRD-vslKaU7czLvKwC * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc04ff1628..67828ff1bb * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/36fb00a3c3..600d527068 * src/third_party/r8: WqQE6kGnQ571Jtmn-m9LD7Qnd7nOi46mty5n-fZznKQC..RM1MB7AK90GPkspZ5TLRVyJNIC0JB4sz1rWL9JLLdNkC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/30a9474044..9353893e0e * src/tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:7a04ca7c0fd3e73cc09c817542a74d947e68b8c9 * src/tools/luci-go: git_revision:f8f64a8c560d2bf68a3ad1137979d17cffb36d30..git_revision:7a04ca7c0fd3e73cc09c817542a74d947e68b8c9 DEPS diff: https://chromium.googlesource.com/chromium/src/+/8113154ab7..6d86775bf1/DEPS No update to Clang. BUG=None Change-Id: I07463816b55cdfad5449ce2e8d46e01c866f3a72 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285404 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#38762}
2022-11-29Prevent 8 cores bots to be used by desktop perf tests.Jeremy Leconte
Change-Id: I2e2bc16ebc65f8207105d1dbd1a84788def5b63b Bug: b/260684409 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285461 Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#38761}
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-28 03:16:59 +0000