Age | Commit message (Collapse) | Author |
|
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1527143002 .
Patch from Jon Hjelle <hjon@andyet.net>.
Cr-Commit-Position: refs/heads/master@{#11208}
|
|
BUG=
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1540113002 .
Patch from Jon Hjelle <hjon@andyet.net>.
Cr-Commit-Position: refs/heads/master@{#11207}
|
|
BUG=webrtc:5260
R=åsapersson
Review URL: https://codereview.webrtc.org/1575023002
Cr-Commit-Position: refs/heads/master@{#11206}
|
|
Seems to fix asan-related crash.
BUG=https://code.google.com/p/chromium/issues/detail?id=570261
Review URL: https://codereview.webrtc.org/1571853002
Cr-Commit-Position: refs/heads/master@{#11205}
|
|
Defining use_third_party_h264 directly, and indirectly defining use_openh264 (from third_party/openh264) and ffmpeg_branding (from third_party/ffmpeg).
These will be used in a follow-up CL that adds an encoder and decoder implementation.
The flags are added in this CL so that they can be used by trybots/waterfall bots in GN without "Build argument had no effect" errors. Equivalent GYP changes are also added.
BUG=468365
Review URL: https://codereview.webrtc.org/1575913003
Cr-Commit-Position: refs/heads/master@{#11204}
|
|
BUG=
R=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1533193003 .
Patch from Jon Hjelle <hjon@andyet.net>.
Cr-Commit-Position: refs/heads/master@{#11203}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/42ab10e..8c958e0
Full diff: https://chromium.googlesource.com/chromium/src/+/42ab10e..8c958e0
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1575003002
Cr-Commit-Position: refs/heads/master@{#11202}
|
|
explicetly unchanged.
BUG=webrtc:5260
R=åsapersson
Review URL: https://codereview.webrtc.org/1578713002
Cr-Commit-Position: refs/heads/master@{#11201}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/e738b54..42ab10e
Full diff: https://chromium.googlesource.com/chromium/src/+/e738b54..42ab10e
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1573883002
Cr-Commit-Position: refs/heads/master@{#11200}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/7d97c94..e738b54
Full diff: https://chromium.googlesource.com/chromium/src/+/7d97c94..e738b54
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1572173002
Cr-Commit-Position: refs/heads/master@{#11199}
|
|
It started failing at the roll in
https://codereview.webrtc.org/1556273002
BUG=webrtc:5402
TBR=marpan@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1574813002
Cr-Commit-Position: refs/heads/master@{#11198}
|
|
#1 id:1 of https://codereview.webrtc.org/1577573002/ )
Reason for revert:
Win DrMemory Full: video_engine_tests failed 1
https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/3465
Original issue's description:
> Roll chromium_revision 7d97c94..951c006 (368514:368525)
>
> Change log: https://chromium.googlesource.com/chromium/src/+log/7d97c94..951c006
> Full diff: https://chromium.googlesource.com/chromium/src/+/7d97c94..951c006
>
> No dependencies changed.
> No update to Clang.
>
> TBR=
>
> Committed: https://crrev.com/6109fc13aadebf7c5a990bbc78e981ab215321a6
> Cr-Commit-Position: refs/heads/master@{#11195}
TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.webrtc.org/1570403002
Cr-Commit-Position: refs/heads/master@{#11197}
|
|
TBR=guidou@webrtc.org
BUG=
Review URL: https://codereview.webrtc.org/1576723002 .
Cr-Commit-Position: refs/heads/master@{#11196}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/7d97c94..951c006
Full diff: https://chromium.googlesource.com/chromium/src/+/7d97c94..951c006
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1577573002
Cr-Commit-Position: refs/heads/master@{#11195}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/8a15a7f..7d97c94
Full diff: https://chromium.googlesource.com/chromium/src/+/8a15a7f..7d97c94
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1577543002
Cr-Commit-Position: refs/heads/master@{#11194}
|
|
TBR=kjellander@webrtc.org
BUG=5417
Review URL: https://codereview.webrtc.org/1575433003 .
Cr-Commit-Position: refs/heads/master@{#11193}
|
|
This meant splitting "transport_options" into audio/video/data options,
for when creating the answer, and giving "GetSslRole" a "transport_name"
parameter so we can retrieve the current role on a per-transport basis.
BUG=webrtc:4525
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1516993002 .
Cr-Commit-Position: refs/heads/master@{#11192}
|
|
* Better param names
* Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases.
* Use arraysize()
* Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers
* reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead
* Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition
* Fix indenting
* Use uint32_t for timestamps (matching how it's already a uint32_t in most places)
* Spelling
* RTC_CHECK_EQ(expected, actual)
* Rewrap
* Use .empty()
* Be more pedantic about matching int/int32_t/
* Remove pointless consts on input parameters to functions
* Add missing sanity checks
All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first.
BUG=none
TEST=none
Review URL: https://codereview.webrtc.org/1534193008
Cr-Commit-Position: refs/heads/master@{#11191}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/ede5d4f..8a15a7f
Full diff: https://chromium.googlesource.com/chromium/src/+/ede5d4f..8a15a7f
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1573583002
Cr-Commit-Position: refs/heads/master@{#11190}
|
|
BUG=webrtc:2692
Review URL: https://codereview.webrtc.org/1563983003
Cr-Commit-Position: refs/heads/master@{#11189}
|
|
NOTRY=True
BUG=5407
TBR=stefan@webrtc.org,pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1569273003
Cr-Commit-Position: refs/heads/master@{#11188}
|
|
This allows the test to create its own transports if it, for instance, needs to do demuxing.
BUG=webrtc:5416
Review URL: https://codereview.webrtc.org/1573453002
Cr-Commit-Position: refs/heads/master@{#11187}
|
|
patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/
This reverts commit bc14164aad254e72ce4d1e381b912b7d3acf5391.
We have made more preparations downstream, so this should work now. Original CL by perkj@.
BUG=webrtc:2365
The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/
Review URL: https://codereview.webrtc.org/1570513004
Cr-Commit-Position: refs/heads/master@{#11186}
|
|
To ease use of WebRTC in other codebases, update some macros
to match glibc's ansidecl.h, which uses double-underscores for attributes.
NOTRY=True
Review URL: https://codereview.webrtc.org/1571653002
Cr-Commit-Position: refs/heads/master@{#11185}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/32569c6..ede5d4f
Full diff: https://chromium.googlesource.com/chromium/src/+/32569c6..ede5d4f
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1567393002
Cr-Commit-Position: refs/heads/master@{#11184}
|
|
BUG=webrtc:5167
R=pbos@webrtc.org
NOTRY=true
Review URL: https://codereview.webrtc.org/1571693002
Cr-Commit-Position: refs/heads/master@{#11183}
|
|
Ask the OS for the mic volume every 1 second rather than with every 10
ms chunk. The previous behavior was consuming ~2% of the CPU load of
a voice engine call, and is now negligible.
This is consistent with the webrtc Windows Core Audio implementation,
as well as the Chromium Mac implementation:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/agc_audio_stream.h
TEST=voe_cmd_test with AGC continues to work well on Mac.
Review URL: https://codereview.webrtc.org/1564223002
Cr-Commit-Position: refs/heads/master@{#11182}
|
|
TEST= export GYP_DEFINES="OS=android clang=1" ...
ninja -C out/Debug AppRTCDemo
BUG=webrtc:5399
Review URL: https://codereview.webrtc.org/1561073005
Cr-Commit-Position: refs/heads/master@{#11181}
|
|
screenshare). Add unittest.
BUG=
Review URL: https://codereview.webrtc.org/1543933004
Cr-Commit-Position: refs/heads/master@{#11180}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/6dd04c2..32569c6
Full diff: https://chromium.googlesource.com/chromium/src/+/6dd04c2..32569c6
Changed dependencies:
* src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/1ccbf8f..fc52d8d
DEPS diff: https://chromium.googlesource.com/chromium/src/+/6dd04c2..32569c6/DEPS
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1570713002
Cr-Commit-Position: refs/heads/master@{#11179}
|
|
NOTRY=True
BUG=webrtc:5414
TBR=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1572503002
Cr-Commit-Position: refs/heads/master@{#11178}
|
|
BUG=webrtc:5209
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1570563002 .
Cr-Commit-Position: refs/heads/master@{#11177}
|
|
This means that the track will still have a reference count after the
PeerConnection and RtpSender have been destroyed.
R=glaznev@webrtc.org, pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1566103003 .
Cr-Commit-Position: refs/heads/master@{#11176}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/bd5949f..6dd04c2
Full diff: https://chromium.googlesource.com/chromium/src/+/bd5949f..6dd04c2
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1568963002
Cr-Commit-Position: refs/heads/master@{#11175}
|
|
Problem is described here:
https://code.google.com/p/webrtc/issues/detail?id=4554
Review URL: https://codereview.webrtc.org/1295603002
Cr-Commit-Position: refs/heads/master@{#11174}
|
|
Tests were failing on android with new libvpx.
vp9 speed setting was changed to 8 recently and some recent changes
in libvpx require update for the tests to pass.
TBR=stefan@webrtc.org
BUG=webrtc:5401
Review URL: https://codereview.webrtc.org/1569903002 .
Cr-Commit-Position: refs/heads/master@{#11173}
|
|
BUG=
Review URL: https://codereview.webrtc.org/1543033003
Cr-Commit-Position: refs/heads/master@{#11172}
|
|
Add audio send and receive streams to CallTest and call the necessary voice engine APIs for the streams to be usable. Verifies the implementation by adding a simple test which monitors outgoing packets and checks that both audio and video is being sent with transport sequence numbers.
Audio streams are using a fake audio device with file input.
The CallTest implementation is to a big degree based on call_perf_tests.cc and should in the future replace a lot of that code.
R=pbos@webrtc.org
TBR=kjellander@webrtc.org
BUG=webrtc:5263
Review URL: https://codereview.webrtc.org/1542653002 .
Cr-Commit-Position: refs/heads/master@{#11171}
|
|
BUG=webrtc:4897
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1555673002
Cr-Commit-Position: refs/heads/master@{#11170}
|
|
BUG=webrtc:5132
R=asapersson@webrtc.org
Review URL: https://codereview.webrtc.org/1556703002 .
Cr-Commit-Position: refs/heads/master@{#11169}
|
|
BUG=webrtc:5058
Review URL: https://codereview.webrtc.org/1554163002
Cr-Commit-Position: refs/heads/master@{#11168}
|
|
Also voids ::Codec which always passed.
BUG=
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1464313004 .
Cr-Commit-Position: refs/heads/master@{#11167}
|
|
Removes multiple index lookups to generated_fec_packets_ speeding up
FecTest.FecTest with >2x in both Debug and Release, improving
performance but also readability.
On Debug this means that the slowest test in modules_tests now takes
~15-20 seconds instead of 50+ seconds, reducing the overall bottleneck.
BUG=webrtc:4712
R=stefan@webrtc.org
Review URL: https://codereview.webrtc.org/1552563003 .
Cr-Commit-Position: refs/heads/master@{#11166}
|
|
streams
TBR=tkchin_webrtc
BUG=b/25343768
Review URL: https://codereview.webrtc.org/1527143007 .
Cr-Commit-Position: refs/heads/master@{#11165}
|
|
Change log: https://chromium.googlesource.com/chromium/src/+log/4662d4f..bd5949f
Full diff: https://chromium.googlesource.com/chromium/src/+/4662d4f..bd5949f
No dependencies changed.
No update to Clang.
TBR=
Review URL: https://codereview.webrtc.org/1562313002
Cr-Commit-Position: refs/heads/master@{#11164}
|
|
Review URL: https://codereview.webrtc.org/1570473002
Cr-Commit-Position: refs/heads/master@{#11163}
|
|
I had to fix the audio_device BUILD.gn which was forgotten back
in https://codereview.webrtc.org/1536923003. It also contained a few
missing source files and one library.
Change log: https://chromium.googlesource.com/chromium/src/+log/2a70cb1..4662d4f
Full diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f
Changed dependencies:
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/6d0c448..0f8e6e4
* src/third_party/libsrtp: https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/8a7662a..ebfcc9a
DEPS diff: https://chromium.googlesource.com/chromium/src/+/2a70cb1..4662d4f/DEPS
No update to Clang.
TBR=henrika@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1565093002
Cr-Commit-Position: refs/heads/master@{#11162}
|
|
Update test implementation (test/histograms.h) to be more similar a real implementation (where histogram get functions return a Histogram pointer). Add check that the name of a histogram does not change.
BUG=webrtc:5283
Review URL: https://codereview.webrtc.org/1528403003
Cr-Commit-Position: refs/heads/master@{#11161}
|
|
This CL is a follow-up on https://codereview.webrtc.org/1452903006/ which
moved the definition of SocketDispatcher to physicalsocketserver.h.
Here the duplicate implementations are merged with only some #ifdef parts.
BUG=
Review URL: https://codereview.webrtc.org/1537273002
Cr-Commit-Position: refs/heads/master@{#11160}
|
|
Mac 32-bit support has been gone in Chromium for a long time, but was
removed in https://codereview.chromium.org/1557823002. This called
for finally removing our Mac 32-bit builds, which was done in
http://crbug.com/574320.
Change log: https://chromium.googlesource.com/chromium/src/+log/4df108a..2a70cb1
Full diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1
Changed dependencies:
* src/third_party/libvpx_new/source/libvpx: https://chromium.googlesource.com/webm/libvpx.git/+log/ecb8dff..a9dd8a7
* src/third_party/nss: https://chromium.googlesource.com/chromium/deps/nss.git/+log/aee1b12..225bfc3
DEPS diff: https://chromium.googlesource.com/chromium/src/+/4df108a..2a70cb1/DEPS
No update to Clang.
TBR=marpan@webrtc.org, stefan@webrtc.org,
BUG=webrtc:5401, webrtc:5402
NOTRY=True
Review URL: https://codereview.webrtc.org/1556273002
Cr-Commit-Position: refs/heads/master@{#11159}
|