Age | Commit message (Collapse) | Author |
|
|
|
* We should enable those warnings after fixing the upstream source code.
Bug: 64487164
Test: build with WITH_TIDY=1
Change-Id: I306b4eb26fc8729f21cab4d5b82c9e3b59d8db3e
|
|
|
|
Native tests are also moved.
Test: mma -j BOARD_VNDK_VERSION=current
Test: m -j -k BOARD_VNDK_VERSION=current has no errors for webrtc
Bug: 62489821
Change-Id: I7f182403c2dabafc20b53f1046f68c1af81cede2
|
|
|
|
|
|
Fix a missing dependency.
Test: mma -j
Test: m -j -k BOARD_VNDK_VERSION=current has no error for webrtc
Bug: 62489821
Merged-In: I479a4addb59b42dd86cc5dfa02cd4ff6d1b6d626
Change-Id: I479a4addb59b42dd86cc5dfa02cd4ff6d1b6d626
(cherry picked from commit c6f833ab1ab6ccb6e0401fa61a182c516b849d87)
|
|
Native tests are not moved. Tests include:
webrtc_apm_process_test
webrtc_isac_test
webrtc_apm_unit_test
Test: mma -j
Test: m -j -k BOARD_VNDK_VERSION=current has no errors for webrtc
Bug: 62489821
Merged-In: I013303de263866cbf368f3f89327c5357f9cecdb
Change-Id: I013303de263866cbf368f3f89327c5357f9cecdb
(cherry picked from commit 8df7e85368569b7cd0afc1ce231b8b3a0ab49333)
|
|
|
|
These functions are identical. BoringSSL added these APIs, then OpenSSL
1.1.0 added similar ones but with slightly longer names. We're
standardizing on the OpenSSL names to avoid API skew.
This is a cherry-pick of https://codereview.webrtc.org/2550423004.
Test: mma
Change-Id: Iffe4416bd300d71bbaa94c7c127ae89d6286cd7b
|
|
|
|
* Modeled after Elliott Hughes' commit here: I82fb692c758d4855efa12ca7b743ce2893776a77
* Allows for compatibility with ARMv8
Test: mm
Change-Id: Ic80b0ff9416c781efed1b9686b6dff077c75e673
|
|
am: 82eac3519a
Change-Id: Ief7d3570c88e66d7be19dd4eee8a3bab2e39899d
|
|
|
|
We should not copy OWNERS files from upstream,
or the owners should be registered in Gerrit Code Review.
Bug: 33166666
Test: default build targets
Change-Id: Ibfd47e643f03678bb65880653383adb84809169d
|
|
am: 3f1ab425f5
Change-Id: I3dd1a638a4cfa377f398d90bd9896f2d1f03b813
|
|
am: b33ba455c4
Change-Id: I9d47a4379da6c4c88c0847c8fca6d4a2c799ca15
|
|
|
|
This fixes x86+arm multilib build.
Bug: 27526885
Test: Build system refactoring CL. Existing unit tests still pass.
Change-Id: I7290198a3671af3688cf125ffb1e6979344c0a8d
|
|
am: 0c90af9153
Change-Id: I640e45cb32c88c9b31c46fa6bb019a835d21c953
|
|
am: 8b409f342d
Change-Id: I2ca3f4b3a3b06e90cd1d4c9531adbcd33eb6020b
|
|
am: 0f2acd7beb
Change-Id: I8f758d065ce564bb6dd1e219ab1cf29776ea24d0
|
|
|
|
LOCAL_STATIC_LIBRARIES in a BUILD_STATIC_LIBRARY only imports C include
directories, it doesn't actually do any linking. Since this module is
building against the NDK, it shouldn't be referencing modules not built
against the NDK, like libprotobuf-cpp-lite. There are versions of that
library that may be more appropriate, but since there aren't any source
files, we don't need the include directories, so remove it entirely.
Change-Id: I47f7333228bea43979ce86c4bd23f4b2a92b49ce
|
|
am: 19b0dfaa7b
* commit '19b0dfaa7b027ac9197f122228374644352837e0':
|
|
|
|
am: 6dc914a60e
* commit '6dc914a60e74da53c9586e60a4e5e82a542e2393':
Add missing liblog dependency
|
|
|
|
Bug: http://b/27171986
Change-Id: Icdc4f8ce21b0aa51b651042b9f58bd88808066df
|
|
am: 14a01a403a
* commit '14a01a403a3a03350623687a5a5ca1e64a985224':
Suppress unused-parameter warnings.
|
|
|
|
Suppress warnings until upstream can fix them.
BUG: 27074506
Change-Id: If7e6f190100fba025d25d2634d1c9a657cc24854
|
|
am: 9a337512d9
* commit '9a337512d97e37afc142dee4fd50a41b741a87d2': (797 commits)
Add tests for verifying transport feedback for audio and video.
Eliminate defines in talk/
Revert of Update with new default boringssl no-aes cipher suites. Re-enable tests. (patchset #3 id:40001 of https://codereview.webrtc.org/1550773002/ )
Remove assert which was incorrectly added to TcpPort::OnSentPacket.
Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
Update with new default boringssl no-aes cipher suites. Re-enable tests.
Revert of Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. (patchset #3 id:40001 of https://codereview.webrtc.org/1577873003/ )
Re-land: "Use an explicit identifier in Config"
Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
Revert of Delete remnants of non-square pixel support from cricket::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/1586613002/ )
Remove libfuzzer trybot from default trybot set.
Add ramp-up tests for transport sequence number with and w/o audio.
Delete remnants of non-square pixel support from cricket::VideoFrame.
Fix IPAddress::ToSensitiveString() to avoid dependency on inet_ntop().
Revert of Storing raw audio sink for default audio track. (patchset #7 id:120001 of https://codereview.chromium.org/1551813002/ )
Re-enable tests that failed under Linux_Msan.
Revert of Use an explicit identifier in Config (patchset #4 id:60001 of https://codereview.webrtc.org/1538643004/ )
Roll chromium_revision 346fea9..099be58 (369082:369139)
Disable WebRtcVideoChannel2BaseTest.SendManyResizeOnce for TSan
Add build_protobuf variable.
...
|
|
|
|
* git merge 04cb763
* See all upstream changes since the previous merge in branch aosp/upstream-master: git diff cb3f9bd..04cb763
* Modify webrtc/.gitignore to keep *.mk files.
* Removed old files from *.mk files:
- thread.cc
- thread_posix.cc
* Add new files to *.mk files:
- event_tracer.cc
* Android relevant upstream changes:
- Make Beamforming dynamically settable for Android platform builds
- Remove additional channel constraints when Beamforming is enabled in AudioProcessing
- Use an explicit identifier in Config
Change-Id: I384a4e8f6982c31c5bc70eef521bb2d90800b9a4
|
|
BUG=webrtc:5263
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1589523002 .
Cr-Commit-Position: refs/heads/master@{#11255}
|
|
Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).
When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp
NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1588453005
Cr-Commit-Position: refs/heads/master@{#11254}
|
|
tests. (patchset #3 id:40001 of https://codereview.webrtc.org/1550773002/ )
Reason for revert:
We're getting boringssl version conflicts. Reverting for now.
Original issue's description:
> Update with new default boringssl no-aes cipher suites. Re-enable tests.
>
> This undoes https://codereview.webrtc.org/1533253002 (except the DEPS part).
>
> BUG=webrtc:5381
> R=davidben@webrtc.org, henrika@webrtc.org
>
> Committed: https://crrev.com/31c8d2eac5aec977f584ab0ae5a1d457d674f101
> Cr-Commit-Position: refs/heads/master@{#11250}
TBR=davidben@webrtc.org,henrika@webrtc.org,torbjorng@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5381
Review URL: https://codereview.webrtc.org/1586183002
Cr-Commit-Position: refs/heads/master@{#11253}
|
|
TBR=pthatcher@webrtc.org
BUG=webrtc:4173
Review URL: https://codereview.webrtc.org/1588083002 .
Cr-Commit-Position: refs/heads/master@{#11252}
|
|
Chromium reported errors when building libjingle_nacl due to some methods used virtual instead of override when they were overriding the base class. My guess is that when one method starts using override, all other in the same class must too.
R=tommi@webrtc.org
TBR=pthatcher@webtrc.org
BUG=4173
Review URL: https://codereview.webrtc.org/1589563003 .
Cr-Commit-Position: refs/heads/master@{#11251}
|
|
This undoes https://codereview.webrtc.org/1533253002 (except the DEPS part).
BUG=webrtc:5381
R=davidben@webrtc.org, henrika@webrtc.org
Review URL: https://codereview.webrtc.org/1550773002 .
Cr-Commit-Position: refs/heads/master@{#11250}
|
|
AsyncPacketSocket::SignalSentPacket. (patchset #3 id:40001 of https://codereview.webrtc.org/1577873003/ )
Reason for revert:
Broke Chrome:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/143025/steps/compile%20%28with%20patch%29/logs/stdio
FAILED: cd ../../third_party/libjingle; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Debug/xyz --config-name Debug -t ../../native_client/toolchain/ --arch pnacl --build newlib_plib --name ../../out/Debug/gen/tc_pnacl_newlib/lib/libjingle_nacl.a --objdir ../../out/Debug/obj/third_party/libjingle/libjingle_nacl.gen/pnacl_newlib-pnacl/libjingle_nacl "--include-dirs=../../out/Debug/gen/tc_pnacl_newlib/include ../.. \"../../out/Debug/gen\" ./source ../ ../../native_client_sdk/src/libraries ../../native_client_sdk/src/libraries/nacl_io/include ../../native_client_sdk/src/libraries/third_party/newlib-extras ../expat/files/lib ../boringssl/src/include" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function \"-std=gnu++11\" " --gomadir /b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS \"CLD_VERSION=2\" \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=255169-1\" COMPONENT_BUILD UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"IMAGE_LOADER_EXTENSION=1\" \"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" \"ENABLE_TOPCHROME_MD=1\" USE_UDEV DONT_EMBED_BUILD_METADATA \"DCHECK_ALWAYS_ON=1\" FIELDTRIAL_TESTING_ENABLED \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PDF=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL EXPAT_RELATIVE_PATH FEATURE_ENABLE_SSL GTEST_RELATIVE_PATH HAVE_OPENSSL_SSL_H NO_MAIN_THREAD_WRAPPING NO_SOUND_SYSTEM WEBRTC_POSIX SRTP_RELATIVE_PATH SSL_USE_OPENSSL USE_WEBRTC_DEV_BRANCH \"timezone=_timezone\" XML_STATIC \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_OPENSSL_CERTS=1\"" "--link_flags=-B../../out/Debug/gen/tc_pnacl_newlib/lib " "--source-list=../../out/gypfiles/third_party/libjingle/pnacl_newlib.libjingle_nacl.source_list.gypcmd"
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:50:23: error: 'CreateConnection' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual Connection* CreateConnection(const Candidate& address,
^
../webrtc/p2p/base/portinterface.h:71:23: note: overridden virtual function is here
virtual Connection* CreateConnection(
^
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:53:16: error: 'PrepareAddress' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual void PrepareAddress();
^
../webrtc/p2p/base/portinterface.h:63:16: note: overridden virtual function is here
virtual void PrepareAddress() = 0;
^
(etc)
Original issue's description:
> Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
>
> To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.
>
> BUG=4173
> R=pthatcher@webrtc.org
>
> Committed: https://crrev.com/7307952a5bf63311e5f9a2a90089a06177e42716
> Cr-Commit-Position: refs/heads/master@{#11247}
TBR=pthatcher@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=4173
Review URL: https://codereview.webrtc.org/1586063002
Cr-Commit-Position: refs/heads/master@{#11249}
|
|
This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS.
Original CL: https://codereview.webrtc.org/1538643004/
TBR=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1589573004
Cr-Commit-Position: refs/heads/master@{#11248}
|
|
To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.
BUG=4173
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1577873003 .
Cr-Commit-Position: refs/heads/master@{#11247}
|
|
cricket::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/1586613002/ )
Reason for revert:
These changes broke chrome.
Need to temporarily keep methods InitToEmptyBuffer, InitToBlack, CreateEmptyFrame with old but ignored arguments for pixel_width and pixel_height. Then update chrome, and delete the old methods in a separate cl.
Original issue's description:
> Delete remnants of non-square pixel support from cricket::VideoFrame.
>
> If ever needed, add some aspect ratio parameter, without pixel_width
> and pixel_height arguments cluttering commonly used functions.
>
> BUG=webrtc:5426
>
> Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
> Cr-Commit-Position: refs/heads/master@{#11243}
TBR=pthatcher@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1583223002
Cr-Commit-Position: refs/heads/master@{#11246}
|
|
BUG=chromium:577566
TBR=pbos@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1585963002
Cr-Commit-Position: refs/heads/master@{#11245}
|
|
Also add a perf metric tracking the average network latency.
The audio stream test is disabled for now since audio isn't included in bitrate allocation.
BUG=webrtc:5263
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1582833002 .
Cr-Commit-Position: refs/heads/master@{#11244}
|
|
If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.
BUG=webrtc:5426
Review URL: https://codereview.webrtc.org/1586613002
Cr-Commit-Position: refs/heads/master@{#11243}
|
|
Previosly ToSesnsetiveString() wasn't working witn some implementations
of inet_ntop(). Rewrote it to avoid that dependency.
BUG=chromium:577344
R=pthatcher@webrtc.org, tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1584793004 .
Cr-Commit-Position: refs/heads/master@{#11242}
|
|
id:120001 of https://codereview.chromium.org/1551813002/ )
Reason for revert:
tommi pointed out that using a refptr for the sink may cause issues. Will reland with a slightly different approach.
Original issue's description:
> Storing raw audio sink for default audio track.
>
> BUG=webrtc:5250
>
> Committed: https://crrev.com/e591f9377f33f3f725a30faecd1bef1a71fa6b99
> Cr-Commit-Position: refs/heads/master@{#11230}
TBR=pthatcher@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5250
Review URL: https://codereview.webrtc.org/1588693002
Cr-Commit-Position: refs/heads/master@{#11241}
|