aboutsummaryrefslogtreecommitdiff
path: root/BUILD.gn
AgeCommit message (Collapse)Author
2020-07-06Convert GN libs lists to frameworksSylvain Defresne
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: chromium:1052560 Change-Id: I263230ddd3c468061584423bba9e1f887503bcaa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/178601 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#31632}
2020-06-05Mutex: remove Abseil static initializer.Markus Handell
The change adds conditional inclusion of mutex_abseil.h from mutex.h and conditional referencing of //third_party/abseil-cpp/absl/synchronization which introduces a static initializer. https://webrtc-review.googlesource.com/c/src/+/176230 introduced a static initializer which broke the Chromium autoroll, https://chromium-review.googlesource.com/c/chromium/src/+/2230887. Example failure: https://ci.chromium.org/p/chromium/builders/try/android-lollipop-arm-rel/34133 TBR=karl@webrtc.org No-Try: True Bug: webrtc:11567 Change-Id: Id78af798f34d5d6beaf9f6e0150e6b3ddd31ff4f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176513 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31451}
2020-06-04Introduces rtc_base/synchronization/mutex.h.Markus Handell
This change introduces a new non-reentrant mutex to WebRTC. It enables eventual migration to Abseil's mutex. The mutex types supportable by webrtc::Mutex are - absl::Mutex - CriticalSection (Windows only) - pthread_mutex (POSIX only) In addition to introducing the mutexes, the CL also changes PacketBuffer to use the new mutex instead of rtc::CriticalSection. The method of yielding from critical_section.cc was given a mini-cleanup and YieldCurrentThread() was added to rtc_base/synchronization/yield.h/cc. Additionally, google_benchmark benchmarks for the mutexes were added (test courtesy of danilchap@), and some results from a pthread/Abseil shootout were added showing Abseil has the advantage in higher contention. Bug: webrtc:11567, webrtc:11634 Change-Id: Iaec324ccb32ec3851bf6db3fd290f5ea5dee4c81 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176230 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31443}
2020-05-05VoIP API implementation on top of AudioIngress/EgressTim Na
This is one last CL that includes the rest of VoIP API implementation. Bug: webrtc:11251 Change-Id: I3f1b0bf2fd48be864ffc73482105f9514f75f9e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173860 Commit-Queue: Tim Na <natim@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31168}
2020-04-26APM: Add build flag to allow building WebRTC without APMPer Åhgren
This CL adds a build flag to allow building the non-test parts of WebRTC without the audio processing module. The CL also ensures that the WebRTC code correctly handles the case when no APM is available. Bug: webrtc:5298 Change-Id: I5c8b5d1f7115e5cce2af4c2b5ff701fa1c54e49e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171509 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31133}
2020-04-21Audio ingress implementation for voip api.Tim Na
This is based on channel_receive.cc implementation where non-audio related logics are trimmed off for smaller footprint in size. Bug: webrtc:11251 Change-Id: I743c9f93f509fa6fcc12981fa73a6f01ce38348c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172821 Commit-Queue: Tim Na <natim@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31117}
2020-04-15Reland of the test portion of:Tommi
https://webrtc-review.googlesource.com/c/src/+/172847 ------------ original description -------------- Preparation for ReceiveStatisticsProxy lock reduction. Update tests to call VideoReceiveStream::GetStats() in the same or at least similar way it gets called in production (construction thread, same TQ/thread). Mapped out threads and context for ReceiveStatisticsProxy, VideoQualityObserver and VideoReceiveStream. Added follow-up TODOs for webrtc:11489. One functional change in ReceiveStatisticsProxy is that when sender side RtcpPacketTypesCounterUpdated calls are made, the counter is updated asynchronously since the sender calls the method on a different thread than the receiver. Make CallClient::SendTask public to allow tests to run tasks in the right context. CallClient already does this internally for GetStats. Remove 10 sec sleep in StopSendingKeyframeRequestsForInactiveStream. Bug: webrtc:11489 Change-Id: I491e13344b9fa714de0741dd927d907de7e39e83 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173583 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31077}
2020-04-07Revert "Preparation for ReceiveStatisticsProxy lock reduction."Artem Titov
This reverts commit 24eed2735b2135227bcfefbabf34a89f9a5fec99. Reason for revert: Speculative revert: breaks downstream project Original change's description: > Preparation for ReceiveStatisticsProxy lock reduction. > > Update tests to call VideoReceiveStream::GetStats() in the same or at > least similar way it gets called in production (construction thread, > same TQ/thread). > > Mapped out threads and context for ReceiveStatisticsProxy, > VideoQualityObserver and VideoReceiveStream. Added > follow-up TODOs for webrtc:11489. > > One functional change in ReceiveStatisticsProxy is that when sender > side RtcpPacketTypesCounterUpdated calls are made, the counter is > updated asynchronously since the sender calls the method on a different > thread than the receiver. > > Make CallClient::SendTask public to allow tests to run tasks in the > right context. CallClient already does this internally for GetStats. > > Remove 10 sec sleep in StopSendingKeyframeRequestsForInactiveStream. > > Bug: webrtc:11489 > Change-Id: Ib45bfc59d8472e9c5ea556e6ecf38298b8f14921 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172847 > Commit-Queue: Tommi <tommi@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Magnus Flodman <mflodman@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31008} TBR=mbonadei@webrtc.org,henrika@webrtc.org,kwiberg@webrtc.org,tommi@webrtc.org,juberti@webrtc.org,mflodman@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11489 Change-Id: I48b8359cdb791bf22b1a2c2c43d46263b01e0d65 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173082 Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31023}
2020-04-06Preparation for ReceiveStatisticsProxy lock reduction.Tommi
Update tests to call VideoReceiveStream::GetStats() in the same or at least similar way it gets called in production (construction thread, same TQ/thread). Mapped out threads and context for ReceiveStatisticsProxy, VideoQualityObserver and VideoReceiveStream. Added follow-up TODOs for webrtc:11489. One functional change in ReceiveStatisticsProxy is that when sender side RtcpPacketTypesCounterUpdated calls are made, the counter is updated asynchronously since the sender calls the method on a different thread than the receiver. Make CallClient::SendTask public to allow tests to run tasks in the right context. CallClient already does this internally for GetStats. Remove 10 sec sleep in StopSendingKeyframeRequestsForInactiveStream. Bug: webrtc:11489 Change-Id: Ib45bfc59d8472e9c5ea556e6ecf38298b8f14921 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/172847 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31008}
2020-04-02Make transient suppression optionally excludable via definessaza
This allows clients to exclude the transient suppression submodule from WebRTC builds, by defining WEBRTC_EXCLUDE_TRANSIENT_SUPPRESSOR. The changes have been shown to be bitexact for a test dataset (when the flag is _not_ defined.) No-Try: True Bug: webrtc:11226, webrtc:11292 Change-Id: I6931c82a280a9b40a53ee1c2a9820ed9e674a9a5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171421 Commit-Queue: Sam Zackrisson <saza@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30978}
2020-03-27Audio egress implementation for initial voip api in api/voip.Tim Na
For simplicity and flexibility on audio only API, it deemed to be better to trim off all audio unrelated logic to serve the purpose. Bug: webrtc:11251 Change-Id: I40e3eba2714c171f7c98b158303a7b3f744ceb78 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169462 Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Sebastian Jansson <srte@webrtc.org> Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30922}
2020-03-11Fix 'all' build on non Android platforms.Mirko Bonadei
Example of failures when trying to build "all": https://ci.chromium.org/p/webrtc/builders/ci/Mac%20Asan/23867 https://ci.chromium.org/p/webrtc/builders/try/linux_tsan2/32911 https://ci.chromium.org/p/webrtc/builders/try/linux_ubsan/32390 All related to missing //third_party/ced code. Bug: webrtc:11411 Change-Id: Ie3d7e87192edfb48d13ab8b14aba05808411a3ea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170112 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30752}
2020-03-06[Overuse] Initial version of VideoStreamAdapter (Restrictor moved).Henrik Boström
This CL simply moves the VideoSourceRestrictor from being an inner class of OveruseFrameDetectorResourceAdaptationModule to a new class, VideoStreamAdapter. In follow-up CLs, the responsibility of determining what the next step for adapting up or down should also be moved to the VideoStreamAdapter. The end-goal is that the VideoStreamAdapter takes care of "can adapt?" and "do adapt!" type of logic so that a multi-stream aware adaptation module can decide which stream (adapter) to adapt, and the adapter can take care of the nitty gritty details of doing so. In this CL the "can?"/"do!" part is realized but not the logic for determining what the next step up or down is, and the class interface needs improvement. This CL also sets up the video/adaptation/ subdirectory and moves the AdaptationCounters class here. Other adaptation-related classes (e.g. the module and its resources) should move into this directory as well in the future. Bug: webrtc:11393 Change-Id: I2c12c1281eca854c62791abb65f0aca47a119726 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169542 Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30705}
2020-02-07Move video_replay under rtc_tools/.Mirko Bonadei
As pointed out in [1], RTC public tools should live in rtc_tools. [1] - https://webrtc-review.googlesource.com/c/src/+/168320/2#message-1f40103105ecb077aeec153c5270575138349a50 Bug: chromium:942546 Change-Id: Ic827d9b31ade9a32bf4ef24d020ef8c81d2c9a5b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168308 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30486}
2020-01-30Make the dashboard upload script read protos instead of JSON.Patrik Höglund
I had to pivot and make tests output protos instead of JSON. I basically move the proto -> JSON conversion into this script instead of doing it in the test binary. This is a temporary state. Later it will be enough to just read up the file and pass it straight to the Catapult implementation, once it learns to de-serialize the proto directly. Bug: chromium:1029452 Change-Id: I7ce992eeeb1a5ae0f20eed54174b08b496e74dfd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166920 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30419}
2020-01-22Fix video_replay to build and actually workIlya Nikolaevskiy
Add it to default build target, so it won't get broken accidentally again. Fix configuration issue with field trials (new parameter was added recently, but wasn't set by video_replay) Bug: webrtc:11287 Change-Id: I9c18746d899acd7ac68c1b9b3a646b862c41897a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166900 Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30345}
2020-01-21Reformat GN files.Mirko Bonadei
`gn format` recently [1] changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. CL generated with: $ git ls-files | grep BUILD.gn | xargs gn format $ gn format build_overrides/build.gni $ gn format build_overrides/gtest.gni $ gn format modules/audio_coding/audio_coding.gni $ gn format webrtc.gni $ gn format .gn Plus a few manual changes to add exceptions for "public_deps" (after changing these lines the presubmit started to complain). [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11302 Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30334}
2020-01-21Remove android_junit_tests from the main BUILD.gn file.Mirko Bonadei
This target has been migrated into two separate targets in https://webrtc-review.googlesource.com/c/src/+/166603. Bug: webrtc:11289 Change-Id: Ibdea7616b79695b2ffb67d2210b41db55c41f50b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166536 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30330}
2020-01-21Split android_junit_tests and move targets in the right package.Mirko Bonadei
This is the first step to move //:android_junit_tests to the righ package (the target is triggering presubmit errors every time //BUILD.gn gets updated). Next steps: * Update recipes * Remove //:android_junit_tests Issues with GN formatting, introduced by [1] will be addressed separately in a "format all" CL. [1] - https://gn-review.googlesource.com/c/gn/+/6860 Bug: webrtc:11289 No-Presubmit: True Change-Id: I70c0927d722911f82dd971c30c7ffb581aed69c0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166603 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30328}
2020-01-14Suppress C5041 constexpr warning for MSVC 2019Jerome Humbert
Disable the C5041 warning which makes the build fail. This is a C++17-only change and WebRTC doesn't support C++17 yet, so the code is technically correct, but fails to build on MSVC 2019 and warning-as-error active. Also fix another warning-as-error build error with MSVC 2019 due to ignoring the result of a [[nodiscard]] function. No-Presubmit: True Bug: webrtc:11275,webrtc:11276 Change-Id: I891a894ee87252f96e84fd8d282576f46907256f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165781 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30244}
2020-01-02[Android] Replace java_files with sourcesNatalie Chouinard
Replace all usages of java_files with sources in gn files, and automatically format. This is in preparation for java_files being completely removed upstream in favor of sources. NOPRESUBMIT=true Bug: chromium:1035074 Change-Id: Ib9a698740b7ad26a127031d90321c7ae2feb59bf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/163161 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Natalie Chouinard <chouinard@google.com> Cr-Commit-Position: refs/heads/master@{#30135}
2019-12-10Initial version of ResourceAdaptationProcessor and friends.Henrik Boström
This CL adds Resource, ResourceConsumer, ResourceConsumerConfiguration and ResourceAdaptationProcessor and implements the algorithm outlined in https://docs.google.com/presentation/d/13jyqCWNpIa873iKT6yDuB5Q5ma-c0CvxBpX--0tCclY/edit?usp=sharing. Simply put, if any resource (such as "CPU") is overusing, the most expensive consumer (e.g. encoded stream) is adapted one step down. If all resources are underusing, the least expensive consumer is adapted one step up. The current resources, consumers and configurations are all fakes; this CL has no effect on the current adaptation algorithms used in practise, but it lays down the foundation for future work in this area. Bug: webrtc:11167, webrtc:11168, webrtc:11169 Change-Id: I4054ec7728a52a49e137eee6fa67fa27debd9254 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161237 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Evan Shrubsole <eshr@google.com> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30053}
2019-12-09Add directive to make webrtc metrics optional.Ying Wang
Bug: webrtc:11144 Change-Id: I4e75e6aec033784685de3670e880bb9f2b6ee8d2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161043 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Ying Wang <yinwa@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30040}
2019-12-05Stop setting -Wextra (the toolchain already does that).Mirko Bonadei
The comment was stale and setting -Wextra actually turns on diagnostics that are turned off by Chromium. For example: "-Wextra -Wno-deprecated-copy -Wextra" will turn on -Wdeprecated-copy because starting from https://reviews.llvm.org/D70342 -Wdeprecated-copy is part of -Wextra. Bug: webrtc:11180 Change-Id: Ia5d1e22bfe42d67cd892ae07620e7fd2daf9a7a4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161332 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30019}
2019-11-29Prefix ENABLE_RTC_EVENT_LOG with WEBRTC_.Mirko Bonadei
Since this macro can be considered public, it makes sense to prefix it with WEBRTC_ (also to avoid potential conflicts with client code). This CL also removes some definitions of this macro in order to define it only where it is strictly needed (it is only used in a .cc file). Bug: webrtc:11142 Change-Id: Idce7389301e71d8434e238b3cf4ceaa9cf97cd87 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161008 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29957}
2019-11-28Add ability to disable detailed error message in RTC_CHECKsArtem Titov
Bug: webrtc:11133 Change-Id: I989654f1fb97b476a17956d69ee374406439ea8f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160653 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29952}
2019-11-28Add directive to make TRACE_EVENT macros optional.Doudou Kisabaka
Bug: webrtc:11132 Change-Id: I801994ad262e1acff73e4c20afd7a7343b56268c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160654 Commit-Queue: Doudou Kisabaka <doudouk@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29949}
2019-11-26Add ability to strip out logging messages from the binaryArtem Titov
Bug: webrtc:11125 Change-Id: I6e1e96536502c6ae94b6061ea09951cdc2fd87ac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160410 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29919}
2019-11-18Move stun.h to api/.Patrik Höglund
We now have two downstream users of stun.h, so it appears to be generally usable. I put this in a new dir networking/, but I'm open to suggestions here (maybe some things in api/ should move in there). I checked what our downstream users are actually using, and it's cricket::ComputeStunCredentialHash cricket::<constants> cricket::TurnMessage cricket::GetStunErrorResponseType cricket::StunAttribute::CreateAddress cricket::StunErrorCodeAttribute cricket::StunByteStringAttribute StunAttribute::CreateUnknownAttributes cricket::TurnErrorType cricket::StunMessage I reckoned that was pretty much everything in stun.h, so I didn't bother splitting it up. They don't use every function and constant in there, but all _types_ of functions and constants, so for the sake of coherence I don't think it makes sense to split it. There's some old stuff in there like GTURN which could arguably be split out, but it should likely go away soon anyway, so I don't think it's worth the effort. Steps: 1) land this 2) update downstream to point to the new header and target 3) remove p2p/base:stun_types. Bug: webrtc:11091 Change-Id: I1f05bf06055475d25601197ec6fefb8d3b55e8e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159923 Commit-Queue: Patrik Höglund <phoglund@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29822}
2019-11-14Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed Chromium CL that introduces the component build support: https://chromium-review.googlesource.com/c/chromium/src/+/1874722 Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Tree-Checks: true No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: Iff8e35c6f9a53a0d08979bc873b6488dd7164ba5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159860 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29801}
2019-11-13Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit f181137b05e4b899fa3f15afafc4f27e683d83cc. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I8582242910bb3633b7a4675ff261b5a6a0b6954e > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159712 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29795} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I6bbe0288d07e49c8a4c808c758ecb6e2ddfa2aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159713 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29796}
2019-11-13Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I8582242910bb3633b7a4675ff261b5a6a0b6954e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159712 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29795}
2019-11-13Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit 57d53cf1944952ac67df2f6a3522f38cdc01d0c1. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I4719f5b5607ea491689429ca327a3521729e4ba7 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159700 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29787} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I1775bdac3ab9888d36f1552dd2eaaa000c43c9b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159701 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29788}
2019-11-13Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I4719f5b5607ea491689429ca327a3521729e4ba7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159700 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29787}
2019-11-13Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit f3dccc63f32202d2a3e3bf2d87c95c141cf0963c. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I73ae6ff93da78f9f0b2b53f0c6b12693514bc20d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159695 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29783} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I5c9c267278140d608b5063cc174eac9a2103636d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159696 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29784}
2019-11-13Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I73ae6ff93da78f9f0b2b53f0c6b12693514bc20d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159695 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29783}
2019-11-12Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit 93f7907973411ac3a5e5955b90f6a7f013195466. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: Ic5c3103da4ae5713cf5798b2eeaac396542d2026 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159687 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29771} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ia1225d3619a90dfdd35c561da7940fe5bf9f7452 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159688 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29772}
2019-11-12Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: Ic5c3103da4ae5713cf5798b2eeaac396542d2026 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159687 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29771}
2019-11-12Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit bcec8a7f0290709426ae08c5a1b1c9cff766e39b. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I70fdee572082f65132f638bf6c1605c7b23a9efb > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159684 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29767} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ic822b10e2474621306c3cce7ea96715953e487c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159685 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29769}
2019-11-12Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I70fdee572082f65132f638bf6c1605c7b23a9efb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159684 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29767}
2019-11-12Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit d1f40f39dc2167c7b9873be35e699c3954197060. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: Ie3ab8e46c2621dd72dd1dd4ca3d861f5e8411984 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159681 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29763} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I16af531ea0036effd0ede5e08169e51fddf7063c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159682 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29764}
2019-11-12Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: Ie3ab8e46c2621dd72dd1dd4ca3d861f5e8411984 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159681 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29763}
2019-11-11Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit f9180afdb953707598c18e2f84b49ba008716168. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > No-Try: True > TBR: kwiberg@webrtc.org > Bug: webrtc:9419 > Change-Id: I9e3c2b96ea424d940b779e46921f2035ed950837 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159484 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29757} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ibac30fd736913b7f76bb3e3c30c00933562039e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159485 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29758}
2019-11-11Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} No-Try: True TBR: kwiberg@webrtc.org Bug: webrtc:9419 Change-Id: I9e3c2b96ea424d940b779e46921f2035ed950837 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159484 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29757}
2019-11-07Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > No-Try: True > Bug: webrtc:9419 > Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29723} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I95416dc126ad56c0fd939acf084b126432f2d690 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159037 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29735}
2019-11-07Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} TBR: kwiberg@webrtc.org No-Try: True Bug: webrtc:9419 Change-Id: Id247243d8464062051e050e406b8b84ee1355a58 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159036 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29734}
2019-11-07Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit 1ecfa4d9ddec3518f1bbdf998447d8ac2c2fc6a1. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > No-Try: True > Bug: webrtc:9419 > Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024 > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29723} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: I2922161bd97ef209d8cd7ce219eac0080fd69aa8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159027 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29724}
2019-11-07Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} TBR: kwiberg@webrtc.org No-Try: True Bug: webrtc:9419 Change-Id: I4365fd66968218979e16954c7b00e3bb6d4fe806 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159024 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29723}
2019-11-06Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""Mirko Bonadei
This reverts commit a4bd0079dc6bca88d52d4d1db21d22572cc6339b. Reason for revert: This CL was just needed in order to have a WebRTC commit to pin in Chromium to test the component build (this CL enables symbol exports). Original change's description: > Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." > > This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed > > I will revert this reland as soon as it lands because I just need > to have a WebRTC commit to pin in Chromium in order to test the > component build (this CL enables symbol exports). > > Original change's description: > > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > > > In order to land the component build support in Chromium, it is > > easier to turn on symbols export every time that is_component_build=true > > instead of setting rtc_enable_symbol_export=is_component_build in > > Chromium (since is_component_build is not available in .gn). > > > > rtc_enable_symbol_export is still kept in the mix in order to turn > > on symbol exports in any case a shared library will be added to the > > WebRTC build. > > > > Bug: webrtc:9419 > > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#29540} > > TBR: kwiberg@webrtc.org > No-Try: True > Bug: webrtc:9419 > Change-Id: Ic20de2a30c391f55401c4b9c8c152cbeb48c91c6 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159004 > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29710} TBR=mbonadei@webrtc.org,kwiberg@webrtc.org Change-Id: Ic15d6a7c16c15e4145374dbec1ea3810f2686e4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9419 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159005 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29711}
2019-11-06Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."Mirko Bonadei
This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29540} TBR: kwiberg@webrtc.org No-Try: True Bug: webrtc:9419 Change-Id: Ic20de2a30c391f55401c4b9c8c152cbeb48c91c6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159004 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29710}
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-28 11:49:43 +0000