aboutsummaryrefslogtreecommitdiff
path: root/rtc_base
AgeCommit message (Collapse)Author
2018-08-16Change the default behaviour rtc_builtin_ssl_root_certificates.Mirko Bonadei
Instead of defining a pre-processor macro when someone wants to include built-in ssl roots certs, this CL switches the default and assumes everyone prefer to include built-in ssl roots certs. If built-in ssl roots certs are not needed because they are injected in the PeerConnection it will be possible to define a pre-processor macro (WEBRTC_EXCLUDE_BUILT_IN_SSL_ROOT_CERTS) to remove them. In a GN build it is possible to tell GN to define the macro by setting rtc_builtin_ssl_root_certificates to false in "gn args". Bug: webrtc:9332 Change-Id: Icc3f2caeddca6899cbc5974f21b480d75d15556f Reviewed-on: https://webrtc-review.googlesource.com/94147 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Benjamin Wright <benwright@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24302}
2018-08-13Remove public_deps from rtc_base:protobuf_utils.Mirko Bonadei
Bug: webrtc:8603 Change-Id: I8dfc176b570d28ce8003f5f8f1ed995848af9a9d Reviewed-on: https://webrtc-review.googlesource.com/93761 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24273}
2018-08-11Add UTC time to init event in AEC debug dump.Minyue Li
Bug: webrtc:9616 Change-Id: I1350212f0b8835fb64427483269da96d51670c01 Reviewed-on: https://webrtc-review.googlesource.com/92620 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Minyue Li <minyue@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Commit-Queue: Minyue Li <minyue@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24267}
2018-08-10Change visibility of some build targets that are publicly used.Mirko Bonadei
Bug: None Change-Id: I9b0dc56364648ac4d4fa4b8bb67af44700621b24 Reviewed-on: https://webrtc-review.googlesource.com/93282 Reviewed-by: Anders Carlsson <andersc@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24256}
2018-08-09Remove old base64 headerArtem Titov
To be landed after 8th Aug 2018 Bug: webrtc:8366 Change-Id: Icf5f2ecbf2e64de93ce3e6758966629f9cc3a2b9 Reviewed-on: https://webrtc-review.googlesource.com/90244 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24240}
2018-08-09Making rtc_base:ptr_util and rtc_base:refcount public.Mirko Bonadei
Bug: None Change-Id: I6f4b372c087c6d25e8c451ab5577cb3bcb13f6f0 Reviewed-on: https://webrtc-review.googlesource.com/93284 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24237}
2018-08-08Remove definition and usage of macro GTEST_RELATIVE_PATH.Mirko Bonadei
The macro GTEST_RELATIVE_PATH is obsolete and since it is always defined this CL just removes it. Bug: webrtc:9564 Change-Id: Ieafa5b77351c4df87864588ba6b3de8f60d54e89 Reviewed-on: https://webrtc-review.googlesource.com/92080 Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24226}
2018-08-08Remove rtc::{Make,Wrap}Unique and their header file + unit testsKarl Wiberg
We've switched to absl::make_unique and absl::WrapUnique. Bug: webrtc:9473 Change-Id: I08aef72d52b571c511c0f4adb4c68d6cc2654192 Reviewed-on: https://webrtc-review.googlesource.com/87262 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24225}
2018-08-07Add steveanton@ and qingsi@ as rtc_base OWNERsSteve Anton
We both frequentyly work on this code and much of it is intertwined with pc/ and p2p/ code which we have OWNERs for already. NOTRY=True Bug: None Change-Id: If56ebca6ef44cf9b7837e8d4bc3afa367a5d5216 Reviewed-on: https://webrtc-review.googlesource.com/90084 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24211}
2018-08-07Fix guards for headers in third partyArtem Titov
Bug: webrtc:8366 Change-Id: I86309265c822dd4430c5578d813bdddc77102d05 Reviewed-on: https://webrtc-review.googlesource.com/90416 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24203}
2018-08-03Don't allocate an array of size 0, it causes a UBSan failureOleh Prypin
Bug: webrtc:9587 Change-Id: I56bdf3c5c8744044b2d0d1fa3531fca504ea200f Reviewed-on: https://webrtc-review.googlesource.com/92091 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24178}
2018-08-01Removing rtc_base:base build target.Mirko Bonadei
This build target is unused and outdated (the name was still base because rtc_base is the real target). It is better for users to depend on real targets instead of this group. Bug: None Change-Id: I870669dc8688810b132616b8edebb8196826701f Reviewed-on: https://webrtc-review.googlesource.com/91720 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24158}
2018-07-27Fix compilation error of opensslutility.cc when compiling with OpenSSL.Jiawei Ou
https://webrtc-review.googlesource.com/c/64841/ added LogSSLErrors(..) with used two new OpenSSL ERR_get_error() and ERR_error_string_n() without including the proper header from OpenSSL. TBR=kwiberg@webrtc.org Bug: webrtc:9567 Change-Id: I118a5e18243828a3e3dfd287a0c41fe1bc5e4ad3 Reviewed-on: https://webrtc-review.googlesource.com/90820 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Benjamin Wright <benwright@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24136}
2018-07-26Use "wildcard" instead of "unknown" for ADAPTER_TYPE_ANY in stats.Qingsi Wang
TBR=hta@webrtc.org Bug: None Change-Id: I3ccff01f2ad51aebc1241fab2b41518b769adc8a Reviewed-on: https://webrtc-review.googlesource.com/90800 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24120}
2018-07-25Delete unused code in httpbase and httpcommon.Niels Möller
Deleted features include HttpBase::GetDocumentStream(), and support for other operations than GET. Bug: webrtc:6424 Change-Id: Ib16537cd1db87de53150f8e9e30dd89778a20c2e Reviewed-on: https://webrtc-review.googlesource.com/84140 Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24102}
2018-07-25Delete root header file typedef.h.Niels Möller
Usage replaced with stdint.h, rtc_base/system/arch.h and rtc_base/system/unused.h, as appropriate. Bug: webrtc:6854 Change-Id: I97225465d14b969903d92979e2df3c3c05d35f18 Reviewed-on: https://webrtc-review.googlesource.com/90249 Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24100}
2018-07-25Move sigslot to proper third_party directoryArtem Titov
Extract sigslot into separate target and move it to proper third_party directory. Bug: webrtc:8366 Change-Id: Id2e0712bd020bfad811947803c94553dce06d976 Reviewed-on: https://webrtc-review.googlesource.com/84141 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24099}
2018-07-23Cleanup networkroute.hSteve Anton
This change removes the constructors in favor of naming the fields of the struct. TBR=kwiberg@webrtc.org Bug: None Change-Id: I23ae1165c20994d2efef10184570065957b279af Reviewed-on: https://webrtc-review.googlesource.com/90081 Commit-Queue: Steve Anton <steveanton@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24071}
2018-07-23Move base64.h to the proper location.Artem Titov
Move base64.h to the proper location and put redirect header into the old place to be able to switch downstream users on new location. Bug: webrtc:8366 Change-Id: I5191fe631d32178d2efd1315ca9abd4250102291 Reviewed-on: https://webrtc-review.googlesource.com/88223 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24069}
2018-07-19Added explicit EOR to sctp messages and coalesce messages on the receiving side.Jeroen de Borst
TBR=pthatcher@webrtc.org Bug: webrtc:7774 Change-Id: I41d1cd98d1e7b2ad479177eb2e328a5e2c704824 Reviewed-on: https://webrtc-review.googlesource.com/88900 Commit-Queue: Jeroen de Borst <jeroendb@webrtc.org> Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24031}
2018-07-17Replace accidental usages of source_set with rtc_source_setOleh Prypin
Bug: None Change-Id: I80c5ad9e1e9942eb51ace014cd7b9127959d601b Reviewed-on: https://webrtc-review.googlesource.com/89061 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Oleh Prypin <oprypin@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24004}
2018-07-12Reland "Reland "Replace the usage of MetricsObserverInterface by ↵Qingsi Wang
RTC_HISTOGRAM_*."" This is a reland of 1a2cc0acba6a66f89249455d8e5775849b56f755 Original change's description: > Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*." > > This is a reland of 870bca1f418a1abf445169a638a61f9a649d557f > > Original change's description: > > Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*. > > > > We now use RTC_HISTOGRAM_* macros in system_wrappers/include/metrics.h > > to report the metrics in pc/ and p2p/ that are currently been reported > > using MetricsObserverInterface. > > > > TBR=tommi@webrtc.org > > > > Bug: webrtc:9409 > > Change-Id: I47c9975402293c72250203fa1ec19eb1668766f6 > > Reviewed-on: https://webrtc-review.googlesource.com/83782 > > Commit-Queue: Qingsi Wang <qingsi@google.com> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Taylor (left Google) <deadbeef@webrtc.org> > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23914} > > TBR=steveanton@webrtc.org,hta@webrtc.org,tommi@webrtc.org > > Bug: webrtc:9409 > Change-Id: I37fc95ced60dea25aa9b4f5ad44bdf7174c8bd5c > Reviewed-on: https://webrtc-review.googlesource.com/88060 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#23919} TBR=steveanton@webrtc.org,tommi@webrtc.org Bug: webrtc:9409 Change-Id: Ib55f0b6c9bcb9d9585924a4dfac5cf643ff4d76b Reviewed-on: https://webrtc-review.googlesource.com/88343 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23957}
2018-07-11Revert "Reland "Replace the usage of MetricsObserverInterface by ↵Qingsi Wang
RTC_HISTOGRAM_*."" This reverts commit 1a2cc0acba6a66f89249455d8e5775849b56f755. Reason for revert: It breaks internal Android debug build. Need further investigation. Original change's description: > Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*." > > This is a reland of 870bca1f418a1abf445169a638a61f9a649d557f > > Original change's description: > > Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*. > > > > We now use RTC_HISTOGRAM_* macros in system_wrappers/include/metrics.h > > to report the metrics in pc/ and p2p/ that are currently been reported > > using MetricsObserverInterface. > > > > TBR=tommi@webrtc.org > > > > Bug: webrtc:9409 > > Change-Id: I47c9975402293c72250203fa1ec19eb1668766f6 > > Reviewed-on: https://webrtc-review.googlesource.com/83782 > > Commit-Queue: Qingsi Wang <qingsi@google.com> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Taylor (left Google) <deadbeef@webrtc.org> > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23914} > > TBR=steveanton@webrtc.org,hta@webrtc.org,tommi@webrtc.org > > Bug: webrtc:9409 > Change-Id: I37fc95ced60dea25aa9b4f5ad44bdf7174c8bd5c > Reviewed-on: https://webrtc-review.googlesource.com/88060 > Reviewed-by: Qingsi Wang <qingsi@webrtc.org> > Commit-Queue: Qingsi Wang <qingsi@google.com> > Cr-Commit-Position: refs/heads/master@{#23919} TBR=steveanton@webrtc.org,deadbeef@webrtc.org,tommi@webrtc.org,hta@webrtc.org,qingsi@google.com,qingsi@webrtc.org Change-Id: I4a75fc7f52bfd0780526537a5a9a016fb9c20d6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9409 Reviewed-on: https://webrtc-review.googlesource.com/88320 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#23938}
2018-07-11Reland "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."Qingsi Wang
This is a reland of 870bca1f418a1abf445169a638a61f9a649d557f Original change's description: > Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*. > > We now use RTC_HISTOGRAM_* macros in system_wrappers/include/metrics.h > to report the metrics in pc/ and p2p/ that are currently been reported > using MetricsObserverInterface. > > TBR=tommi@webrtc.org > > Bug: webrtc:9409 > Change-Id: I47c9975402293c72250203fa1ec19eb1668766f6 > Reviewed-on: https://webrtc-review.googlesource.com/83782 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Taylor (left Google) <deadbeef@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23914} TBR=steveanton@webrtc.org,hta@webrtc.org,tommi@webrtc.org Bug: webrtc:9409 Change-Id: I37fc95ced60dea25aa9b4f5ad44bdf7174c8bd5c Reviewed-on: https://webrtc-review.googlesource.com/88060 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#23919}
2018-07-10Revert "Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*."Qingsi Wang
This reverts commit 870bca1f418a1abf445169a638a61f9a649d557f. Reason for revert: it breaks internal tests and builds Original change's description: > Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*. > > We now use RTC_HISTOGRAM_* macros in system_wrappers/include/metrics.h > to report the metrics in pc/ and p2p/ that are currently been reported > using MetricsObserverInterface. > > TBR=tommi@webrtc.org > > Bug: webrtc:9409 > Change-Id: I47c9975402293c72250203fa1ec19eb1668766f6 > Reviewed-on: https://webrtc-review.googlesource.com/83782 > Commit-Queue: Qingsi Wang <qingsi@google.com> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Reviewed-by: Taylor (left Google) <deadbeef@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23914} TBR=steveanton@webrtc.org,deadbeef@webrtc.org,hta@webrtc.org,tommi@webrtc.org Change-Id: I1afd92d44f3b8cf3ae9aa6e6daa9a3a272e8097f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:9409 Reviewed-on: https://webrtc-review.googlesource.com/88040 Reviewed-by: Qingsi Wang <qingsi@webrtc.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#23916}
2018-07-10Replace the usage of MetricsObserverInterface by RTC_HISTOGRAM_*.Qingsi Wang
We now use RTC_HISTOGRAM_* macros in system_wrappers/include/metrics.h to report the metrics in pc/ and p2p/ that are currently been reported using MetricsObserverInterface. TBR=tommi@webrtc.org Bug: webrtc:9409 Change-Id: I47c9975402293c72250203fa1ec19eb1668766f6 Reviewed-on: https://webrtc-review.googlesource.com/83782 Commit-Queue: Qingsi Wang <qingsi@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Taylor (left Google) <deadbeef@webrtc.org> Reviewed-by: Steve Anton <steveanton@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23914}
2018-07-09Delegate WIN32_LEAN_AND_MEAN definition to the toolchain.Mirko Bonadei
The macro WIN32_LEAN_AND_MEAN is always defined by the toolchain, see the config //build/config/win:lean_and_mean [1]. This means that WebRTC should not define it in its source files, this causes two problems: 1. rtc_base:rtc_base_generinc needs to use /wd4005 to avoid a compiler warning (because the macro is redefined without checking). 2. the macro is not consistently defined before including windows.h, which means that WebRTC already relies on the toolchain almost everywhere. [1] - https://cs.chromium.org/chromium/src/build/config/win/BUILD.gn?l=514&rcl=54f7be95955c9b35e64569c1d40e0c3dd097359c Bug: webrtc:9251 Change-Id: I2b0b3c16856023db2a38a38f7652bb849ff283c7 Reviewed-on: https://webrtc-review.googlesource.com/87582 Commit-Queue: Tommi <tommi@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23889}
2018-07-09Removing /wd4703 from rtc_base:rtc_base_generic.Mirko Bonadei
This warning suppression flag is not needed. Bug: webrtc:9251 Change-Id: I3319e57f737d44e991ab7283647fd5522bd4bd37 Reviewed-on: https://webrtc-review.googlesource.com/87581 Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23886}
2018-07-05Use absl::make_unique and absl::WrapUnique directlyKarl Wiberg
Instead of going through our wrappers in ptr_util.h. This CL was generated by the following script: git grep -l ptr_util | xargs perl -pi -e 's,#include "rtc_base/ptr_util.h",#include "absl/memory/memory.h",' git grep -l MakeUnique | xargs perl -pi -e 's,\b(rtc::)?MakeUnique\b,absl::make_unique,g' git grep -l WrapUnique | xargs perl -pi -e 's,\b(rtc::)?WrapUnique\b,absl::WrapUnique,g' git checkout -- rtc_base/ptr_util{.h,_unittest.cc} git cl format Followed by manually adding dependencies on //third_party/abseil-cpp/absl/memory until `gn check` stopped complaining. Bug: webrtc:9473 Change-Id: I89ccd363f070479b8c431eb2c3d404a46eaacc1c Reviewed-on: https://webrtc-review.googlesource.com/86600 Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23850}
2018-07-03Move RTC_CHECK_OP error message construction out of header file.Jonas Olsson
This simplifies the logic, prevents emitting code for every pair of argument types to RTC_CHECK_OP and partially unblocks removing streams from the check code altogether. Bug: webrtc:8982 Change-Id: Ib6652ac9a342e4471c12574a79872833cc943407 Reviewed-on: https://webrtc-review.googlesource.com/86544 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23821}
2018-07-03Make ReceiveSendsFromThread use DispatchIshan Khot
The ReceiveSendsFromThread function calls the OnMessage function. However, instead we should be calling the Dispatch function which does the same thing as the OnMessage function except that it also does additional logging. This logging is being missed for the cases where we call functions on a thread using the Invoke function. Calling Dispatch fixes the issue and makes sure that this code path is consistent with other paths of posting to a thread like Post function which goes through Dispatch ultimately. Bug: None Change-Id: I75a5c8b464226cf4de60a3d19dff48f9e6197cca Reviewed-on: https://webrtc-review.googlesource.com/85885 Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23813}
2018-07-02Add ADAPTER_TYPE_ANY in AdapterType.Qingsi Wang
ADAPTER_TYPE_ANY can be used to set the network ignore mask if an application does not want candidates from the any address ports, the underlying network interface types of which are not determined in gathering. The ADAPTER_TYPE_ANY is also given the maximum network cost so that when there are candidates from explicit network interfaces, these candidates from the any address ports as backups, if they ever surface, are not preferred if the other candidates have at least the same network condition. Bug: webrtc:9468 Change-Id: I20c3a40e9a75b8fb34fad741ba5f835ecc3b0d92 Reviewed-on: https://webrtc-review.googlesource.com/85880 Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#23807}
2018-07-02Removing deadbeef@ from OWNERS files.Taylor Brandstetter
Since I'm leaving Google. Bug: None Notry: True Change-Id: Ibb5c3e09fce007d149200dcb6cac74be53084764 Reviewed-on: https://webrtc-review.googlesource.com/86461 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23795}
2018-06-29Turn rtc::{Make,Wrap}Unique into aliases for their Abseil counterpartsKarl Wiberg
We don't want to maintain our own versions. This CL is step one in getting rid of them. Bug: webrtc:9473 Change-Id: Ib8a54288509f4768b482367b738224869a5af559 Reviewed-on: https://webrtc-review.googlesource.com/86282 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23786}
2018-06-28Use field trial parser for BBR Experiment.Sebastian Jansson
Bug: webrtc:8415 Change-Id: If6336b16fa55c6bd891252fc3b9c0bcce56e2fd1 Reviewed-on: https://webrtc-review.googlesource.com/83620 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23761}
2018-06-27Adds enum field trial parser.Sebastian Jansson
Removed the need to create a custom parser function and reuses some of the code to reduce binary overhead of enums. Bug: webrtc:9346 Change-Id: I51c9da713ed5456a86a2afbcf0991477bb83b894 Reviewed-on: https://webrtc-review.googlesource.com/83623 Reviewed-by: Stefan Holmer <stefan@webrtc.org> Commit-Queue: Sebastian Jansson <srte@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23752}
2018-06-26Delete unused class TransformAdapter.Niels Möller
Bug: webrtc:6424 Change-Id: I75bf0ab0ce4bf2e1197885f06b8a772b5a5a9dfa Reviewed-on: https://webrtc-review.googlesource.com/84284 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23735}
2018-06-25Delete unused methods for replacing the "default filesystem".Niels Möller
Bug: webrtc:6424 Change-Id: I7f76fe71ac395088c3b632e43475933cc13e47cd Reviewed-on: https://webrtc-review.googlesource.com/83725 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23728}
2018-06-25Delete unused rtc::Stream subclasses.Niels Möller
Also move StringStream to the only test using it. Bug: webrtc:6424 Change-Id: Iad79c7becaa2764ac954c18711eaae4faf46ae72 Reviewed-on: https://webrtc-review.googlesource.com/84320 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23721}
2018-06-21Reland "Reland "Injectable logging""Paulina Hensman
This is a reland of 21219a0e43446701810236fb9fdd59be072c12df The default implementation of OnLogMessage(msg, sev, tag) discarded the tag, resulting in FileRotatingLogSink not receiving tags. Since the revert the default implementation of OnLogMessage(msg, sev, tag) has been updated to add the tag to the log message. A more efficient implementation of it has also been added for FileRotatingLogSink. Unit tests are added for the default implementation and for Loggable injection. Original change's description: > Reland "Injectable logging" > > Any injected loggable or NativeLogger would be deleted if PCFactory > was reinitialized without calling setInjectableLogger. Now native > logging is not implemented as a Loggable, so it will remain active > unless a Loggable is injected. > > This is a reland of 59216ec4a4151b1ba5478c8f2b5c9f01f4683d7f > > Original change's description: > > Injectable logging > > > > Allows passing a Loggable to PCFactory.initializationOptions, which > > is then injected to Logging.java and logging.h. Future log messages > > in both Java and native will then be passed to this Loggable. > > > > Bug: webrtc:9225 > > Change-Id: I2ff693380639448301a78a93dc11d3a0106f0967 > > Reviewed-on: https://webrtc-review.googlesource.com/73243 > > Commit-Queue: Paulina Hensman <phensman@webrtc.org> > > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> > > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#23241} > > Bug: webrtc:9225 > Change-Id: I2fe3fbc8c323814284bb62e43fe1870bdab581ee > TBR: kwiberg > Reviewed-on: https://webrtc-review.googlesource.com/77140 > Commit-Queue: Paulina Hensman <phensman@webrtc.org> > Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#23310} Bug: webrtc:9225 Change-Id: I67a5728fe772f0bedc9509713ed8b8ffdc31af81 TBR: kwiberg Reviewed-on: https://webrtc-review.googlesource.com/80860 Commit-Queue: Paulina Hensman <phensman@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23711}
2018-06-21Remove usage of rtc_base/checks.h in 3pp base64.ccArtem Titov
rtc_base/base64.h and rtc_base/base64.cc are third_party files in webrtc repo and we are planning to move them into third_party folder. To be able to do it, we need to eliminate all dependencies from this files on webrtc code base. So thic CL will remove dependency on rtc_base.checks.h. After it we will be able to move base64 files. Bug: webrtc:8366 Change-Id: I79d252daef974e95bb43a1566d05e603922aea3f Reviewed-on: https://webrtc-review.googlesource.com/84126 Commit-Queue: Artem Titov <titovartem@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23702}
2018-06-21Replace rtc::Optional with absl::optional in rtc_baseDanil Chapovalov
This is a no-op change because rtc::Optional is an alias to absl::optional This CL generated by running script with parameter 'rtc_base' Then manually fix where Optional was used without rtc prefix (patchset#3) find $@ -type f \( -name \*.h -o -name \*.cc \) \ -exec sed -i 's|rtc::Optional|absl::optional|g' {} \+ \ -exec sed -i 's|rtc::nullopt|absl::nullopt|g' {} \+ \ -exec sed -i 's|#include "api/optional.h"|#include "absl/types/optional.h"|' {} \+ find $@ -type f -name BUILD.gn \ -exec sed -r -i 's|"[\./api]*:optional"|"//third_party/abseil-cpp/absl/types:optional"|' {} \+; git cl format Bug: webrtc:9078 Change-Id: I825f80cc8089747876ba6316d9e7c30e05716974 Reviewed-on: https://webrtc-review.googlesource.com/84585 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23700}
2018-06-21Add OnLogMessage(msg, sev, tag) to logsinksPaulina Hensman
This fixes a bug where tags are not saved by FileRotatingLogSink. It is also a preparation step for injectable logging. Bug: webrtc:9225 Change-Id: I06ae0810073492bd2f103fefd64bd3cd02659fbc Reviewed-on: https://webrtc-review.googlesource.com/84361 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Sami Kalliomäki <sakal@webrtc.org> Commit-Queue: Paulina Hensman <phensman@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23695}
2018-06-19Reformat the WebRTC code baseYves Gerey
Running clang-format with chromium's style guide. The goal is n-fold: * providing consistency and readability (that's what code guidelines are for) * preventing noise with presubmit checks and git cl format * building on the previous point: making it easier to automatically fix format issues * you name it Please consider using git-hyper-blame to ignore this commit. Bug: webrtc:9340 Change-Id: I694567c4cdf8cee2860958cfe82bfaf25848bb87 Reviewed-on: https://webrtc-review.googlesource.com/81185 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23660}
2018-06-18Extract rtc_base/base64.h and rtc_base/base64.cc into separate target.Artem Titov
Extract rtc_base/base64.h and rtc_base/base64.cc into separate target to prepare to move them into third_party Bug: webrtc:8366 Change-Id: I477e6da2b9d09307439b3272261f31042f479d74 Reviewed-on: https://webrtc-review.googlesource.com/83980 Reviewed-by: Patrik Höglund <phoglund@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23645}
2018-06-18Disable new RTC_CHECK unittestJonas Olsson
For some reason this test fails on g3. The TBR=kwiberg No-Try: true Bug: webrtc:8982 Change-Id: I6c6a78bab36eab0972e2fa24344d3cca63daa3b3 Reviewed-on: https://webrtc-review.googlesource.com/83940 Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23639}
2018-06-15Refactor checks to use a copy of the new logging backend.Jonas Olsson
As a bonus, this shrinks the android release version of libjingle_peerconnection_so.so by ~25k in local tests. We could try to unify the backend with the logging one, but that turns out to be surprisingly tricky due to dependency loops and chromium overrides. Bug: webrtc:8982 Change-Id: I66854dd333f568d9b2a5f46bbead14b2e31179be Reviewed-on: https://webrtc-review.googlesource.com/79623 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23634}
2018-06-15Delete unused methods on rtc::Pathname.Niels Möller
Deleted methods Normalize(), clear(), empty(), folder(), parent_folder(). Bug: webrtc:6424 Change-Id: I7a7096b23f4ba675305de1728988d2cfb48f135f Reviewed-on: https://webrtc-review.googlesource.com/80520 Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23623}
2018-06-14Adds field trial parser.Sebastian Jansson
Bug: webrtc:9346 Change-Id: Ibd07a1753feaa40d4be4d465d61f55bc8a8a9325 Reviewed-on: https://webrtc-review.googlesource.com/80263 Commit-Queue: Sebastian Jansson <srte@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Stefan Holmer <stefan@webrtc.org> Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23615}
2018-06-14Handle FileRotatingStreams with long file namesJonas Olsson
Bug: webrtc:9392 Change-Id: I7b42b1a6ed1b646c244bc64f1bad92a2f38e5539 Reviewed-on: https://webrtc-review.googlesource.com/83162 Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Cr-Commit-Position: refs/heads/master@{#23608}
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 05:17:21 +0000