Age | Commit message (Collapse) | Author |
|
BUG=webrtc:332
Review URL: https://codereview.webrtc.org/1511413007
Cr-Commit-Position: refs/heads/master@{#10988}
|
|
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1353713002 .
Cr-Commit-Position: refs/heads/master@{#9979}
|
|
There are still dependencies on this functionality.
TBR=pthatcher@webrtc.org
BUG=526399
Review URL: https://codereview.webrtc.org/1336553003
Cr-Commit-Position: refs/heads/master@{#9920}
|
|
(enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.
This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33.
Original CL: https://codereview.webrtc.org/1263663002/
R=guoweis@webrtc.org
Review URL: https://codereview.webrtc.org/1303393002 .
Cr-Commit-Position: refs/heads/master@{#9761}
|
|
Renames ViECapturer to VideoCaptureInput and initializes several
parameters on construction instead of setters.
Also removes an old deadlock suppression.
BUG=1695, 2999
R=asapersson@webrtc.org, mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/53559004.
Cr-Commit-Position: refs/heads/master@{#9508}
|
|
Registers transport on construction removing the need for ViESender as a
hop and removing a potential deadlock by removing RegisterSendTransport.
BUG=1695, 2999
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/57449004
Cr-Commit-Position: refs/heads/master@{#9309}
|
|
BUG=1695
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49349004
Cr-Commit-Position: refs/heads/master@{#9252}
|
|
This reverts r8010. I removed TraceImpl::Run in r8529 so these added
suppressions no longer match any callstacks.
BUG=4147
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40309004
Cr-Commit-Position: refs/heads/master@{#8692}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8692 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The roll seems to cause leaks on our Linux Memcheck bot.
Added a suppression needed for Trusty in order to run
memcheck similar to the bot (that runs Precise).
Leave all the other source code edits from r8596 in place.
See also http://chromegw/i/client.webrtc/builders/Linux%20Memcheck/builds/3343
TBR=pbos@webrtc.org
TESTED=Can no longer repro memcheck failure with this patch applied:
GYP_DEFINES="build_for_tool=memcheck" webrtc/build/gyp_webrtc
ninja -C out/Release libjingle_peerconnection_unittest
tools/valgrind-webrtc/webrtc_tests.sh --test libjingle_peerconnection_unittest --tool memcheck --target Release --build-dir out --gtest_filter=WebRtcSessionTest.TestIncorrectMLinesInLocalAnswer
Review URL: https://webrtc-codereview.appspot.com/47419004
Cr-Commit-Position: refs/heads/master@{#8612}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8612 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Without this patch, Valgrind's Memcheck was complaining that the test
for whether we should return -1 following the call to
WebRtcIsac_DecodeLb made a conditional branch or move based on the
value of numSamplesLB, which was uninitialized if WebRtcIsac_DecodeLb
failed.
However, as can be seen in the source, the control flow only depends
on the value of numSamplesLB if numDecodedBytesLB >= 0; i.e., if
WebRtcIsac_DecodeLb returned successfully, in which case numSamplesLB
is always initialized. The discrepancy is due to the fact that
Valgrind works on the generated machine code, which contains spurious
such dependencies. The generated code for this test:
if ((numDecodedBytesLB < 0) || (numDecodedBytesLB > lenEncodedLBBytes) ||
(numSamplesLB > MAX_FRAMESAMPLES)) {
looks like this:
95: 0f bf 45 d6 movswl -0x2a(%rbp),%eax
99: 3d c0 03 00 00 cmp $0x3c0,%eax
9e: 0f 8f 45 01 00 00 jg 1e9 <Decode+0x1e9>
a4: 44 89 f0 mov %r14d,%eax
a7: c1 e0 10 shl $0x10,%eax
aa: 0f 88 39 01 00 00 js 1e9 <Decode+0x1e9>
b0: 41 0f bf ce movswl %r14w,%ecx
b4: 89 8d 98 e1 ff ff mov %ecx,-0x1e68(%rbp)
ba: 41 0f bf c7 movswl %r15w,%eax
be: 39 c1 cmp %eax,%ecx
c0: 0f 8f 23 01 00 00 jg 1e9 <Decode+0x1e9>
Note how the compiler has seemingly ignored the C language's guarantee
that the arguments to || must be evaluated in left-to-right order, and
compares numSamplesLB (%eax) with MAX_FRAMESAMPLES (0x3c0, a.k.a. 960)
before the other two conditions! If the uninitialized value in
numSamplesLB happens to be greater than 960, we'll jump to
Decode+0x1e9 (where we'll return -1) without even looking at the other
two conditions. Has the compiler generated broken code?
Well, no. If numDecodedBytesLB is < 0 so that numSamplesLB is
uninitialized, we'll end up jumping to 1e9 whether that value is
greater than 960 or not; we'll just do it with different jump
instructions. This is entirely invisible as far as the C language is
concerned, but the dependency on the uninitialized value is visible at
the machine code level, which is why Memcheck complains.
This patch solves the problem by pragmatically initializing
numSamplesLB before the call even though it isn't necessary other than
for placating Memcheck.
BUG=4143
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36309004
Cr-Commit-Position: refs/heads/master@{#8492}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8492 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=4147
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8010 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=4143
TBR=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/33759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8005 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This namespace doesn't exist anymore, so remove all suppressions that
include it in the call stack.
R=kjellander@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/31639005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7419 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
to webrtc (part of the suppression that is not related to the signature differed). Fixed suppressions accordingly.
BUG=N/A
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7191 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3789
R=sprang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7136 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3789
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7116 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3789
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7105 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
from talk_base to rtc.
BUG=3478
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15079004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6819 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/16049004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6665 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
suppressions which is not allowed. Renamed the talk/base ones as they are going away.
BUG=3379
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13759004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6532 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=hta@chromium.org, kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6414 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3446
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19629005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6323 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org, wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
migrating talk/base to webrtc/base.
BUG=N/A
R=andrew@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3063
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10009004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5706 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
New errors arrived when rolling libjingle in r5502.
These suppressions are needed to green up the Memcheck and
TSan bots.
BUG=1976,2080
TEST=local runs on Linux:
tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -b out/Release -t libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool=memcheck -b out/Release -t libjingle_unittest
and trybot:
git try --bot=linux_memcheck,linux_tsan -t libjingle_unittest
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8299004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5509 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Remove the suppressions that have been fixed.
BUG=1972,2263
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2062005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4576 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Rename some of the suppressions to new issue.
Fix leaks in virtualsocket_unittest.
BUG=1972,1976,2100
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2010005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4536 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
create a local copy that is null-terminated first.
TESTED=GYP_DEFINES=build_for_tool=memcheck gclient runhooks
ninja -C out/Debug/ libjingle_unittest
tools/valgrind-webrtc/webrtc_tests.sh --tool memcheck --test out/Debug/libjingle_unittest --gtest_filter=Http*
R=noahric@google.com
Review URL: https://webrtc-codereview.appspot.com/1941004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4469 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1205,2153
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1923004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4453 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2153
TBR=mallinath
Review URL: https://webrtc-codereview.appspot.com/1914004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4439 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1205,2078,2080
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1913004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4438 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2153
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1912004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4437 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2104
R=kjellander@webrtc.org, wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1834004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4375 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
A new test target named 'modules_integrationtests' is created
and the following test targets were merged into it:
* audio_coding_module_test
* test_fec
* video_coding_integrationtests
* vp8_integrationtests
A couple of other targets were merged into modules_unittests:
* audio_coding_unittests
* audioproc_unittest
* common_unittests
* video_coding_unittests
* video_processing_unittests
* vp8_unittests
I wasn't able to merge audio_decoder_unittests and neteq_unittests due to
conflicts with different defines in these tests.
Some tests that have special requirements aren't merged into
modules_integrationtests yet. I took the opportunity to rename them
since the bot configs will need to be update anyway:
* audio_device_test_api -> audio_device_integrationtests
* video_capture_module_test -> video_capture_integrationtests
* video_render_module_test -> video_render_integrationtests
Exclude files were added for modules_integrationtests to make sure
the memcheck and tsan bots doesn't tests that are too slow
(audio_coding_module_test and vp8_integrationtests were previously
disabled on those bots).
Suppressions for AudioCodingModuleTest needed to be added to get
modules_integrationtests to pass memcheck (even if the test is
excluded from execution).
BUG=1843
TEST=local execution on Linux and trybots (passing except the merged tests of course)
R=andrew@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1656004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4228 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=1152
Review URL: https://webrtc-codereview.appspot.com/933027
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3180 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Turns out the bot is running a different version of libpthread, probably because I'm on gPrecise / gcc 4.6 whereas the bot is on 4.4? Anyway, I've generalized that stuff now.
BUG=
TEST=Ran voe & vie_auto_test under valgrind locally.
Review URL: https://webrtc-codereview.appspot.com/908004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2973 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
Review URL: https://webrtc-codereview.appspot.com/864015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2930 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
excluding timing-dependent tests.
Also Suppressed FakeMediaProcess errors (bug 898) and took out a test and suppressed general errors (bug 332). Lastly, fixed memory leak in misc test.
BUG=898, 332
TEST=Ran voe_auto_test with repeat=10 through the whole standard suite, under valgrind. Ran without valgrind. Tested that the extended and standard tests still start and are reachable from the menu.
Review URL: https://webrtc-codereview.appspot.com/855009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2898 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
These tests are really flaky for sure. None of these showed up locally or in previous runs.
BUG=
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/863006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2860 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
I will look over and split them into different bugs later - seems a bad idea to use one bug for everything.
BUG=
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/861005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2859 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/862004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2855 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Ensured there are bugs for all open valgrind issues in the standard tests and suppressed the known issues. This way, we can get it running in continuous integration and keep new issues from entering.
Removed bad check in codec test, added suppressions.
Fixed simple memory leaks in tests.
BUG=Related to bug 329
TEST=Ran the vie_auto_test standard suite many times under valgrind to root out flakiness. Ran the standard suite without valgrind to ensure I didn't break anything.
Review URL: https://webrtc-codereview.appspot.com/843005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2854 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/719005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2548 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Skeleton suppression files for future WebRTC suppressions are added and are included in addition to the ones Chrome are using and maintaining when our wrapper script executes.
Also added tweaked PRESUBMIT checks based on the Chrome code, that verifies
that suppressions are added correctly. I tested that they work by adding an invalid
suppression.
BUG=544
TEST=Tested running tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t out/Debug/system_wrappers_unittests and it reports far less errors. Tested adding bad suppression and it was caught by the PRESUBMIT check.
Review URL: https://webrtc-codereview.appspot.com/601004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2304 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
tools/valgrind-webrtc
To be able to re-use as much as possible from Chromium's scripts, I've created two customized scripts for running tests:
- webrtc_tests.py: a customized version of chrome_tests.py with WebRTC tests instead.
- webrtc_tests.sh: a customized version of the chrome_tests.sh wrapper script, to launch the above script.
The webrtc_tests.sh script is setting up PYTHONPATH so that tools/valgrind is available for the webrtc_tests.py script.
The webrtc_tests.py script inherits the chrome_tests.py script as much as possible, to minimize maintenance and maximize readability.
Having this mirrored setup of directories, allows us to use the same directory hierarchy for suppression files too. This CL only adds suppression files for memcheck, but we can add files for tsan later easily.
The suppression file is currently empty for Linux. For Mac I copied all the Chromium third-party suppressions. We will need a lot more added for Mac before Valgrind runs becomes usable for that platform.
The platform specific naming of the suppression files are handled automatically when webrtc_tests.sh is used to launch the tests.
Example:
Plain memcheck (default tool): tools/valgrind-webrtc/webrtc_tests.sh -t system_wrappers
Run ThreadSanitizer: tools/valgrind-webrtc/webrtc_tests.sh --tool=tsan -t system_wrappers
Previously mentioned AddressSanitizer requires additional scripts to be added and it not covered in this CL.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/322010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1240 4adac7df-926f-26a2-2b94-8c16560cd09d
|