Age | Commit message (Collapse) | Author |
|
Replaced trivial shift macro with >>. The actual implementation of the macro is simply >>.
Affected codecs:
* ilbc
* isac/fix
BUG=3348,3353
TESTED=locally on linux and trybots
R=henrik.lundin@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7396 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7394 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
In the StatisticsCalculator class, the member last_report_timestamp_
was unfortunately named. It's now been changed to
timestamps_since_last_report_, which describes it more accurately.
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7393 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
MSan doesn't handle inline assembly that's used by FD_ZERO causing a
false positive.
R=earthdok@chromium.org, henrike@webrtc.org
BUG=chromium:344505
Review URL: https://webrtc-codereview.appspot.com/25799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7388 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Fixes lock-order inversions between capturer's SignalVideoFrame and
WebRtcVideoSendStream. Additionally also removes all deadlock
suppressions for WebRtcVideoEngine2.
R=stefan@webrtc.org
TBR=kjellander@webrtc.org
BUG=1788,2999
Review URL: https://webrtc-codereview.appspot.com/26729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7386 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Mainly to pick up https://codereview.chromium.org/619723006/
to fix our MSan bot.
Summary of changes (git diff c264a05..fc668e2 DEPS):
* third_party/boringssl 01fe820..c7dd5f30
* third_party/usrsctp/usrsctplib 8975bd5..d5685d4
* tools/swarming_client 79940aee..33d442a
Clang updated 216630:217949 (git diff c264a05..fc668e2 tools/clang/scripts/update.sh)
This caused TSan v2 to hit an assert in libjingle_peerconnection_unittest
and libjingle_media_unittest, which is why the dlclose call
had to be disabled for now (webrtc:3895).
BUG=3895
R=henrika@webrtc.org, pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7385 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This reverts commit r7378, which broke Windows compile targets
elsewhere.
R=kjellander@webrtc.org
TBR=henrike@webrtc.org
BUG=chromium:413497
Review URL: https://webrtc-codereview.appspot.com/28679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7384 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=chromium:395700
R=jam@chromium.org
Review URL: https://webrtc-codereview.appspot.com/30659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7383 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
In r7380, the command line flag --ssrc was added to neteq_rtpplay.
However, it was not possible to omit that flag, since the validation
did not accept an empty string. This CL fixes that.
TBR=kwiberg@webrtc.org
BUG=2692
Review URL: https://webrtc-codereview.appspot.com/24869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7382 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This change opens up the possibility to set the playout mode when
creating the NetEq object. The old methods SetPlayoutMode and
PlayoutMode are still available, but are deprecated.
BUG=3520
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7381 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This allows the user to set the desired SSRC if the input file
contains multiple streams.
BUG=2692
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7380 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=chrome_373312(#24)
R=henrik.lundin@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7379 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Build settings now use use_openssl in both Chromium and standalone builds. It
moves all the platform-specific SSL-related build checks to be conditioned on
this flag as appropriate.
This is to avoid colliding with Chromium's transition away from NSS.
BUG=chromium:413497
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7378 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3836
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7377 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Reports will be written at rtcBot/test/reports/<report_name>
R=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7372 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Includes clean-up work to be able to use the webrtc::Call::Config that's
set up. This introduced a CallFactory to spawn a FakeCall with the
config used and allowed removal of FakeWebRtcVideoChannel2.
BUG=1788
R=mflodman@webrtc.org, pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7370 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=3836
R=andrew@webrtc.org, kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26669005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7369 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
RtpFileSource used to implement it's own RTP dump file reader, but
with this change it simply uses RtpFileReader. One benefit is that
pcap files are now also supported.
All NetEq test tools that use RtpFileSource are updated.
BUG=2692
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22839004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7367 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
A trivial macro that is replaced. Affected components:
* AGC
* NSx
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29599005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7366 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Mouse can be captured using MouseCursorMonitor and all code in chromium
already uses it instead of ScreenCapturer.
R=jiayl@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7363
Review URL: https://webrtc-codereview.appspot.com/31529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7365 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This reverts commit 0adc4953512ee0a57cf7f3c0591b024c2316554a. It broke
FYI bots
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/27649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7364 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Mouse can be captured using MouseCursorMonitor and all code in chromium
already uses it instead of ScreenCapturer.
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7363 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=https://code.google.com/p/webrtc/issues/detail?id=3245
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7362 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Add code for doing block-based frequency domain processing. Developed
and reviewed in isolation. Corresponding export CL:
https://chromereviews.googleplex.com/95187013/
R=bercic@google.com, kjellander@webrtc.org, turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7359 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7358 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=henrik.lundin@webrtc.org
BUG=3873
TEST=third_party/gtest-parallel/gtest-parallel -r 10 -w 64 out/Debug/modules_tests
Review URL: https://webrtc-codereview.appspot.com/24799004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7354 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This reverts r7277.
TBR=henrika@webrtc.org,pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7353 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Similar changes as in https://review.webrtc.org/28589004/
were missed in https://review.webrtc.org/25569004/.
This should fix the Chromium WebRTC FYI bots that currently
are broken due to lack of include paths.
BUG=3441
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25749004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7347 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Libvpx now supports GN and this CL turns on compiling it.
I also introduced an executable target 'webrtc_tests'
that depends on all in WeBRTC + tests in order to get a full
linking step executed (since we've seen link problems for GN
when rolling WebRTC into Chromium).
I also converted a few test targets and made a GN file for
third_party/gflags.
BUG=3441
TESTED=Trybots + full Chromium build with a symlinked src/third_party/webrtc
dir to a workspace wit this CL applied.
R=brettw@chromium.org
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7344 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Chromium commit URL: https://crrev.com/c8a5da7455b57b2399e4a69e8100c098d9870052
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23809004
Patch from Ljubomir Papuga <lpapuga@mips.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7343 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> Reland 28629004: adding new AEC dump start interface for chrome
>
> adding new AEC dump start interface for chrome.
>
> This is required because we are not allow to pass CRT objects across dll boundaries, that says, when we pass a file descriptor from chrome dll to libpeerconnection dll, the file descriptor will become invalid immediate, more information can be found here:
> http://msdn.microsoft.com/en-us/library/ms235460.aspx
>
> Chromium bug:crbug/415935
> TEST=bots
> R=bjornv@webrtc.org, kwiberg@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/27639004
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7342 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> Fixed the android build by making the interface pure virtual.
>
> TBR=asapersson@webrtc.org, bjornv@webrtc.org,
>
> Review URL: https://webrtc-codereview.appspot.com/24789004
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7341 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
and prepare the format these collected stats to be plotted using one of
external dev-tools.
R=andresp@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29589004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7340 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
R=andrew@webrtc.org, bjornv@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26619004
Patch from Ljubomir Papuga <lpapuga@mips.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7339 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
TBR=asapersson@webrtc.org, bjornv@webrtc.org,
Review URL: https://webrtc-codereview.appspot.com/24789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7338 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
adding new AEC dump start interface for chrome.
This is required because we are not allow to pass CRT objects across dll boundaries, that says, when we pass a file descriptor from chrome dll to libpeerconnection dll, the file descriptor will become invalid immediate, more information can be found here:
http://msdn.microsoft.com/en-us/library/ms235460.aspx
Chromium bug:crbug/415935
TEST=bots
R=bjornv@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27639004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7337 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=N/A
R=andrew@webrtc.org, kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31499004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7336 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
> adding new AEC dump start interface for chrome.
>
> This is required because we are not allow to pass CRT objects across dll boundaries, that says, when we pass a file descriptor from chrome dll to libpeerconnection dll, the file descriptor will become invalid immediate, more information can be found here:
> http://msdn.microsoft.com/en-us/library/ms235460.aspx
>
> Chromium bug:crbug/415935
> TEST=bots
> R=bjornv@webrtc.org, kwiberg@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/28629004
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7335 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This is required because we are not allow to pass CRT objects across dll boundaries, that says, when we pass a file descriptor from chrome dll to libpeerconnection dll, the file descriptor will become invalid immediate, more information can be found here:
http://msdn.microsoft.com/en-us/library/ms235460.aspx
Chromium bug:crbug/415935
TEST=bots
R=bjornv@webrtc.org, kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7334 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Adding original_length to the Packet struct. This is populated with
the plen value from the RTP dump file. In the case of reading a
pcap file, original_length will be equal to length.
Also increasing the maximum packet size to 3500 bytes. This is to
accomodate some test files that contain PCM16b audio encoding.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7333 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The same operation of calculating log of the energy was executed four times. This CL adds a help function LogOfEnergyInQ8() for that.
BUG=N/A
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22819004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7331 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
WEBRTC_SPL_MUL is a trivial multiplication after casting to int32_t. This is already taken care of by the compiler which makes the macro unnecessary.
Affected components:
* AGC
* NSx
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7330 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Affected components:
* AECM
* AGC
* HPF
* NSx
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7329 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
Breaks debug compilation (didn't run all trybots when testing this).
> Update isolate.gypi files + link to isolate_driver.py
>
> This updates the isolate.gypi copies we're forced to
> maintain in our code repo to Chromium revision c264a05.
>
> Since isolated testing is now using a new launch script
> in tools: isolate_driver.py, that is added to our links
> script.
>
> BUG=395700
> TESTED=Ran one of our tests with:
> ninja -C out/Release tools_unittests_run
> tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate
>
> R=henrika@webrtc.org, jam@chromium.org
>
> Review URL: https://webrtc-codereview.appspot.com/26649004
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7328 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This updates the isolate.gypi copies we're forced to
maintain in our code repo to Chromium revision c264a05.
Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that is added to our links
script.
BUG=395700
TESTED=Ran one of our tests with:
ninja -C out/Release tools_unittests_run
tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate
R=henrika@webrtc.org, jam@chromium.org
Review URL: https://webrtc-codereview.appspot.com/26649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7327 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This fixed the issue that invoking the call when the thread is not started.
BUG=3559
R=juberti@webrtc.org, thorcarpenter@google.com
Review URL: https://webrtc-codereview.appspot.com/24769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7325 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
This makes it possible to restrict threads from modifying scheduling
parameters of another thread in the Chrome Linux sandbox.
BUG=
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7324 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
BUG=2600
TESTED=Passing tests using:
python third_party/gtest-parallel/gtest-parallel -w 10 -r 20 out/Release/test_support_unittests
python third_party/gtest-parallel/gtest-parallel -w 10 -r 20 out/Release/tools_unittests
python third_party/gtest-parallel/gtest-parallel -w 10 -r 20 out/Release/video_engine_tests
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7322 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
A trivial macro that serves no purpose. Affected components are:
* audio_processing/nsx
* audio_processing/agc
* audio_processing/aecm
* common_audio/LpcToReflCoef
BUG=3348,3353
TESTED=locally on linux
R=kwiberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7321 4adac7df-926f-26a2-2b94-8c16560cd09d
|
|
The macro is a trivial shift operator including a cast before shift. There is no guard against negative shifts. Replaced with << at place and added casts when necessary.
Affects both fixed and float point versions of iSAC
BUG=3348,3353
TESTED=locally on linux and trybots
R=kwiberg@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7320 4adac7df-926f-26a2-2b94-8c16560cd09d
|